1. Patchew
  2. linux
  3. [PATCH 0/3] clk: renesas: Add SDHI and RIIC clock support for RZ/T2H and RZ/N2H
  4. View patch

[PATCH 3/3] clk: renesas: r9a09g077-cpg: Add RIIC module clocks

Prabhakar posted 3 patches 3 months, 2 weeks ago
[PATCH 3/3] clk: renesas: r9a09g077-cpg: Add RIIC module clocks
Posted by Prabhakar 3 months, 2 weeks ago 
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Add RIIC module clocks for: iic0, iic1, and iic2.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/clk/renesas/r9a09g077-cpg.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clk/renesas/r9a09g077-cpg.c b/drivers/clk/renesas/r9a09g077-cpg.c
index 93862d84f95f..ed1e94cbd267 100644
--- a/drivers/clk/renesas/r9a09g077-cpg.c
+++ b/drivers/clk/renesas/r9a09g077-cpg.c
@@ -154,6 +154,9 @@ static const struct cpg_core_clk r9a09g077_core_clks[] __initconst = {
 
 static const struct mssr_mod_clk r9a09g077_mod_clks[] __initconst = {
 	DEF_MOD("sci0fck", 8, CLK_SCI0ASYNC),
+	DEF_MOD("iic0", 100, R9A09G077_CLK_PCLKL),
+	DEF_MOD("iic1", 101, R9A09G077_CLK_PCLKL),
+	DEF_MOD("iic2", 501, R9A09G077_CLK_PCLKL),
 	DEF_MOD("sdhi0", 1212, R9A09G077_CLK_PCLKAM),
 	DEF_MOD("sdhi1", 1213, R9A09G077_CLK_PCLKAM),
 };
-- 
2.49.0
Re: [PATCH 3/3] clk: renesas: r9a09g077-cpg: Add RIIC module clocks
Posted by Geert Uytterhoeven 3 months, 1 week ago 
Hi Prabhakar,

On Wed, 25 Jun 2025 at 16:17, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Add RIIC module clocks for: iic0, iic1, and iic2.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/drivers/clk/renesas/r9a09g077-cpg.c
> +++ b/drivers/clk/renesas/r9a09g077-cpg.c
> @@ -154,6 +154,9 @@ static const struct cpg_core_clk r9a09g077_core_clks[] __initconst = {
>
>  static const struct mssr_mod_clk r9a09g077_mod_clks[] __initconst = {
>         DEF_MOD("sci0fck", 8, CLK_SCI0ASYNC),
> +       DEF_MOD("iic0", 100, R9A09G077_CLK_PCLKL),
> +       DEF_MOD("iic1", 101, R9A09G077_CLK_PCLKL),
> +       DEF_MOD("iic2", 501, R9A09G077_CLK_PCLKL),

Shouldn't that be 601?
(MSTPCRA => xx, MSTPCRB => 1xx, MSTPCRG => 6xx)
If you agree, I can fix that while applying...

>         DEF_MOD("sdhi0", 1212, R9A09G077_CLK_PCLKAM),
>         DEF_MOD("sdhi1", 1213, R9A09G077_CLK_PCLKAM),
>  };

The rest LGTM, so with the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [PATCH 3/3] clk: renesas: r9a09g077-cpg: Add RIIC module clocks
Posted by Lad, Prabhakar 3 months, 1 week ago 
Hi Geert,

Thank you for the review.

On Wed, Jul 2, 2025 at 2:46 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Wed, 25 Jun 2025 at 16:17, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Add RIIC module clocks for: iic0, iic1, and iic2.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/drivers/clk/renesas/r9a09g077-cpg.c
> > +++ b/drivers/clk/renesas/r9a09g077-cpg.c
> > @@ -154,6 +154,9 @@ static const struct cpg_core_clk r9a09g077_core_clks[] __initconst = {
> >
> >  static const struct mssr_mod_clk r9a09g077_mod_clks[] __initconst = {
> >         DEF_MOD("sci0fck", 8, CLK_SCI0ASYNC),
> > +       DEF_MOD("iic0", 100, R9A09G077_CLK_PCLKL),
> > +       DEF_MOD("iic1", 101, R9A09G077_CLK_PCLKL),
> > +       DEF_MOD("iic2", 501, R9A09G077_CLK_PCLKL),
>
> Shouldn't that be 601?
> (MSTPCRA => xx, MSTPCRB => 1xx, MSTPCRG => 6xx)
> If you agree, I can fix that while applying...
>
Agreed, thank you for taking care of it.

Cheers,
Prabhakar

> >         DEF_MOD("sdhi0", 1212, R9A09G077_CLK_PCLKAM),
> >         DEF_MOD("sdhi1", 1213, R9A09G077_CLK_PCLKAM),
> >  };
>
> The rest LGTM, so with the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
Re: [PATCH 3/3] clk: renesas: r9a09g077-cpg: Add RIIC module clocks
Posted by Geert Uytterhoeven 3 months, 1 week ago 
Hi Prabhakar,

On Wed, 2 Jul 2025 at 21:30, Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> On Wed, Jul 2, 2025 at 2:46 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, 25 Jun 2025 at 16:17, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > >
> > > Add RIIC module clocks for: iic0, iic1, and iic2.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Thanks for your patch!
> >
> > > --- a/drivers/clk/renesas/r9a09g077-cpg.c
> > > +++ b/drivers/clk/renesas/r9a09g077-cpg.c
> > > @@ -154,6 +154,9 @@ static const struct cpg_core_clk r9a09g077_core_clks[] __initconst = {
> > >
> > >  static const struct mssr_mod_clk r9a09g077_mod_clks[] __initconst = {
> > >         DEF_MOD("sci0fck", 8, CLK_SCI0ASYNC),
> > > +       DEF_MOD("iic0", 100, R9A09G077_CLK_PCLKL),
> > > +       DEF_MOD("iic1", 101, R9A09G077_CLK_PCLKL),
> > > +       DEF_MOD("iic2", 501, R9A09G077_CLK_PCLKL),
> >
> > Shouldn't that be 601?
> > (MSTPCRA => xx, MSTPCRB => 1xx, MSTPCRG => 6xx)
> > If you agree, I can fix that while applying...
> >
> Agreed, thank you for taking care of it.

Thanks, queued in renesas-clk for v6.17, and pushed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.