.../admin-guide/media/radio-cardlist.rst | 1 - drivers/media/radio/Kconfig | 17 - drivers/media/radio/Makefile | 1 - drivers/media/radio/radio-wl1273.c | 2159 ----------------- drivers/mfd/Kconfig | 10 - drivers/mfd/Makefile | 1 - drivers/mfd/wl1273-core.c | 262 -- include/linux/mfd/wl1273-core.h | 277 --- sound/soc/codecs/Kconfig | 4 - sound/soc/codecs/Makefile | 4 +- sound/soc/codecs/wl1273.c | 500 ---- sound/soc/codecs/wl1273.h | 16 - 12 files changed, 1 insertion(+), 3251 deletions(-) delete mode 100644 drivers/media/radio/radio-wl1273.c delete mode 100644 drivers/mfd/wl1273-core.c delete mode 100644 include/linux/mfd/wl1273-core.h delete mode 100644 sound/soc/codecs/wl1273.c delete mode 100644 sound/soc/codecs/wl1273.h
From: "Dr. David Alan Gilbert" <linux@treblig.org> I noticed that the wl1273 radio had an unused symbol, but then noticed it is on Arnd's unused driver list: https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/ So, delete it. The components seem pretty separable, except for Kconfig dependencies. That lore URL is over 75 chars, which checkpatch warns about, suggestions welcome. Dave Dr. David Alan Gilbert (4): media: radio-wl1273: Remove ASoC: wl1273: Remove mfd: wl1273-core: Remove mfd: wl1273-core: Remove the header .../admin-guide/media/radio-cardlist.rst | 1 - drivers/media/radio/Kconfig | 17 - drivers/media/radio/Makefile | 1 - drivers/media/radio/radio-wl1273.c | 2159 ----------------- drivers/mfd/Kconfig | 10 - drivers/mfd/Makefile | 1 - drivers/mfd/wl1273-core.c | 262 -- include/linux/mfd/wl1273-core.h | 277 --- sound/soc/codecs/Kconfig | 4 - sound/soc/codecs/Makefile | 4 +- sound/soc/codecs/wl1273.c | 500 ---- sound/soc/codecs/wl1273.h | 16 - 12 files changed, 1 insertion(+), 3251 deletions(-) delete mode 100644 drivers/media/radio/radio-wl1273.c delete mode 100644 drivers/mfd/wl1273-core.c delete mode 100644 include/linux/mfd/wl1273-core.h delete mode 100644 sound/soc/codecs/wl1273.c delete mode 100644 sound/soc/codecs/wl1273.h -- 2.49.0
On Wed, Jun 25, 2025 at 02:32:54PM +0100, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > I noticed that the wl1273 radio had an unused symbol, but then noticed > it is on Arnd's unused driver list: > https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/ > > So, delete it. > The components seem pretty separable, except for Kconfig dependencies. > > That lore URL is over 75 chars, which checkpatch warns about, > suggestions welcome. > > Dave > > Dr. David Alan Gilbert (4): > media: radio-wl1273: Remove > ASoC: wl1273: Remove > mfd: wl1273-core: Remove > mfd: wl1273-core: Remove the header Mark, Lee, how would you like this to be merged ? I have a large patch series targetting v6.18 that depends on 1/4, and I would like to merge it in the media tree as soon as possible after -rc1 gets released. Patches 1/4, 2/4 and 3/4 are independent of each other, but patch 4/4 depends on the first three. Can we merge 1/4 in the media tree and provide a stable branch right on top of -rc1 ? > .../admin-guide/media/radio-cardlist.rst | 1 - > drivers/media/radio/Kconfig | 17 - > drivers/media/radio/Makefile | 1 - > drivers/media/radio/radio-wl1273.c | 2159 ----------------- > drivers/mfd/Kconfig | 10 - > drivers/mfd/Makefile | 1 - > drivers/mfd/wl1273-core.c | 262 -- > include/linux/mfd/wl1273-core.h | 277 --- > sound/soc/codecs/Kconfig | 4 - > sound/soc/codecs/Makefile | 4 +- > sound/soc/codecs/wl1273.c | 500 ---- > sound/soc/codecs/wl1273.h | 16 - > 12 files changed, 1 insertion(+), 3251 deletions(-) > delete mode 100644 drivers/media/radio/radio-wl1273.c > delete mode 100644 drivers/mfd/wl1273-core.c > delete mode 100644 include/linux/mfd/wl1273-core.h > delete mode 100644 sound/soc/codecs/wl1273.c > delete mode 100644 sound/soc/codecs/wl1273.h -- Regards, Laurent Pinchart
On Fri, 08 Aug 2025, Laurent Pinchart wrote: > On Wed, Jun 25, 2025 at 02:32:54PM +0100, linux@treblig.org wrote: > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > I noticed that the wl1273 radio had an unused symbol, but then noticed > > it is on Arnd's unused driver list: > > https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/ > > > > So, delete it. > > The components seem pretty separable, except for Kconfig dependencies. > > > > That lore URL is over 75 chars, which checkpatch warns about, > > suggestions welcome. > > > > Dave > > > > Dr. David Alan Gilbert (4): > > media: radio-wl1273: Remove > > ASoC: wl1273: Remove > > mfd: wl1273-core: Remove > > mfd: wl1273-core: Remove the header > > Mark, Lee, how would you like this to be merged ? I have a large patch > series targetting v6.18 that depends on 1/4, and I would like to merge > it in the media tree as soon as possible after -rc1 gets released. > Patches 1/4, 2/4 and 3/4 are independent of each other, but patch 4/4 > depends on the first three. Can we merge 1/4 in the media tree and > provide a stable branch right on top of -rc1 ? I'm also set-up pretty well to provide this. Happy either way. If you decide to take it: Acked-by: Lee Jones <lee@kernel.org> -- Lee Jones [李琼斯]
On Tue, Sep 02, 2025 at 11:32:49AM +0100, Lee Jones wrote: > On Fri, 08 Aug 2025, Laurent Pinchart wrote: > > On Wed, Jun 25, 2025 at 02:32:54PM +0100, linux@treblig.org wrote: > > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > > > I noticed that the wl1273 radio had an unused symbol, but then noticed > > > it is on Arnd's unused driver list: > > > https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/ > > > > > > So, delete it. > > > The components seem pretty separable, except for Kconfig dependencies. > > > > > > That lore URL is over 75 chars, which checkpatch warns about, > > > suggestions welcome. > > > > > > Dave > > > > > > Dr. David Alan Gilbert (4): > > > media: radio-wl1273: Remove > > > ASoC: wl1273: Remove > > > mfd: wl1273-core: Remove > > > mfd: wl1273-core: Remove the header > > > > Mark, Lee, how would you like this to be merged ? I have a large patch > > series targetting v6.18 that depends on 1/4, and I would like to merge > > it in the media tree as soon as possible after -rc1 gets released. > > Patches 1/4, 2/4 and 3/4 are independent of each other, but patch 4/4 > > depends on the first three. Can we merge 1/4 in the media tree and > > provide a stable branch right on top of -rc1 ? > > I'm also set-up pretty well to provide this. Happy either way. > > If you decide to take it: > > Acked-by: Lee Jones <lee@kernel.org> Patch 1/4 has been queued in the media tree and should be in linux-next as commit 103b0cfc9ab6. It is based straight on v6.17-rc1. Patch 2/4 is also in linux-next, but is based on other ALSA patches. The simplest course of action would be for you to merge 3/4 for v6.18, and 4/4 for v6.19. -- Regards, Laurent Pinchart
On Tue, Sep 02, 2025 at 01:35:27PM +0200, Laurent Pinchart wrote: > Patch 1/4 has been queued in the media tree and should be in linux-next > as commit 103b0cfc9ab6. It is based straight on v6.17-rc1. Patch 2/4 is > also in linux-next, but is based on other ALSA patches. The simplest > course of action would be for you to merge 3/4 for v6.18, and 4/4 for > v6.19. Or given that it's a driver removal we could just get a rebase of the series against the meda tree applied? The conflicts with ASoC should be trivial to resolve.
On Tue, Sep 02, 2025 at 12:47:39PM +0100, Mark Brown wrote: > On Tue, Sep 02, 2025 at 01:35:27PM +0200, Laurent Pinchart wrote: > > > Patch 1/4 has been queued in the media tree and should be in linux-next > > as commit 103b0cfc9ab6. It is based straight on v6.17-rc1. Patch 2/4 is > > also in linux-next, but is based on other ALSA patches. The simplest > > course of action would be for you to merge 3/4 for v6.18, and 4/4 for > > v6.19. > > Or given that it's a driver removal we could just get a rebase of the > series against the meda tree applied? The conflicts with ASoC should be > trivial to resolve. I don't mind either way. I know Linus doesn't like having the same patch merged with different commit IDs, but I don't know how strict the rule is, especially when git should be able to resolve the conflict transparently. -- Regards, Laurent Pinchart
* Laurent Pinchart (laurent.pinchart@ideasonboard.com) wrote: > On Tue, Sep 02, 2025 at 12:47:39PM +0100, Mark Brown wrote: > > On Tue, Sep 02, 2025 at 01:35:27PM +0200, Laurent Pinchart wrote: > > > > > Patch 1/4 has been queued in the media tree and should be in linux-next > > > as commit 103b0cfc9ab6. It is based straight on v6.17-rc1. Patch 2/4 is > > > also in linux-next, but is based on other ALSA patches. The simplest > > > course of action would be for you to merge 3/4 for v6.18, and 4/4 for > > > v6.19. > > > > Or given that it's a driver removal we could just get a rebase of the > > series against the meda tree applied? The conflicts with ASoC should be > > trivial to resolve. > > I don't mind either way. I know Linus doesn't like having the same patch > merged with different commit IDs, but I don't know how strict the rule > is, especially when git should be able to resolve the conflict > transparently. I still think the easiest thing is to leave 1/4 and 2/4 as you currently have them; and let Lee take 3/4 and 4/4 next time around. Dave > -- > Regards, > > Laurent Pinchart > -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
On Tue, 02 Sep 2025, Dr. David Alan Gilbert wrote: > * Laurent Pinchart (laurent.pinchart@ideasonboard.com) wrote: > > On Tue, Sep 02, 2025 at 12:47:39PM +0100, Mark Brown wrote: > > > On Tue, Sep 02, 2025 at 01:35:27PM +0200, Laurent Pinchart wrote: > > > > > > > Patch 1/4 has been queued in the media tree and should be in linux-next > > > > as commit 103b0cfc9ab6. It is based straight on v6.17-rc1. Patch 2/4 is > > > > also in linux-next, but is based on other ALSA patches. The simplest > > > > course of action would be for you to merge 3/4 for v6.18, and 4/4 for > > > > v6.19. > > > > > > Or given that it's a driver removal we could just get a rebase of the > > > series against the meda tree applied? The conflicts with ASoC should be > > > trivial to resolve. > > > > I don't mind either way. I know Linus doesn't like having the same patch > > merged with different commit IDs, but I don't know how strict the rule > > is, especially when git should be able to resolve the conflict > > transparently. > > I still think the easiest thing is to leave 1/4 and 2/4 as you currently > have them; and let Lee take 3/4 and 4/4 next time around. It's more disjointed than I like. But it's okay. Remind me later. -- Lee Jones [李琼斯]
* Lee Jones (lee@kernel.org) wrote: > On Tue, 02 Sep 2025, Dr. David Alan Gilbert wrote: > > > * Laurent Pinchart (laurent.pinchart@ideasonboard.com) wrote: > > > On Tue, Sep 02, 2025 at 12:47:39PM +0100, Mark Brown wrote: > > > > On Tue, Sep 02, 2025 at 01:35:27PM +0200, Laurent Pinchart wrote: > > > > > > > > > Patch 1/4 has been queued in the media tree and should be in linux-next > > > > > as commit 103b0cfc9ab6. It is based straight on v6.17-rc1. Patch 2/4 is > > > > > also in linux-next, but is based on other ALSA patches. The simplest > > > > > course of action would be for you to merge 3/4 for v6.18, and 4/4 for > > > > > v6.19. > > > > > > > > Or given that it's a driver removal we could just get a rebase of the > > > > series against the meda tree applied? The conflicts with ASoC should be > > > > trivial to resolve. > > > > > > I don't mind either way. I know Linus doesn't like having the same patch > > > merged with different commit IDs, but I don't know how strict the rule > > > is, especially when git should be able to resolve the conflict > > > transparently. > > > > I still think the easiest thing is to leave 1/4 and 2/4 as you currently > > have them; and let Lee take 3/4 and 4/4 next time around. > > It's more disjointed than I like. But it's okay. Remind me later. Hi Lee, 1 and 2 of this series just got merged into Linus' tree. Thanks all! 3 and 4 can go in at your convenience. Dave > -- > Lee Jones [李琼斯] > -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
On Tue, Sep 02, 2025 at 11:32:49AM +0100, Lee Jones wrote: > On Fri, 08 Aug 2025, Laurent Pinchart wrote: > > Mark, Lee, how would you like this to be merged ? I have a large patch > > series targetting v6.18 that depends on 1/4, and I would like to merge > > it in the media tree as soon as possible after -rc1 gets released. > > Patches 1/4, 2/4 and 3/4 are independent of each other, but patch 4/4 > > depends on the first three. Can we merge 1/4 in the media tree and > > provide a stable branch right on top of -rc1 ? > I'm also set-up pretty well to provide this. Happy either way. > If you decide to take it: > Acked-by: Lee Jones <lee@kernel.org> Yeah, me too - I acked already and I was expecting someone else to take the series, whoever it is that's fine.
On Wed, Jun 25, 2025, at 15:32, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> I noticed that the wl1273 radio had an unused symbol, but then noticed
> it is on Arnd's unused driver list:
>
> https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/
>
> So, delete it.
> The components seem pretty separable, except for Kconfig dependencies.
>
> That lore URL is over 75 chars, which checkpatch warns about,
> suggestions welcome.
Acked-by: Arnd Bergmann <arnd@arndb.de>
For reference, the driver was added in 2010 with commit 383268a8e282
("[media] MFD: WL1273 FM Radio: MFD driver for the FM radio"). It
requires platform_data to be defined in a board file, but we never
had any such board files doing this upstream.
The chip is apparently the Bluetooth/Wifi combo chip on the Nokia N9
and others, and is supported for those subsystems by the wlcore
driver. Clearly nobody cared enough about FM radio functionality
for the past 15 years to add the missing bits.
The author was last active on the mailing list in 2012.
Arnd
On Wed, 25 Jun 2025 14:32:54 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> I noticed that the wl1273 radio had an unused symbol, but then noticed
> it is on Arnd's unused driver list:
> https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/
>
> So, delete it.
> The components seem pretty separable, except for Kconfig dependencies.
>
> [...]
Applied, thanks!
[3/4] mfd: wl1273-core: Remove
commit: efddd98938400a570bde5bc69b5ecc7e76cacbe1
[4/4] mfd: wl1273-core: Remove the header
commit: d356033e7b1e94e0187bb0651f4a066a4646fbb9
--
Lee Jones [李琼斯]
Hi Lee, On Tue, Jul 01, 2025 at 02:27:43PM +0100, Lee Jones wrote: > On Wed, 25 Jun 2025 14:32:54 +0100, linux@treblig.org wrote: > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > I noticed that the wl1273 radio had an unused symbol, but then noticed > > it is on Arnd's unused driver list: > > https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/ > > > > So, delete it. > > The components seem pretty separable, except for Kconfig dependencies. > > > > [...] > > Applied, thanks! > > [3/4] mfd: wl1273-core: Remove > commit: efddd98938400a570bde5bc69b5ecc7e76cacbe1 > [4/4] mfd: wl1273-core: Remove the header > commit: d356033e7b1e94e0187bb0651f4a066a4646fbb9 Ah, that may answer the question I just posted in another reply to the cover letter. I think patch 4/4 will break build in -next until patches 1/4 and 2/4 get merged too. Should we get 1/4 and 2/4 merged in the media and sound trees ASAP, or would you prefer a different option ? -- Regards, Laurent Pinchart
* Laurent Pinchart (laurent.pinchart@ideasonboard.com) wrote: > Hi Lee, > > On Tue, Jul 01, 2025 at 02:27:43PM +0100, Lee Jones wrote: > > On Wed, 25 Jun 2025 14:32:54 +0100, linux@treblig.org wrote: > > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > > > I noticed that the wl1273 radio had an unused symbol, but then noticed > > > it is on Arnd's unused driver list: > > > https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/ > > > > > > So, delete it. > > > The components seem pretty separable, except for Kconfig dependencies. > > > > > > [...] > > > > Applied, thanks! > > > > [3/4] mfd: wl1273-core: Remove > > commit: efddd98938400a570bde5bc69b5ecc7e76cacbe1 > > [4/4] mfd: wl1273-core: Remove the header > > commit: d356033e7b1e94e0187bb0651f4a066a4646fbb9 > > Ah, that may answer the question I just posted in another reply to the > cover letter. > > I think patch 4/4 will break build in -next until patches 1/4 and 2/4 > get merged too. Should we get 1/4 and 2/4 merged in the media and sound > trees ASAP, or would you prefer a different option ? That makes sense to me. Dave > > -- > Regards, > > Laurent Pinchart -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
On Wed, 25 Jun 2025 14:32:54 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> I noticed that the wl1273 radio had an unused symbol, but then noticed
> it is on Arnd's unused driver list:
> https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/
>
> So, delete it.
> The components seem pretty separable, except for Kconfig dependencies.
>
> [...]
Applied, thanks!
[3/4] mfd: wl1273-core: Remove
commit: 2ec8f54725b2ae4f08aeae0483410280e72877e3
[4/4] mfd: wl1273-core: Remove the header
commit: 5576355937ad7d0ec86ca2cdf4e82cb0f70cd227
--
Lee Jones [李琼斯]
On Wed, 25 Jun 2025 14:32:54 +0100, linux@treblig.org wrote:
> I noticed that the wl1273 radio had an unused symbol, but then noticed
> it is on Arnd's unused driver list:
> https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/
>
> So, delete it.
> The components seem pretty separable, except for Kconfig dependencies.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[2/4] ASoC: wl1273: Remove
commit: a46e95c81e3a28926ab1904d9f754fef8318074d
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
* Mark Brown (broonie@kernel.org) wrote: > On Wed, 25 Jun 2025 14:32:54 +0100, linux@treblig.org wrote: > > I noticed that the wl1273 radio had an unused symbol, but then noticed > > it is on Arnd's unused driver list: > > https://lore.kernel.org/lkml/a15bb180-401d-49ad-a212-0c81d613fbc8@app.fastmail.com/ > > > > So, delete it. > > The components seem pretty separable, except for Kconfig dependencies. > > > > [...] > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! I see that in next; so Lee can do 3/4-4/4 maybe in the following cycle or later in this one. Dave > Thanks! > > [2/4] ASoC: wl1273: Remove > commit: a46e95c81e3a28926ab1904d9f754fef8318074d > > All being well this means that it will be integrated into the linux-next > tree (usually sometime in the next 24 hours) and sent to Linus during > the next merge window (or sooner if it is a bug fix), however if > problems are discovered then the patch may be dropped or reverted. > > You may get further e-mails resulting from automated or manual testing > and review of the tree, please engage with people reporting problems and > send followup patches addressing any issues that are reported if needed. > > If any updates are required or you are submitting further changes they > should be sent as incremental updates against current git, existing > patches will not be replaced. > > Please add any relevant lists and maintainers to the CCs when replying > to this mail. > > Thanks, > Mark > -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
© 2016 - 2025 Red Hat, Inc.