wifi: mt76: mt7925: Fix null-ptr-deref in mt7925_thermal_init()

[PATCH v1] wifi: mt76: mt7925: Fix null-ptr-deref in mt7925_thermal_init()

Posted by Henry Martin 3 months, 2 weeks ago

devm_kasprintf() returns NULL on error. Currently, mt7925_thermal_init()
does not check for this case, which results in a NULL pointer
dereference.

Add NULL check after devm_kasprintf() to prevent this issue.

Fixes: 396e41a74a88 ("wifi: mt76: mt7925: support temperature sensor")
Signed-off-by: Henry Martin <bsdhenryma@tencent.com>
---
 drivers/net/wireless/mediatek/mt76/mt7925/init.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/init.c b/drivers/net/wireless/mediatek/mt76/mt7925/init.c
index 2a83ff59a968..4249bad83c93 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7925/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7925/init.c
@@ -52,6 +52,8 @@ static int mt7925_thermal_init(struct mt792x_phy *phy)
 
 	name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7925_%s",
 			      wiphy_name(wiphy));
+	if (!name)
+		return -ENOMEM;
 
 	hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, phy,
 						       mt7925_hwmon_groups);
-- 
2.41.3

Re: [PATCH v1] wifi: mt76: mt7925: Fix null-ptr-deref in mt7925_thermal_init()

Posted by AngeloGioacchino Del Regno 3 months, 2 weeks ago

Il 25/06/25 14:49, Henry Martin ha scritto:
> devm_kasprintf() returns NULL on error. Currently, mt7925_thermal_init()
> does not check for this case, which results in a NULL pointer
> dereference.
> 
> Add NULL check after devm_kasprintf() to prevent this issue.
> 
> Fixes: 396e41a74a88 ("wifi: mt76: mt7925: support temperature sensor")
> Signed-off-by: Henry Martin <bsdhenryma@tencent.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>