[PATCH v3 0/2] support large align and nid in Rust allocators

Vitaly Wool posted 2 patches 3 months, 2 weeks ago
There is a newer version of this series
[PATCH v3 0/2] support large align and nid in Rust allocators
Posted by Vitaly Wool 3 months, 2 weeks ago
The coming patches provide the ability for Rust allocators to set
NUMA node and large alignment.

Changelog:
v2 -> v3: fixed the build breakage for non-MMU configs

Signed-off-by: Vitaly Wool <vitaly.wool@konsulko.se>
Re: [PATCH v3 0/2] support large align and nid in Rust allocators
Posted by Andrew Morton 3 months, 2 weeks ago
On Wed, 25 Jun 2025 08:29:17 +0200 Vitaly Wool <vitaly.wool@konsulko.se> wrote:

> The coming patches provide the ability for Rust allocators to set
> NUMA node and large alignment.

Including a diffstat would be nice.

 include/linux/vmalloc.h        |    8 +++---
 mm/nommu.c                     |    3 +-
 mm/vmalloc.c                   |   16 ++++++++++--
 rust/helpers/slab.c            |    8 ++++--
 rust/helpers/vmalloc.c         |    4 +--
 rust/kernel/alloc.rs           |   28 ++++++++++++++++++++-
 rust/kernel/alloc/allocator.rs |   40 +++++++++++++++++--------------
 rust/kernel/alloc/kvec.rs      |    3 +-
 8 files changed, 79 insertions(+), 31 deletions(-)

What is the preferred merge path for this series?
Re: [PATCH v3 0/2] support large align and nid in Rust allocators
Posted by Danilo Krummrich 3 months, 2 weeks ago
On Wed, Jun 25, 2025 at 02:10:22PM -0700, Andrew Morton wrote:
> On Wed, 25 Jun 2025 08:29:17 +0200 Vitaly Wool <vitaly.wool@konsulko.se> wrote:
> 
> > The coming patches provide the ability for Rust allocators to set
> > NUMA node and large alignment.
> 
> Including a diffstat would be nice.
> 
>  include/linux/vmalloc.h        |    8 +++---
>  mm/nommu.c                     |    3 +-
>  mm/vmalloc.c                   |   16 ++++++++++--
>  rust/helpers/slab.c            |    8 ++++--
>  rust/helpers/vmalloc.c         |    4 +--
>  rust/kernel/alloc.rs           |   28 ++++++++++++++++++++-
>  rust/kernel/alloc/allocator.rs |   40 +++++++++++++++++--------------
>  rust/kernel/alloc/kvec.rs      |    3 +-
>  8 files changed, 79 insertions(+), 31 deletions(-)
> 
> What is the preferred merge path for this series?

I can take it through my Rust alloc tree, but I think it would probably be
better you take it through the mm tree, since I don't expect this to conflict
with anything else in my tree anyways.

The Rust changes gonna need some more discussion though.

- Danilo
Re: [PATCH v3 0/2] support large align and nid in Rust allocators
Posted by Andrew Morton 3 months, 2 weeks ago
On Wed, 25 Jun 2025 23:15:46 +0200 Danilo Krummrich <dakr@kernel.org> wrote:

> > What is the preferred merge path for this series?
> 
> I can take it through my Rust alloc tree, but I think it would probably be
> better you take it through the mm tree, since I don't expect this to conflict
> with anything else in my tree anyways.

No probs.

> The Rust changes gonna need some more discussion though.

Great, I'll add a note-to-self that discussion is ongoing.
Re: [PATCH v3 0/2] support large align and nid in Rust allocators
Posted by Vitaly Wool 3 months, 2 weeks ago

> On Jun 25, 2025, at 11:34 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> On Wed, 25 Jun 2025 23:15:46 +0200 Danilo Krummrich <dakr@kernel.org> wrote:
> 
>>> What is the preferred merge path for this series?
>> 
>> I can take it through my Rust alloc tree, but I think it would probably be
>> better you take it through the mm tree, since I don't expect this to conflict
>> with anything else in my tree anyways.
> 
> No probs.
> 
>> The Rust changes gonna need some more discussion though.
> 
> Great, I'll add a note-to-self that discussion is ongoing.
> 

Awesome, thank you very much! The first patch is unlikely to need a change, the second one will be reworked as discussed with Danilo and the plan is that I post the new version tomorrow or on Friday.

~Vitaly