ASoC: fsl_asrc: use internal measured ratio for non-ideal ratio mode

[PATCH] ASoC: fsl_asrc: use internal measured ratio for non-ideal ratio mode

Posted by Shengjiu Wang 3 months, 2 weeks ago

When USRC=0, there is underrun issue for the non-ideal ratio mode;
according to the reference mannual, the internal measured ratio can be
used with USRC=1 and IDRC=0.

Fixes: d0250cf4f2ab ("ASoC: fsl_asrc: Add an option to select internal ratio mode")
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 sound/soc/fsl/fsl_asrc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
index 677529916dc0..745532ccbdba 100644
--- a/sound/soc/fsl/fsl_asrc.c
+++ b/sound/soc/fsl/fsl_asrc.c
@@ -517,7 +517,8 @@ static int fsl_asrc_config_pair(struct fsl_asrc_pair *pair, bool use_ideal_rate)
 	regmap_update_bits(asrc->regmap, REG_ASRCTR,
 			   ASRCTR_ATSi_MASK(index), ASRCTR_ATS(index));
 	regmap_update_bits(asrc->regmap, REG_ASRCTR,
-			   ASRCTR_USRi_MASK(index), 0);
+			   ASRCTR_IDRi_MASK(index) | ASRCTR_USRi_MASK(index),
+			   ASRCTR_USR(index));
 
 	/* Set the input and output clock sources */
 	regmap_update_bits(asrc->regmap, REG_ASRCSR,
-- 
2.34.1

Re: [PATCH] ASoC: fsl_asrc: use internal measured ratio for non-ideal ratio mode

Posted by Mark Brown 3 months, 1 week ago

On Wed, 25 Jun 2025 10:05:04 +0800, Shengjiu Wang wrote:
> When USRC=0, there is underrun issue for the non-ideal ratio mode;
> according to the reference mannual, the internal measured ratio can be
> used with USRC=1 and IDRC=0.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: fsl_asrc: use internal measured ratio for non-ideal ratio mode
      commit: cbe876121633dadb2b0ce52711985328638e9aab

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH] ASoC: fsl_asrc: use internal measured ratio for non-ideal ratio mode

Posted by Daniel Baluta 3 months, 2 weeks ago

On Wed, Jun 25, 2025 at 5:07 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
>
> When USRC=0, there is underrun issue for the non-ideal ratio mode;
> according to the reference mannual, the internal measured ratio can be
> used with USRC=1 and IDRC=0.
>
> Fixes: d0250cf4f2ab ("ASoC: fsl_asrc: Add an option to select internal ratio mode")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>