[PATCH 17/32] drm/i915/dsi: convert to the .attach_new op

Luca Ceresoli posted 32 patches 3 months, 2 weeks ago
[PATCH 17/32] drm/i915/dsi: convert to the .attach_new op
Posted by Luca Ceresoli 3 months, 2 weeks ago
This op does not pass any pointer to the DSI device, so the DSI host driver
cannot store it.

Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/i915/display/icl_dsi.c | 4 ++--
 drivers/gpu/drm/i915/display/vlv_dsi.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
index aa566ad3f5cd72fb8f9440e2645da0047da222b1..ce5d7b77444d2ac7bc71aecc150d42e2dbb59e0f 100644
--- a/drivers/gpu/drm/i915/display/icl_dsi.c
+++ b/drivers/gpu/drm/i915/display/icl_dsi.c
@@ -1780,7 +1780,7 @@ static const struct drm_connector_helper_funcs gen11_dsi_connector_helper_funcs
 };
 
 static int gen11_dsi_host_attach(struct mipi_dsi_host *host,
-				 struct mipi_dsi_device *dsi)
+				 const struct mipi_dsi_bus_fmt *bus_fmt)
 {
 	return 0;
 }
@@ -1826,7 +1826,7 @@ static ssize_t gen11_dsi_host_transfer(struct mipi_dsi_host *host,
 }
 
 static const struct mipi_dsi_host_ops gen11_dsi_host_ops = {
-	.attach = gen11_dsi_host_attach,
+	.attach_new = gen11_dsi_host_attach,
 	.detach = gen11_dsi_host_detach,
 	.transfer = gen11_dsi_host_transfer,
 };
diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c
index 346737f15fa93264ab8791912cc4cc128f2f3324..5f73919c4bb626f8c293e383479ce393869e47d4 100644
--- a/drivers/gpu/drm/i915/display/vlv_dsi.c
+++ b/drivers/gpu/drm/i915/display/vlv_dsi.c
@@ -199,7 +199,7 @@ static ssize_t intel_dsi_host_transfer(struct mipi_dsi_host *host,
 }
 
 static int intel_dsi_host_attach(struct mipi_dsi_host *host,
-				 struct mipi_dsi_device *dsi)
+				 const struct mipi_dsi_bus_fmt *bus_fmt)
 {
 	return 0;
 }
@@ -211,7 +211,7 @@ static int intel_dsi_host_detach(struct mipi_dsi_host *host,
 }
 
 static const struct mipi_dsi_host_ops intel_dsi_host_ops = {
-	.attach = intel_dsi_host_attach,
+	.attach_new = intel_dsi_host_attach,
 	.detach = intel_dsi_host_detach,
 	.transfer = intel_dsi_host_transfer,
 };

-- 
2.49.0
Re: [PATCH 17/32] drm/i915/dsi: convert to the .attach_new op
Posted by Jani Nikula 3 months, 2 weeks ago
On Wed, 25 Jun 2025, Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
> This op does not pass any pointer to the DSI device, so the DSI host driver
> cannot store it.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Acked-by: Jani Nikula <jani.nikula@intel.com>

for merging via whichever tree you find suitable.

> ---
>  drivers/gpu/drm/i915/display/icl_dsi.c | 4 ++--
>  drivers/gpu/drm/i915/display/vlv_dsi.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index aa566ad3f5cd72fb8f9440e2645da0047da222b1..ce5d7b77444d2ac7bc71aecc150d42e2dbb59e0f 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -1780,7 +1780,7 @@ static const struct drm_connector_helper_funcs gen11_dsi_connector_helper_funcs
>  };
>  
>  static int gen11_dsi_host_attach(struct mipi_dsi_host *host,
> -				 struct mipi_dsi_device *dsi)
> +				 const struct mipi_dsi_bus_fmt *bus_fmt)
>  {
>  	return 0;
>  }
> @@ -1826,7 +1826,7 @@ static ssize_t gen11_dsi_host_transfer(struct mipi_dsi_host *host,
>  }
>  
>  static const struct mipi_dsi_host_ops gen11_dsi_host_ops = {
> -	.attach = gen11_dsi_host_attach,
> +	.attach_new = gen11_dsi_host_attach,
>  	.detach = gen11_dsi_host_detach,
>  	.transfer = gen11_dsi_host_transfer,
>  };
> diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c
> index 346737f15fa93264ab8791912cc4cc128f2f3324..5f73919c4bb626f8c293e383479ce393869e47d4 100644
> --- a/drivers/gpu/drm/i915/display/vlv_dsi.c
> +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c
> @@ -199,7 +199,7 @@ static ssize_t intel_dsi_host_transfer(struct mipi_dsi_host *host,
>  }
>  
>  static int intel_dsi_host_attach(struct mipi_dsi_host *host,
> -				 struct mipi_dsi_device *dsi)
> +				 const struct mipi_dsi_bus_fmt *bus_fmt)
>  {
>  	return 0;
>  }
> @@ -211,7 +211,7 @@ static int intel_dsi_host_detach(struct mipi_dsi_host *host,
>  }
>  
>  static const struct mipi_dsi_host_ops intel_dsi_host_ops = {
> -	.attach = intel_dsi_host_attach,
> +	.attach_new = intel_dsi_host_attach,
>  	.detach = intel_dsi_host_detach,
>  	.transfer = intel_dsi_host_transfer,
>  };

-- 
Jani Nikula, Intel