[PATCH 2/2] PCI: brcmstb: Replace open coded value with PCIE_T_RRS_READY_MS

Florian Fainelli posted 2 patches 3 months, 2 weeks ago
[PATCH 2/2] PCI: brcmstb: Replace open coded value with PCIE_T_RRS_READY_MS
Posted by Florian Fainelli 3 months, 2 weeks ago
The delay that we are waiting on in brcm_pcie_start_link() is
PCIE_T_RRS_READY_MS, use it.

Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
 drivers/pci/controller/pcie-brcmstb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
index 92887b394eb4..7fa2087e85db 100644
--- a/drivers/pci/controller/pcie-brcmstb.c
+++ b/drivers/pci/controller/pcie-brcmstb.c
@@ -1337,7 +1337,7 @@ static int brcm_pcie_start_link(struct brcm_pcie *pcie)
 	 * Wait for 100ms after PERST# deassertion; see PCIe CEM specification
 	 * sections 2.2, PCIe r5.0, 6.6.1.
 	 */
-	msleep(100);
+	msleep(PCIE_T_RRS_READY_MS);
 
 	/*
 	 * Give the RC/EP even more time to wake up, before trying to
-- 
2.43.0
Re: [PATCH 2/2] PCI: brcmstb: Replace open coded value with PCIE_T_RRS_READY_MS
Posted by Manivannan Sadhasivam 2 months, 3 weeks ago
On Tue, Jun 24, 2025 at 04:19:23PM GMT, Florian Fainelli wrote:
> The delay that we are waiting on in brcm_pcie_start_link() is
> PCIE_T_RRS_READY_MS, use it.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
>  drivers/pci/controller/pcie-brcmstb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
> index 92887b394eb4..7fa2087e85db 100644
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -1337,7 +1337,7 @@ static int brcm_pcie_start_link(struct brcm_pcie *pcie)
>  	 * Wait for 100ms after PERST# deassertion; see PCIe CEM specification
>  	 * sections 2.2, PCIe r5.0, 6.6.1.
>  	 */

We don't need this comment also since it is part of RRS definition. I'll remove
it while applying.

- Mani

> -	msleep(100);
> +	msleep(PCIE_T_RRS_READY_MS);
>  
>  	/*
>  	 * Give the RC/EP even more time to wake up, before trying to
> -- 
> 2.43.0
> 

-- 
மணிவண்ணன் சதாசிவம்