The check for c < 0 is always false because variable c is a size_t which
is not a signed type. Fix this by making c a ssize_t.

Fixes: 90711f7bdf76 ("ACPI: APEI: EINJ: Create debugfs files to enter device id and syndrome")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/acpi/apei/einj-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/apei/einj-core.c b/drivers/acpi/apei/einj-core.c
index d6d7e36e3647..7930acd1d3f3 100644
--- a/drivers/acpi/apei/einj-core.c
+++ b/drivers/acpi/apei/einj-core.c
@@ -909,7 +909,7 @@ static ssize_t u128_write(struct file *f, const char __user *buf, size_t count,
 	u8 tmp[COMPONENT_LEN];
 	char byte[3] = {};
 	char *s, *e;
-	size_t c;
+	ssize_t c;
 	long val;
 	int i;
 
-- 
2.50.0

Colin Ian King wrote:
> The check for c < 0 is always false because variable c is a size_t which
> is not a signed type. Fix this by making c a ssize_t.
> 
> Fixes: 90711f7bdf76 ("ACPI: APEI: EINJ: Create debugfs files to enter device id and syndrome")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

[snip]

On Tue, Jun 24, 2025 at 11:09 PM Ira Weiny <ira.weiny@intel.com> wrote:
>
> Colin Ian King wrote:
> > The check for c < 0 is always false because variable c is a size_t which
> > is not a signed type. Fix this by making c a ssize_t.
> >
> > Fixes: 90711f7bdf76 ("ACPI: APEI: EINJ: Create debugfs files to enter device id and syndrome")
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>

Applied, thanks!