kconfig: improve xconfig and gconfig

[PATCH 30/66] kconfig: gconf: remove glade_xml_signal_autoconnect() call

Posted by Masahiro Yamada 3 months, 2 weeks ago

Now that all signals are connected manually, this is no longer
unnecessary.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 scripts/kconfig/gconf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
index 02bbb7ce4c4a..09537245213a 100644
--- a/scripts/kconfig/gconf.c
+++ b/scripts/kconfig/gconf.c
@@ -1120,7 +1120,6 @@ static void init_main_window(const gchar *glade_file)
 	xml = glade_xml_new(glade_file, "window1", NULL);
 	if (!xml)
 		g_error("GUI loading failed !\n");
-	glade_xml_signal_autoconnect(xml);
 
 	main_wnd = glade_xml_get_widget(xml, "window1");
 	g_signal_connect(main_wnd, "destroy",
-- 
2.43.0

Re: [PATCH 30/66] kconfig: gconf: remove glade_xml_signal_autoconnect() call

Posted by Randy Dunlap 3 months, 1 week ago


On 6/24/25 8:05 AM, Masahiro Yamada wrote:
> Now that all signals are connected manually, this is no longer
> unnecessary.

Double negative. Or is that what you meant?

is no longer necessary.
is now unnecessary.

> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  scripts/kconfig/gconf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> index 02bbb7ce4c4a..09537245213a 100644
> --- a/scripts/kconfig/gconf.c
> +++ b/scripts/kconfig/gconf.c
> @@ -1120,7 +1120,6 @@ static void init_main_window(const gchar *glade_file)
>  	xml = glade_xml_new(glade_file, "window1", NULL);
>  	if (!xml)
>  		g_error("GUI loading failed !\n");
> -	glade_xml_signal_autoconnect(xml);
>  
>  	main_wnd = glade_xml_get_widget(xml, "window1");
>  	g_signal_connect(main_wnd, "destroy",

-- 
~Randy

Re: [PATCH 30/66] kconfig: gconf: remove glade_xml_signal_autoconnect() call

Posted by Masahiro Yamada 3 months, 1 week ago

On Mon, Jun 30, 2025 at 11:58 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
>
>
> On 6/24/25 8:05 AM, Masahiro Yamada wrote:
> > Now that all signals are connected manually, this is no longer
> > unnecessary.
>
> Double negative. Or is that what you meant?
>
> is no longer necessary.
> is now unnecessary.


is no longer necessary.

I will fix it. Thanks.






> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> >  scripts/kconfig/gconf.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> > index 02bbb7ce4c4a..09537245213a 100644
> > --- a/scripts/kconfig/gconf.c
> > +++ b/scripts/kconfig/gconf.c
> > @@ -1120,7 +1120,6 @@ static void init_main_window(const gchar *glade_file)
> >       xml = glade_xml_new(glade_file, "window1", NULL);
> >       if (!xml)
> >               g_error("GUI loading failed !\n");
> > -     glade_xml_signal_autoconnect(xml);
> >
> >       main_wnd = glade_xml_get_widget(xml, "window1");
> >       g_signal_connect(main_wnd, "destroy",
>
> --
> ~Randy
>
>


-- 
Best Regards
Masahiro Yamada