kconfig: improve xconfig and gconfig

[PATCH 11/66] kconfig: gconf: remove meaningless code in init_main_window()

Posted by Masahiro Yamada 3 months, 2 weeks ago

The 'widget' variable is set, but not used in later code.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 scripts/kconfig/gconf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
index 7960c456e3b9..4b5befa4f685 100644
--- a/scripts/kconfig/gconf.c
+++ b/scripts/kconfig/gconf.c
@@ -129,7 +129,6 @@ static void init_main_window(const gchar *glade_file)
 	conf_set_changed_callback(conf_changed);
 
 	style = gtk_widget_get_style(main_wnd);
-	widget = glade_xml_get_widget(xml, "toolbar1");
 
 	replace_button_icon(xml, main_wnd->window, style,
 			    "button4", (gchar **) xpm_single_view);
-- 
2.43.0

Re: [PATCH 11/66] kconfig: gconf: remove meaningless code in init_main_window()

Posted by Randy Dunlap 3 months, 1 week ago


On 6/24/25 8:04 AM, Masahiro Yamada wrote:
> The 'widget' variable is set, but not used in later code.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
> 
>  scripts/kconfig/gconf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> index 7960c456e3b9..4b5befa4f685 100644
> --- a/scripts/kconfig/gconf.c
> +++ b/scripts/kconfig/gconf.c
> @@ -129,7 +129,6 @@ static void init_main_window(const gchar *glade_file)
>  	conf_set_changed_callback(conf_changed);
>  
>  	style = gtk_widget_get_style(main_wnd);
> -	widget = glade_xml_get_widget(xml, "toolbar1");
>  
>  	replace_button_icon(xml, main_wnd->window, style,
>  			    "button4", (gchar **) xpm_single_view);

-- 
~Randy