kconfig: improve xconfig and gconfig

[PATCH 10/66] kconfig: gconf: remove empty if-block

Posted by Masahiro Yamada 3 months, 2 weeks ago

This if-block is empty.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 scripts/kconfig/gconf.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
index b2a0208b0a5f..7960c456e3b9 100644
--- a/scripts/kconfig/gconf.c
+++ b/scripts/kconfig/gconf.c
@@ -913,8 +913,6 @@ on_treeview2_key_press_event(GtkWidget * widget,
 			gtk_tree_view_expand_row(view, path, FALSE);
 		return TRUE;
 	}
-	if (event->keyval == GDK_KP_Enter) {
-	}
 	if (widget == tree1_w)
 		return FALSE;
 
-- 
2.43.0

Re: [PATCH 10/66] kconfig: gconf: remove empty if-block

Posted by Randy Dunlap 3 months, 1 week ago


On 6/24/25 8:04 AM, Masahiro Yamada wrote:
> This if-block is empty.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
> 
>  scripts/kconfig/gconf.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> index b2a0208b0a5f..7960c456e3b9 100644
> --- a/scripts/kconfig/gconf.c
> +++ b/scripts/kconfig/gconf.c
> @@ -913,8 +913,6 @@ on_treeview2_key_press_event(GtkWidget * widget,
>  			gtk_tree_view_expand_row(view, path, FALSE);
>  		return TRUE;
>  	}
> -	if (event->keyval == GDK_KP_Enter) {
> -	}
>  	if (widget == tree1_w)
>  		return FALSE;
>  

-- 
~Randy