[PATCH net-next 3/7] tcp: Drop tcp_splice_state::flags

Michal Luczaj posted 7 patches 3 months, 2 weeks ago
There is a newer version of this series
[PATCH net-next 3/7] tcp: Drop tcp_splice_state::flags
Posted by Michal Luczaj 3 months, 2 weeks ago
Since skb_splice_bits() does not accept @flags anymore, struct's field
became unused. Remove it.

No functional change indented.

Signed-off-by: Michal Luczaj <mhal@rbox.co>
---
 net/ipv4/tcp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 46997793d87ab40dcd1e1dd041e4641e287e1b7e..b6285fb1369d32541b9f7d660ca33389b7e4da61 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -324,7 +324,6 @@ EXPORT_IPV6_MOD(tcp_sockets_allocated);
 struct tcp_splice_state {
 	struct pipe_inode_info *pipe;
 	size_t len;
-	unsigned int flags;
 };
 
 /*
@@ -803,7 +802,6 @@ ssize_t tcp_splice_read(struct socket *sock, loff_t *ppos,
 	struct tcp_splice_state tss = {
 		.pipe = pipe,
 		.len = len,
-		.flags = flags,
 	};
 	long timeo;
 	ssize_t spliced;

-- 
2.49.0
Re: [PATCH net-next 3/7] tcp: Drop tcp_splice_state::flags
Posted by Simon Horman 3 months, 2 weeks ago
On Tue, Jun 24, 2025 at 11:53:50AM +0200, Michal Luczaj wrote:
> Since skb_splice_bits() does not accept @flags anymore, struct's field
> became unused. Remove it.
> 
> No functional change indented.
> 
> Signed-off-by: Michal Luczaj <mhal@rbox.co>

Reviewed-by: Simon Horman <horms@kernel.org>