[v1] arm64: dts: qcom: ipq5424: Add reserved memory for TF-A

[PATCH] arm64: dts: qcom: ipq5424: Add reserved memory for TF-A

Posted by Kathiravan Thirumoorthy 3 months, 2 weeks ago

From: Vignesh Viswanathan <quic_viswanat@quicinc.com>

IPQ5424 supports both TZ and TF-A as secure software options and various
DDR sizes. In most cases, TF-A or TZ is loaded at the same memory
location, but in the 256MB DDR configuration TF-A is loaded at a different
region.

So, add the reserved memory node for TF-A and keep it disabled by default.
During bootup, U-Boot will detect which secure software is running and
enable or disable the node accordingly.

Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/ipq5424.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
index 66bd2261eb25d79051adddef604c55f5b01e6e8b..d7264f7e2423510ca1f33bd208becc33bf231094 100644
--- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
@@ -150,6 +150,12 @@ smem@8a800000 {
 
 			hwlocks = <&tcsr_mutex 3>;
 		};
+
+		tfa@8a832000 {
+			reg = <0x0 0x8a832000 0x0 0x7d000>;
+			no-map;
+			status = "disabled";
+		};
 	};
 
 	soc@0 {

---
base-commit: f817b6dd2b62d921a6cdc0a3ac599cd1851f343c
change-id: 20250624-atf-reserved-mem-b84c7d45b624

Best regards,
-- 
Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

Re: [PATCH] arm64: dts: qcom: ipq5424: Add reserved memory for TF-A

Posted by Konrad Dybcio 3 months, 2 weeks ago

On 6/24/25 12:36 PM, Kathiravan Thirumoorthy wrote:
> From: Vignesh Viswanathan <quic_viswanat@quicinc.com>
> 
> IPQ5424 supports both TZ and TF-A as secure software options and various
> DDR sizes. In most cases, TF-A or TZ is loaded at the same memory
> location, but in the 256MB DDR configuration TF-A is loaded at a different
> region.
> 
> So, add the reserved memory node for TF-A and keep it disabled by default.
> During bootup, U-Boot will detect which secure software is running and
> enable or disable the node accordingly.
> 
> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---

Can the said u-boot simply dynamically add the reservation then?

Konrad

Re: [PATCH] arm64: dts: qcom: ipq5424: Add reserved memory for TF-A

Posted by Kathiravan Thirumoorthy 3 months, 2 weeks ago

On 6/24/2025 6:57 PM, Konrad Dybcio wrote:
> On 6/24/25 12:36 PM, Kathiravan Thirumoorthy wrote:
>> From: Vignesh Viswanathan <quic_viswanat@quicinc.com>
>>
>> IPQ5424 supports both TZ and TF-A as secure software options and various
>> DDR sizes. In most cases, TF-A or TZ is loaded at the same memory
>> location, but in the 256MB DDR configuration TF-A is loaded at a different
>> region.
>>
>> So, add the reserved memory node for TF-A and keep it disabled by default.
>> During bootup, U-Boot will detect which secure software is running and
>> enable or disable the node accordingly.
>>
>> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>> ---
> Can the said u-boot simply dynamically add the reservation then?

Yeah it could have been done in U-Boot itself but it wasn't. 256MB DDR 
configuration solution is already shipped out and the stock U-Boot 
enable this node to avoid the random issues.

>
> Konrad

Re: [PATCH] arm64: dts: qcom: ipq5424: Add reserved memory for TF-A

Posted by Kathiravan Thirumoorthy 2 months, 2 weeks ago

On 6/25/2025 10:20 AM, Kathiravan Thirumoorthy wrote:
>
> On 6/24/2025 6:57 PM, Konrad Dybcio wrote:
>> On 6/24/25 12:36 PM, Kathiravan Thirumoorthy wrote:
>>> From: Vignesh Viswanathan <quic_viswanat@quicinc.com>
>>>
>>> IPQ5424 supports both TZ and TF-A as secure software options and 
>>> various
>>> DDR sizes. In most cases, TF-A or TZ is loaded at the same memory
>>> location, but in the 256MB DDR configuration TF-A is loaded at a 
>>> different
>>> region.
>>>
>>> So, add the reserved memory node for TF-A and keep it disabled by 
>>> default.
>>> During bootup, U-Boot will detect which secure software is running and
>>> enable or disable the node accordingly.
>>>
>>> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
>>> Signed-off-by: Kathiravan Thirumoorthy 
>>> <kathiravan.thirumoorthy@oss.qualcomm.com>
>>> ---
>> Can the said u-boot simply dynamically add the reservation then?
>
> Yeah it could have been done in U-Boot itself but it wasn't. 256MB DDR 
> configuration solution is already shipped out and the stock U-Boot 
> enable this node to avoid the random issues.


Konrad, Do you have any further comments on this?


>
>>
>> Konrad

Re: [PATCH] arm64: dts: qcom: ipq5424: Add reserved memory for TF-A

Posted by Konrad Dybcio 2 months ago

On 7/23/25 9:04 AM, Kathiravan Thirumoorthy wrote:
> 
> On 6/25/2025 10:20 AM, Kathiravan Thirumoorthy wrote:
>>
>> On 6/24/2025 6:57 PM, Konrad Dybcio wrote:
>>> On 6/24/25 12:36 PM, Kathiravan Thirumoorthy wrote:
>>>> From: Vignesh Viswanathan <quic_viswanat@quicinc.com>
>>>>
>>>> IPQ5424 supports both TZ and TF-A as secure software options and various
>>>> DDR sizes. In most cases, TF-A or TZ is loaded at the same memory
>>>> location, but in the 256MB DDR configuration TF-A is loaded at a different
>>>> region.
>>>>
>>>> So, add the reserved memory node for TF-A and keep it disabled by default.
>>>> During bootup, U-Boot will detect which secure software is running and
>>>> enable or disable the node accordingly.
>>>>
>>>> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
>>>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>>>> ---
>>> Can the said u-boot simply dynamically add the reservation then?
>>
>> Yeah it could have been done in U-Boot itself but it wasn't. 256MB DDR configuration solution is already shipped out and the stock U-Boot enable this node to avoid the random issues.
> 
> 
> Konrad, Do you have any further comments on this?

I really don't like it, but fine, I won't be blocking this either..

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Please make sure that the next time around the bootloader reserves
its own memory and doesn't depend on what the OS decides to do

Konrad

Re: [PATCH] arm64: dts: qcom: ipq5424: Add reserved memory for TF-A

Posted by Kathiravan Thirumoorthy 2 months ago

On 8/5/2025 6:52 PM, Konrad Dybcio wrote:
> On 7/23/25 9:04 AM, Kathiravan Thirumoorthy wrote:
>> On 6/25/2025 10:20 AM, Kathiravan Thirumoorthy wrote:
>>> On 6/24/2025 6:57 PM, Konrad Dybcio wrote:
>>>> On 6/24/25 12:36 PM, Kathiravan Thirumoorthy wrote:
>>>>> From: Vignesh Viswanathan <quic_viswanat@quicinc.com>
>>>>>
>>>>> IPQ5424 supports both TZ and TF-A as secure software options and various
>>>>> DDR sizes. In most cases, TF-A or TZ is loaded at the same memory
>>>>> location, but in the 256MB DDR configuration TF-A is loaded at a different
>>>>> region.
>>>>>
>>>>> So, add the reserved memory node for TF-A and keep it disabled by default.
>>>>> During bootup, U-Boot will detect which secure software is running and
>>>>> enable or disable the node accordingly.
>>>>>
>>>>> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>
>>>>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>>>>> ---
>>>> Can the said u-boot simply dynamically add the reservation then?
>>> Yeah it could have been done in U-Boot itself but it wasn't. 256MB DDR configuration solution is already shipped out and the stock U-Boot enable this node to avoid the random issues.
>>
>> Konrad, Do you have any further comments on this?
> I really don't like it, but fine, I won't be blocking this either..
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Please make sure that the next time around the bootloader reserves
> its own memory and doesn't depend on what the OS decides to do


Thanks Konrad, yeah we have a plan to mitigate this one for the upcoming 
projects.


>
> Konrad