drm/vmwgfx: fix missing assignment to ts

[PATCH][next] drm/vmwgfx: fix missing assignment to ts

Posted by Colin Ian King 3 months, 2 weeks ago

The assignment to ts is missing on the call to ktime_to_timespec64.
Fix this by adding the missing assignment.

Fixes: db6a94b26354 ("drm/vmwgfx: Implement dma_fence_ops properly")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
index c2294abbe753..00be92da5509 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
@@ -538,7 +538,7 @@ static void vmw_event_fence_action_seq_passed(struct dma_fence *f,
 	if (likely(eaction->tv_sec != NULL)) {
 		struct timespec64 ts;
 
-		ktime_to_timespec64(f->timestamp);
+		ts = ktime_to_timespec64(f->timestamp);
 		/* monotonic time, so no y2038 overflow */
 		*eaction->tv_sec = ts.tv_sec;
 		*eaction->tv_usec = ts.tv_nsec / NSEC_PER_USEC;
-- 
2.50.0

Re: [PATCH][next] drm/vmwgfx: fix missing assignment to ts

Posted by Ian Forbes 3 months, 2 weeks ago

On Mon, Jun 23, 2025 at 5:35 PM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> The assignment to ts is missing on the call to ktime_to_timespec64.
> Fix this by adding the missing assignment.
>
> Fixes: db6a94b26354 ("drm/vmwgfx: Implement dma_fence_ops properly")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Was this caught by a compiler warning? I'm surprised I didn't get some
sort of warning for this.

Reviewed-by: Ian Forbes <ian.forbes@broadcom.com>

Re: [PATCH][next] drm/vmwgfx: fix missing assignment to ts

Posted by Dan Carpenter 3 months, 2 weeks ago

On Tue, Jun 24, 2025 at 10:02:41AM -0500, Ian Forbes wrote:
> On Mon, Jun 23, 2025 at 5:35 PM Colin Ian King <colin.i.king@gmail.com> wrote:
> >
> > The assignment to ts is missing on the call to ktime_to_timespec64.
> > Fix this by adding the missing assignment.
> >
> > Fixes: db6a94b26354 ("drm/vmwgfx: Implement dma_fence_ops properly")
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> 
> Was this caught by a compiler warning? I'm surprised I didn't get some
> sort of warning for this.
> 

We've disabled uninitialized variable warnings in GCC.  Perhaps
Clang would have caught this but I'm not sure because tracking
uninitialized struct members is a bit more complicated than tracking
uninitialized variables.

regards,
dan carpenter