1. Patchew
  2. linux
  3. View series

[PATCH] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56

GalaxySnail posted 1 patch 7 months, 2 weeks ago
There is a newer version of this series
sound/pci/hda/cs35l41_hda.c | 2 ++
sound/pci/hda/cs35l56_hda.c | 4 ++++
2 files changed, 6 insertions(+)
[PATCH] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56
Posted by GalaxySnail 7 months, 2 weeks ago 
add firmware information in the .modinfo section, so that userspace
tools can find out firmware required by cs35l41/cs32l56 kernel module

Signed-off-by: GalaxySnail <me@glxys.nl>
---
 sound/pci/hda/cs35l41_hda.c | 2 ++
 sound/pci/hda/cs35l56_hda.c | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
index d5bc81099d0d..90e994b79481 100644
--- a/sound/pci/hda/cs35l41_hda.c
+++ b/sound/pci/hda/cs35l41_hda.c
@@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
 MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@opensource.cirrus.com>");
 MODULE_LICENSE("GPL");
 MODULE_IMPORT_NS("FW_CS_DSP");
+MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw")
+MODULE_FIRMWARE("cirrus/cs35l41-*.bin")
diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
index 3f2fd32f4ad9..c393fc0c7339 100644
--- a/sound/pci/hda/cs35l56_hda.c
+++ b/sound/pci/hda/cs35l56_hda.c
@@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
 MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>");
 MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>");
 MODULE_LICENSE("GPL");
+MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw")
+MODULE_FIRMWARE("cirrus/cs35l54-*.bin")
+MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw")
+MODULE_FIRMWARE("cirrus/cs35l56-*.bin")
-- 
2.50.0
Re: [PATCH] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56
Posted by kernel test robot 7 months, 2 weeks ago 
Hi GalaxySnail,

kernel test robot noticed the following build errors:

[auto build test ERROR on tiwai-sound/for-next]
[also build test ERROR on tiwai-sound/for-linus linus/master v6.16-rc3 next-20250623]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/GalaxySnail/ALSA-hda-add-MODULE_FIRMWARE-for-cs35l41-cs35l56/20250623-220657
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link:    https://lore.kernel.org/r/20250623140030.1539477-2-me%40glxys.nl
patch subject: [PATCH] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20250624/202506241158.kxrazQoo-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250624/202506241158.kxrazQoo-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506241158.kxrazQoo-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/module.h:22,
                    from include/linux/device/driver.h:21,
                    from include/linux/device.h:32,
                    from include/linux/acpi.h:14,
                    from sound/pci/hda/cs35l41_hda.c:9:
>> include/linux/moduleparam.h:24:9: error: expected ',' or ';' before 'static'
      24 |         static const char __UNIQUE_ID(name)[]                             \
         |         ^~~~~~
   include/linux/module.h:168:32: note: in expansion of macro '__MODULE_INFO'
     168 | #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
         |                                ^~~~~~~~~~~~~
   include/linux/module.h:299:36: note: in expansion of macro 'MODULE_INFO'
     299 | #define MODULE_FIRMWARE(_firmware) MODULE_INFO(firmware, _firmware)
         |                                    ^~~~~~~~~~~
   sound/pci/hda/cs35l41_hda.c:2116:1: note: in expansion of macro 'MODULE_FIRMWARE'
    2116 | MODULE_FIRMWARE("cirrus/cs35l41-*.bin")
         | ^~~~~~~~~~~~~~~
--
   In file included from include/linux/module.h:22,
                    from include/linux/device/driver.h:21,
                    from include/linux/device.h:32,
                    from include/linux/acpi.h:14,
                    from sound/pci/hda/cs35l56_hda.c:9:
>> include/linux/moduleparam.h:24:9: error: expected ',' or ';' before 'static'
      24 |         static const char __UNIQUE_ID(name)[]                             \
         |         ^~~~~~
   include/linux/module.h:168:32: note: in expansion of macro '__MODULE_INFO'
     168 | #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
         |                                ^~~~~~~~~~~~~
   include/linux/module.h:299:36: note: in expansion of macro 'MODULE_INFO'
     299 | #define MODULE_FIRMWARE(_firmware) MODULE_INFO(firmware, _firmware)
         |                                    ^~~~~~~~~~~
   sound/pci/hda/cs35l56_hda.c:1126:1: note: in expansion of macro 'MODULE_FIRMWARE'
    1126 | MODULE_FIRMWARE("cirrus/cs35l54-*.bin")
         | ^~~~~~~~~~~~~~~
--
   In file included from include/linux/module.h:22,
                    from include/linux/device/driver.h:21,
                    from include/linux/device.h:32,
                    from include/linux/acpi.h:14,
                    from cs35l41_hda.c:9:
>> include/linux/moduleparam.h:24:9: error: expected ',' or ';' before 'static'
      24 |         static const char __UNIQUE_ID(name)[]                             \
         |         ^~~~~~
   include/linux/module.h:168:32: note: in expansion of macro '__MODULE_INFO'
     168 | #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
         |                                ^~~~~~~~~~~~~
   include/linux/module.h:299:36: note: in expansion of macro 'MODULE_INFO'
     299 | #define MODULE_FIRMWARE(_firmware) MODULE_INFO(firmware, _firmware)
         |                                    ^~~~~~~~~~~
   cs35l41_hda.c:2116:1: note: in expansion of macro 'MODULE_FIRMWARE'
    2116 | MODULE_FIRMWARE("cirrus/cs35l41-*.bin")
         | ^~~~~~~~~~~~~~~
--
   In file included from include/linux/module.h:22,
                    from include/linux/device/driver.h:21,
                    from include/linux/device.h:32,
                    from include/linux/acpi.h:14,
                    from cs35l56_hda.c:9:
>> include/linux/moduleparam.h:24:9: error: expected ',' or ';' before 'static'
      24 |         static const char __UNIQUE_ID(name)[]                             \
         |         ^~~~~~
   include/linux/module.h:168:32: note: in expansion of macro '__MODULE_INFO'
     168 | #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
         |                                ^~~~~~~~~~~~~
   include/linux/module.h:299:36: note: in expansion of macro 'MODULE_INFO'
     299 | #define MODULE_FIRMWARE(_firmware) MODULE_INFO(firmware, _firmware)
         |                                    ^~~~~~~~~~~
   cs35l56_hda.c:1126:1: note: in expansion of macro 'MODULE_FIRMWARE'
    1126 | MODULE_FIRMWARE("cirrus/cs35l54-*.bin")
         | ^~~~~~~~~~~~~~~


vim +24 include/linux/moduleparam.h

730b69d2252595 Rusty Russell  2008-10-22  22  
^1da177e4c3f41 Linus Torvalds 2005-04-16  23  #define __MODULE_INFO(tag, name, info)					  \
34182eea36fc1d Rusty Russell  2012-11-22 @24  	static const char __UNIQUE_ID(name)[]				  \
2aec389e19150e Johan Hovold   2020-11-23  25  		__used __section(".modinfo") __aligned(1)		  \
898490c010b5d2 Alexey Gladkov 2019-04-29  26  		= __MODULE_INFO_PREFIX __stringify(tag) "=" info
898490c010b5d2 Alexey Gladkov 2019-04-29  27  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
[PATCH v2] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56
Posted by GalaxySnail 7 months, 2 weeks ago 
add firmware information in the .modinfo section, so that userspace
tools can find out firmware required by cs35l41/cs32l56 kernel module

Signed-off-by: GalaxySnail <me@glxys.nl>
---
v1 -> v2: fixed missing ';' in the previous patch

 sound/pci/hda/cs35l41_hda.c | 2 ++
 sound/pci/hda/cs35l56_hda.c | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
index d5bc81099d0d..f71f6aca0601 100644
--- a/sound/pci/hda/cs35l41_hda.c
+++ b/sound/pci/hda/cs35l41_hda.c
@@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
 MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@opensource.cirrus.com>");
 MODULE_LICENSE("GPL");
 MODULE_IMPORT_NS("FW_CS_DSP");
+MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw");
+MODULE_FIRMWARE("cirrus/cs36l41-*.bin");
diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
index 3f2fd32f4ad9..eedd8fdd3b8b 100644
--- a/sound/pci/hda/cs35l56_hda.c
+++ b/sound/pci/hda/cs35l56_hda.c
@@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
 MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>");
 MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>");
 MODULE_LICENSE("GPL");
+MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw");
+MODULE_FIRMWARE("cirrus/cs35l54-*.bin");
+MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw");
+MODULE_FIRMWARE("cirrus/cs35l56-*.bin");
-- 
2.50.0
RE: [PATCH v2] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56
Posted by Simon Trimmer 7 months, 2 weeks ago 
On Tue, Jun 24, 2025 at 05:31:21AM +0100, GalaxySnail wrote:
> add firmware information in the .modinfo section, so that userspace
> tools can find out firmware required by cs35l41/cs32l56 kernel module

Typo in part number cs32l56 -> cs35l56

> 
> Signed-off-by: GalaxySnail <me@glxys.nl>
> ---
> v1 -> v2: fixed missing ';' in the previous patch
> 
>  sound/pci/hda/cs35l41_hda.c | 2 ++
>  sound/pci/hda/cs35l56_hda.c | 4 ++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
> index d5bc81099d0d..f71f6aca0601 100644
> --- a/sound/pci/hda/cs35l41_hda.c
> +++ b/sound/pci/hda/cs35l41_hda.c
> @@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
>  MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc,
> <tanureal@opensource.cirrus.com>");
>  MODULE_LICENSE("GPL");
>  MODULE_IMPORT_NS("FW_CS_DSP");
> +MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs36l41-*.bin");

Typo in part number cs36l41 -> cs35l41

> diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
> index 3f2fd32f4ad9..eedd8fdd3b8b 100644
> --- a/sound/pci/hda/cs35l56_hda.c
> +++ b/sound/pci/hda/cs35l56_hda.c
> @@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
>  MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>");
>  MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>");
>  MODULE_LICENSE("GPL");
> +MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l54-*.bin");
> +MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l56-*.bin");
> --
> 2.50.0
[PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56
Posted by GalaxySnail 7 months, 2 weeks ago 
add firmware information in the .modinfo section, so that userspace
tools can find out firmware required by cs35l41/cs35l56 kernel module

Signed-off-by: GalaxySnail <me@glxys.nl>
---
Thanks for your review!

v2 -> v3: fixed typo
v1 -> v2: fixed missing ';' in the previous patch

 sound/pci/hda/cs35l41_hda.c | 2 ++
 sound/pci/hda/cs35l56_hda.c | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
index d5bc81099d0d..17cdce91fdbf 100644
--- a/sound/pci/hda/cs35l41_hda.c
+++ b/sound/pci/hda/cs35l41_hda.c
@@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
 MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@opensource.cirrus.com>");
 MODULE_LICENSE("GPL");
 MODULE_IMPORT_NS("FW_CS_DSP");
+MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw");
+MODULE_FIRMWARE("cirrus/cs35l41-*.bin");
diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
index 3f2fd32f4ad9..eedd8fdd3b8b 100644
--- a/sound/pci/hda/cs35l56_hda.c
+++ b/sound/pci/hda/cs35l56_hda.c
@@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
 MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>");
 MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>");
 MODULE_LICENSE("GPL");
+MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw");
+MODULE_FIRMWARE("cirrus/cs35l54-*.bin");
+MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw");
+MODULE_FIRMWARE("cirrus/cs35l56-*.bin");
-- 
2.50.0
Re: [PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56
Posted by Takashi Iwai 7 months ago 
On Tue, 24 Jun 2025 12:17:17 +0200,
GalaxySnail wrote:
> 
> add firmware information in the .modinfo section, so that userspace
> tools can find out firmware required by cs35l41/cs35l56 kernel module
> 
> Signed-off-by: GalaxySnail <me@glxys.nl>
> ---
> Thanks for your review!
> 
> v2 -> v3: fixed typo
> v1 -> v2: fixed missing ';' in the previous patch

Applied now to for-next branch.  Thanks.


Takashi
Re: [PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56
Posted by Richard Fitzgerald 7 months, 1 week ago 
On 24/06/2025 11:17 am, GalaxySnail wrote:
> add firmware information in the .modinfo section, so that userspace
> tools can find out firmware required by cs35l41/cs35l56 kernel module
> 
> Signed-off-by: GalaxySnail <me@glxys.nl>
> ---
> Thanks for your review!
> 
> v2 -> v3: fixed typo
> v1 -> v2: fixed missing ';' in the previous patch
> 
>   sound/pci/hda/cs35l41_hda.c | 2 ++
>   sound/pci/hda/cs35l56_hda.c | 4 ++++
>   2 files changed, 6 insertions(+)
> 
> diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
> index d5bc81099d0d..17cdce91fdbf 100644
> --- a/sound/pci/hda/cs35l41_hda.c
> +++ b/sound/pci/hda/cs35l41_hda.c
> @@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
>   MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@opensource.cirrus.com>");
>   MODULE_LICENSE("GPL");
>   MODULE_IMPORT_NS("FW_CS_DSP");
> +MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l41-*.bin");
> diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
> index 3f2fd32f4ad9..eedd8fdd3b8b 100644
> --- a/sound/pci/hda/cs35l56_hda.c
> +++ b/sound/pci/hda/cs35l56_hda.c
> @@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
>   MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>");
>   MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>");
>   MODULE_LICENSE("GPL");
> +MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l54-*.bin");
> +MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l56-*.bin");

Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Re: [PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56
Posted by Takashi Iwai 7 months, 1 week ago 
On Tue, 24 Jun 2025 12:17:17 +0200,
GalaxySnail wrote:
> 
> add firmware information in the .modinfo section, so that userspace
> tools can find out firmware required by cs35l41/cs35l56 kernel module
> 
> Signed-off-by: GalaxySnail <me@glxys.nl>
> ---
> Thanks for your review!
> 
> v2 -> v3: fixed typo
> v1 -> v2: fixed missing ';' in the previous patch

Cirrus people, can you review this before I merge?


thanks,

Takashi

> 
>  sound/pci/hda/cs35l41_hda.c | 2 ++
>  sound/pci/hda/cs35l56_hda.c | 4 ++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
> index d5bc81099d0d..17cdce91fdbf 100644
> --- a/sound/pci/hda/cs35l41_hda.c
> +++ b/sound/pci/hda/cs35l41_hda.c
> @@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
>  MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@opensource.cirrus.com>");
>  MODULE_LICENSE("GPL");
>  MODULE_IMPORT_NS("FW_CS_DSP");
> +MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l41-*.bin");
> diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
> index 3f2fd32f4ad9..eedd8fdd3b8b 100644
> --- a/sound/pci/hda/cs35l56_hda.c
> +++ b/sound/pci/hda/cs35l56_hda.c
> @@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
>  MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>");
>  MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>");
>  MODULE_LICENSE("GPL");
> +MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l54-*.bin");
> +MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l56-*.bin");
> -- 
> 2.50.0
>
Re: [PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56
Posted by Takashi Iwai 7 months, 2 weeks ago 
On Tue, 24 Jun 2025 12:17:17 +0200,
GalaxySnail wrote:
> 
> add firmware information in the .modinfo section, so that userspace
> tools can find out firmware required by cs35l41/cs35l56 kernel module
> 
> Signed-off-by: GalaxySnail <me@glxys.nl>

Signed-off-by is a legal requirement, and it must be a known identity,
no anonymity.  Could you resubmit with a proper name?


thanks,

Takashi


> ---
> Thanks for your review!
> 
> v2 -> v3: fixed typo
> v1 -> v2: fixed missing ';' in the previous patch
> 
>  sound/pci/hda/cs35l41_hda.c | 2 ++
>  sound/pci/hda/cs35l56_hda.c | 4 ++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
> index d5bc81099d0d..17cdce91fdbf 100644
> --- a/sound/pci/hda/cs35l41_hda.c
> +++ b/sound/pci/hda/cs35l41_hda.c
> @@ -2085,3 +2085,5 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
>  MODULE_AUTHOR("Lucas Tanure, Cirrus Logic Inc, <tanureal@opensource.cirrus.com>");
>  MODULE_LICENSE("GPL");
>  MODULE_IMPORT_NS("FW_CS_DSP");
> +MODULE_FIRMWARE("cirrus/cs35l41-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l41-*.bin");
> diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
> index 3f2fd32f4ad9..eedd8fdd3b8b 100644
> --- a/sound/pci/hda/cs35l56_hda.c
> +++ b/sound/pci/hda/cs35l56_hda.c
> @@ -1122,3 +1122,7 @@ MODULE_IMPORT_NS("SND_SOC_CS_AMP_LIB");
>  MODULE_AUTHOR("Richard Fitzgerald <rf@opensource.cirrus.com>");
>  MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>");
>  MODULE_LICENSE("GPL");
> +MODULE_FIRMWARE("cirrus/cs35l54-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l54-*.bin");
> +MODULE_FIRMWARE("cirrus/cs35l56-*.wmfw");
> +MODULE_FIRMWARE("cirrus/cs35l56-*.bin");
> -- 
> 2.50.0
> 
>
Re: [PATCH v3] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56
Posted by GalaxySnail 7 months, 2 weeks ago 
On 2025/6/24 18:44, Takashi Iwai wrote:
> On Tue, 24 Jun 2025 12:17:17 +0200,
> GalaxySnail wrote:
>>
>> add firmware information in the .modinfo section, so that userspace
>> tools can find out firmware required by cs35l41/cs35l56 kernel module
>>
>> Signed-off-by: GalaxySnail <me@glxys.nl>
> 
> Signed-off-by is a legal requirement, and it must be a known identity,
> no anonymity.  Could you resubmit with a proper name?

GalaxySnail is not an anonymous identity, it's the consistent name I
use for all my open-source contributions.

Here's my GitHub account: https://github.com/GalaxySnail
and here's my AUR account: https://aur.archlinux.org/account/GalaxySnail

> thanks,
> 
> Takashi

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.