Add a schema for the venus video encoder/decoder on the qcm2290.
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
---
.../bindings/media/qcom,qcm2290-venus.yaml | 117 ++++++++++++++++++
1 file changed, 117 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
new file mode 100644
index 000000000000..1b94a95ce514
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
@@ -0,0 +1,117 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/qcom,qcm2290-venus.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm QCM2290 Venus video encode and decode accelerators
+
+maintainers:
+ - Vikash Garodia <quic_vgarodia@quicinc.com>
+
+description:
+ The Venus AR50_LITE IP is a video encode and decode accelerator present
+ on Qualcomm platforms
+
+allOf:
+ - $ref: qcom,venus-common.yaml#
+
+properties:
+ compatible:
+ const: qcom,qcm2290-venus
+
+ power-domains:
+ maxItems: 3
+
+ power-domain-names:
+ items:
+ - const: venus
+ - const: vcodec0
+ - const: cx
+
+ clocks:
+ maxItems: 6
+
+ clock-names:
+ items:
+ - const: core
+ - const: iface
+ - const: bus
+ - const: throttle
+ - const: vcodec0_core
+ - const: vcodec0_bus
+
+ iommus:
+ minItems: 1
+ maxItems: 5
+
+ interconnects:
+ maxItems: 2
+
+ interconnect-names:
+ items:
+ - const: video-mem
+ - const: cpu-cfg
+
+ operating-points-v2: true
+ opp-table:
+ type: object
+
+required:
+ - compatible
+ - power-domain-names
+ - iommus
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/qcom,gcc-qcm2290.h>
+ #include <dt-bindings/interconnect/qcom,qcm2290.h>
+ #include <dt-bindings/interconnect/qcom,rpm-icc.h>
+ #include <dt-bindings/power/qcom-rpmpd.h>
+
+ venus: video-codec@5a00000 {
+ compatible = "qcom,qcm2290-venus";
+ reg = <0x5a00000 0xff000>;
+ interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
+
+ power-domains = <&gcc GCC_VENUS_GDSC>,
+ <&gcc GCC_VCODEC0_GDSC>,
+ <&rpmpd QCM2290_VDDCX>;
+ power-domain-names = "venus", "vcodec0", "cx";
+ operating-points-v2 = <&venus_opp_table>;
+
+ clocks = <&gcc GCC_VIDEO_VENUS_CTL_CLK>,
+ <&gcc GCC_VIDEO_AHB_CLK>,
+ <&gcc GCC_VENUS_CTL_AXI_CLK>,
+ <&gcc GCC_VIDEO_THROTTLE_CORE_CLK>,
+ <&gcc GCC_VIDEO_VCODEC0_SYS_CLK>,
+ <&gcc GCC_VCODEC0_AXI_CLK>;
+ clock-names = "core", "iface", "bus", "throttle",
+ "vcodec0_core", "vcodec0_bus";
+
+ memory-region = <&pil_video_mem>;
+ iommus = <&apps_smmu 0x860 0x0>,
+ <&apps_smmu 0x880 0x0>,
+ <&apps_smmu 0x861 0x04>,
+ <&apps_smmu 0x863 0x0>,
+ <&apps_smmu 0x804 0xE0>;
+
+ interconnects = <&mmnrt_virt MASTER_VIDEO_P0 0 &bimc SLAVE_EBI1 0>,
+ <&bimc MASTER_APPSS_PROC 0 &config_noc SLAVE_VENUS_CFG 0>;
+ interconnect-names = "video-mem", "cpu-cfg";
+
+ venus_opp_table: opp-table {
+ compatible = "operating-points-v2";
+ opp-133000000 {
+ opp-hz = /bits/ 64 <133000000>;
+ required-opps = <&rpmpd_opp_low_svs>;
+ };
+ opp-240000000 {
+ opp-hz = /bits/ 64 <240000000>;
+ required-opps = <&rpmpd_opp_svs>;
+ };
+ };
+ };
--
2.34.1On 23/06/2025 12:51, Jorge Ramirez-Ortiz wrote: > Add a schema for the venus video encoder/decoder on the qcm2290. > > Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com> > --- Don't send multiple versions per day and allow other to actually perform review of your patchset instead of sending for every little thing. <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. Please read: https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
On 23/06/25 13:49:21, Krzysztof Kozlowski wrote: > On 23/06/2025 12:51, Jorge Ramirez-Ortiz wrote: > > Add a schema for the venus video encoder/decoder on the qcm2290. > > > > Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com> > > --- > Don't send multiple versions per day and allow other to actually perform > review of your patchset instead of sending for every little thing. No. this is not what this was about - I already explained to you the call I chose to make. You can disagree but you should not misrepresent it.
On 23/06/2025 14:24, Jorge Ramirez wrote: > On 23/06/25 13:49:21, Krzysztof Kozlowski wrote: >> On 23/06/2025 12:51, Jorge Ramirez-Ortiz wrote: >>> Add a schema for the venus video encoder/decoder on the qcm2290. >>> >>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com> >>> --- >> Don't send multiple versions per day and allow other to actually perform >> review of your patchset instead of sending for every little thing. > > No. this is not what this was about - I already explained to you the > call I chose to make. You can disagree but you should not misrepresent > it. No, you did not explain me anything. You sent v4 with only one little change: "Changes since v3: - Fixed schema commit subject." The same day, also skipping review. So no, don't do that. One patchset per day. Best regards, Krzysztof
On 24/06/25 08:03:46, Krzysztof Kozlowski wrote: > On 23/06/2025 14:24, Jorge Ramirez wrote: > > On 23/06/25 13:49:21, Krzysztof Kozlowski wrote: > >> On 23/06/2025 12:51, Jorge Ramirez-Ortiz wrote: > >>> Add a schema for the venus video encoder/decoder on the qcm2290. > >>> > >>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com> > >>> --- > >> Don't send multiple versions per day and allow other to actually perform > >> review of your patchset instead of sending for every little thing. > > > > No. this is not what this was about - I already explained to you the > > call I chose to make. You can disagree but you should not misrepresent > > it. > > > No, you did not explain me anything. You sent v4 with only one little > change: > "Changes since v3: > - Fixed schema commit subject." um, I dont want to delve in this (only because the conversation takes longer than actual changes but just to close the loop), I did acknowledge that you had trouble receiving my patches - since they were threaded - and that I would be respining on the same day in case others were having the same issue. > > The same day, also skipping review. yep. will repost later today and thanks for the persistance (dont think I dont value it!).
© 2016 - 2025 Red Hat, Inc.