mei: vsc: Various bug-fixes

[PATCH 07/10] mei: vsc: Unset the event callback on remove and probe errors

Posted by Hans de Goede 3 months, 2 weeks ago

Make mei_vsc_remove() properly unset the callback to avoid a dead callback
sticking around after probe errors or unbinding of the platform driver.

Fixes: 386a766c4169 ("mei: Add MEI hardware support for IVSC device")
Signed-off-by: Hans de Goede <hansg@kernel.org>
---
 drivers/misc/mei/platform-vsc.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/misc/mei/platform-vsc.c b/drivers/misc/mei/platform-vsc.c
index 1ac85f0251c5..b2b5a20ae3fa 100644
--- a/drivers/misc/mei/platform-vsc.c
+++ b/drivers/misc/mei/platform-vsc.c
@@ -380,6 +380,8 @@ static int mei_vsc_probe(struct platform_device *pdev)
 err_cancel:
 	mei_cancel_work(mei_dev);
 
+	vsc_tp_register_event_cb(tp, NULL, NULL);
+
 	mei_disable_interrupts(mei_dev);
 
 	return ret;
@@ -388,11 +390,14 @@ static int mei_vsc_probe(struct platform_device *pdev)
 static void mei_vsc_remove(struct platform_device *pdev)
 {
 	struct mei_device *mei_dev = platform_get_drvdata(pdev);
+	struct mei_vsc_hw *hw = mei_dev_to_vsc_hw(mei_dev);
 
 	pm_runtime_disable(mei_dev->dev);
 
 	mei_stop(mei_dev);
 
+	vsc_tp_register_event_cb(hw->tp, NULL, NULL);
+
 	mei_disable_interrupts(mei_dev);
 
 	mei_deregister(mei_dev);
-- 
2.49.0

RE: [PATCH 07/10] mei: vsc: Unset the event callback on remove and probe errors

Posted by Usyskin, Alexander 3 months, 2 weeks ago

> Subject: [PATCH 07/10] mei: vsc: Unset the event callback on remove and
> probe errors
> 
> Make mei_vsc_remove() properly unset the callback to avoid a dead callback
> sticking around after probe errors or unbinding of the platform driver.
> 

Reviewed-by: Alexander Usyskin <alexander.usyskin@intel.com>

> Fixes: 386a766c4169 ("mei: Add MEI hardware support for IVSC device")
> Signed-off-by: Hans de Goede <hansg@kernel.org>
> ---
>  drivers/misc/mei/platform-vsc.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/misc/mei/platform-vsc.c b/drivers/misc/mei/platform-vsc.c
> index 1ac85f0251c5..b2b5a20ae3fa 100644
> --- a/drivers/misc/mei/platform-vsc.c
> +++ b/drivers/misc/mei/platform-vsc.c
> @@ -380,6 +380,8 @@ static int mei_vsc_probe(struct platform_device
> *pdev)
>  err_cancel:
>  	mei_cancel_work(mei_dev);
> 
> +	vsc_tp_register_event_cb(tp, NULL, NULL);
> +
>  	mei_disable_interrupts(mei_dev);
> 
>  	return ret;
> @@ -388,11 +390,14 @@ static int mei_vsc_probe(struct platform_device
> *pdev)
>  static void mei_vsc_remove(struct platform_device *pdev)
>  {
>  	struct mei_device *mei_dev = platform_get_drvdata(pdev);
> +	struct mei_vsc_hw *hw = mei_dev_to_vsc_hw(mei_dev);
> 
>  	pm_runtime_disable(mei_dev->dev);
> 
>  	mei_stop(mei_dev);
> 
> +	vsc_tp_register_event_cb(hw->tp, NULL, NULL);
> +
>  	mei_disable_interrupts(mei_dev);
> 
>  	mei_deregister(mei_dev);
> --
> 2.49.0