[PATCH 03/10] mei: vsc: Don't call vsc_tp_reset() a second time on shutdown

Hans de Goede posted 10 patches 3 months, 2 weeks ago
[PATCH 03/10] mei: vsc: Don't call vsc_tp_reset() a second time on shutdown
Posted by Hans de Goede 3 months, 2 weeks ago
Now that mei_vsc_hw_reset() no longer re-inits the VSC when called from
mei_stop(), vsc_tp_shutdown() unregistering the platform-device, which
runs mei_stop() is sufficient to put the VSC in a clean state.

Signed-off-by: Hans de Goede <hansg@kernel.org>
---
 drivers/misc/mei/vsc-tp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c
index 99a55451e1fc..4a262e2117e4 100644
--- a/drivers/misc/mei/vsc-tp.c
+++ b/drivers/misc/mei/vsc-tp.c
@@ -547,8 +547,6 @@ static void vsc_tp_shutdown(struct spi_device *spi)
 
 	mutex_destroy(&tp->mutex);
 
-	vsc_tp_reset(tp);
-
 	free_irq(spi->irq, tp);
 }
 
-- 
2.49.0
RE: [PATCH 03/10] mei: vsc: Don't call vsc_tp_reset() a second time on shutdown
Posted by Usyskin, Alexander 3 months, 2 weeks ago
> Subject: [PATCH 03/10] mei: vsc: Don't call vsc_tp_reset() a second time on
> shutdown
> 
> Now that mei_vsc_hw_reset() no longer re-inits the VSC when called from
> mei_stop(), vsc_tp_shutdown() unregistering the platform-device, which
> runs mei_stop() is sufficient to put the VSC in a clean state.
> 

Reviewed-by: Alexander Usyskin <alexander.usyskin@intel.com>

> Signed-off-by: Hans de Goede <hansg@kernel.org>
> ---
>  drivers/misc/mei/vsc-tp.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c
> index 99a55451e1fc..4a262e2117e4 100644
> --- a/drivers/misc/mei/vsc-tp.c
> +++ b/drivers/misc/mei/vsc-tp.c
> @@ -547,8 +547,6 @@ static void vsc_tp_shutdown(struct spi_device *spi)
> 
>  	mutex_destroy(&tp->mutex);
> 
> -	vsc_tp_reset(tp);
> -
>  	free_irq(spi->irq, tp);
>  }
> 
> --
> 2.49.0