soc: qcom: rpmh-rsc: Add RSC version 4 support

[PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support

Posted by Maulik Shah 3 months, 2 weeks ago

Register offsets for v3 and v4 versions are backward compatible. Assign v3
offsets for v4 and all higher versions to avoid end up using v2 offsets.

Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
---
 drivers/soc/qcom/rpmh-rsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
index cb82e887b51d4401edba713348eed9621622b73b..fdab2b1067dbb13efbbef5cc3ef795a65fc2d6a1 100644
--- a/drivers/soc/qcom/rpmh-rsc.c
+++ b/drivers/soc/qcom/rpmh-rsc.c
@@ -1072,7 +1072,7 @@ static int rpmh_rsc_probe(struct platform_device *pdev)
 	drv->ver.minor = rsc_id & (MINOR_VER_MASK << MINOR_VER_SHIFT);
 	drv->ver.minor >>= MINOR_VER_SHIFT;
 
-	if (drv->ver.major == 3)
+	if (drv->ver.major >= 3)
 		drv->regs = rpmh_rsc_reg_offset_ver_3_0;
 	else
 		drv->regs = rpmh_rsc_reg_offset_ver_2_7;

---
base-commit: 5d4809e25903ab8e74034c1f23c787fd26d52934
change-id: 20250623-rsc_v4-ec10a1aadbb8

Best regards,
-- 
Maulik Shah <maulik.shah@oss.qualcomm.com>

Re: [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support

Posted by Bjorn Andersson 2 months, 3 weeks ago

On Mon, 23 Jun 2025 11:19:43 +0530, Maulik Shah wrote:
> Register offsets for v3 and v4 versions are backward compatible. Assign v3
> offsets for v4 and all higher versions to avoid end up using v2 offsets.
> 
> 

Applied, thanks!

[1/1] soc: qcom: rpmh-rsc: Add RSC version 4 support
      commit: 84684c57c9cd47b86c883a7170dd68222d97ef13

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support

Posted by Konrad Dybcio 3 months, 2 weeks ago

On 6/23/25 7:49 AM, Maulik Shah wrote:
> Register offsets for v3 and v4 versions are backward compatible. Assign v3
> offsets for v4 and all higher versions to avoid end up using v2 offsets.
> 
> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH] soc: qcom: rpmh-rsc: Add RSC version 4 support

Posted by neil.armstrong@linaro.org 3 months, 2 weeks ago

On 23/06/2025 07:49, Maulik Shah wrote:
> Register offsets for v3 and v4 versions are backward compatible. Assign v3
> offsets for v4 and all higher versions to avoid end up using v2 offsets.
> 
> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
> ---
>   drivers/soc/qcom/rpmh-rsc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> index cb82e887b51d4401edba713348eed9621622b73b..fdab2b1067dbb13efbbef5cc3ef795a65fc2d6a1 100644
> --- a/drivers/soc/qcom/rpmh-rsc.c
> +++ b/drivers/soc/qcom/rpmh-rsc.c
> @@ -1072,7 +1072,7 @@ static int rpmh_rsc_probe(struct platform_device *pdev)
>   	drv->ver.minor = rsc_id & (MINOR_VER_MASK << MINOR_VER_SHIFT);
>   	drv->ver.minor >>= MINOR_VER_SHIFT;
>   
> -	if (drv->ver.major == 3)
> +	if (drv->ver.major >= 3)
>   		drv->regs = rpmh_rsc_reg_offset_ver_3_0;
>   	else
>   		drv->regs = rpmh_rsc_reg_offset_ver_2_7;
> 
> ---
> base-commit: 5d4809e25903ab8e74034c1f23c787fd26d52934
> change-id: 20250623-rsc_v4-ec10a1aadbb8
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>