1. Patchew
  2. linux
  3. [PATCH v2 0/3] Add helper methods i3c_writel_fifo() and i3c_readl_fifo()
  4. View patch

[PATCH v2 2/3] i3c: master: cdns: Use i3c_master_writesl() and i3c_master_readsl()

Jorge Marques posted 3 patches 3 months, 2 weeks ago
There is a newer version of this series
[PATCH v2 2/3] i3c: master: cdns: Use i3c_master_writesl() and i3c_master_readsl()
Posted by Jorge Marques 3 months, 2 weeks ago 
Use common inline i3c_master_writesl()/i3c_master_readsl() methods to
simplify code since the FIFO of controller is a 32bit width.

Signed-off-by: Jorge Marques <jorge.marques@analog.com>
---
 drivers/i3c/master/i3c-master-cdns.c | 25 +++++--------------------
 1 file changed, 5 insertions(+), 20 deletions(-)

diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-master-cdns.c
index fd3752cea654954ed1e37337754e45fddbbbf68e..321c04d2109ec1951f2b07a9d1b88c6aaf055c95 100644
--- a/drivers/i3c/master/i3c-master-cdns.c
+++ b/drivers/i3c/master/i3c-master-cdns.c
@@ -23,6 +23,8 @@
 #include <linux/spinlock.h>
 #include <linux/workqueue.h>
 
+#include "../internals.h"
+
 #define DEV_ID				0x0
 #define DEV_ID_I3C_MASTER		0x5034
 
@@ -427,25 +429,13 @@ to_cdns_i3c_master(struct i3c_master_controller *master)
 static void cdns_i3c_master_wr_to_tx_fifo(struct cdns_i3c_master *master,
 					  const u8 *bytes, int nbytes)
 {
-	writesl(master->regs + TX_FIFO, bytes, nbytes / 4);
-	if (nbytes & 3) {
-		u32 tmp = 0;
-
-		memcpy(&tmp, bytes + (nbytes & ~3), nbytes & 3);
-		writesl(master->regs + TX_FIFO, &tmp, 1);
-	}
+	i3c_writel_fifo(master->regs + TX_FIFO, bytes, nbytes);
 }
 
 static void cdns_i3c_master_rd_from_rx_fifo(struct cdns_i3c_master *master,
 					    u8 *bytes, int nbytes)
 {
-	readsl(master->regs + RX_FIFO, bytes, nbytes / 4);
-	if (nbytes & 3) {
-		u32 tmp;
-
-		readsl(master->regs + RX_FIFO, &tmp, 1);
-		memcpy(bytes + (nbytes & ~3), &tmp, nbytes & 3);
-	}
+	i3c_readl_fifo(master->regs + RX_FIFO, bytes, nbytes);
 }
 
 static bool cdns_i3c_master_supports_ccc_cmd(struct i3c_master_controller *m,
@@ -1330,12 +1320,7 @@ static void cdns_i3c_master_handle_ibi(struct cdns_i3c_master *master,
 	buf = slot->data;
 
 	nbytes = IBIR_XFER_BYTES(ibir);
-	readsl(master->regs + IBI_DATA_FIFO, buf, nbytes / 4);
-	if (nbytes % 3) {
-		u32 tmp = __raw_readl(master->regs + IBI_DATA_FIFO);
-
-		memcpy(buf + (nbytes & ~3), &tmp, nbytes & 3);
-	}
+	i3c_readl_fifo(master->regs + IBI_DATA_FIFO, buf, nbytes);
 
 	slot->len = min_t(unsigned int, IBIR_XFER_BYTES(ibir),
 			  dev->ibi->max_payload_len);

-- 
2.49.0
Re: [PATCH v2 2/3] i3c: master: cdns: Use i3c_master_writesl() and i3c_master_readsl()
Posted by Frank Li 3 months, 2 weeks ago 
On Sun, Jun 22, 2025 at 11:18:59AM +0200, Jorge Marques wrote:
> Use common inline i3c_master_writesl()/i3c_master_readsl() methods to

API name changed, you need update it also, include subject.

Frank

> simplify code since the FIFO of controller is a 32bit width.
>
> Signed-off-by: Jorge Marques <jorge.marques@analog.com>
> ---
>  drivers/i3c/master/i3c-master-cdns.c | 25 +++++--------------------
>  1 file changed, 5 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-master-cdns.c
> index fd3752cea654954ed1e37337754e45fddbbbf68e..321c04d2109ec1951f2b07a9d1b88c6aaf055c95 100644
> --- a/drivers/i3c/master/i3c-master-cdns.c
> +++ b/drivers/i3c/master/i3c-master-cdns.c
> @@ -23,6 +23,8 @@
>  #include <linux/spinlock.h>
>  #include <linux/workqueue.h>
>
> +#include "../internals.h"
> +
>  #define DEV_ID				0x0
>  #define DEV_ID_I3C_MASTER		0x5034
>
> @@ -427,25 +429,13 @@ to_cdns_i3c_master(struct i3c_master_controller *master)
>  static void cdns_i3c_master_wr_to_tx_fifo(struct cdns_i3c_master *master,
>  					  const u8 *bytes, int nbytes)
>  {
> -	writesl(master->regs + TX_FIFO, bytes, nbytes / 4);
> -	if (nbytes & 3) {
> -		u32 tmp = 0;
> -
> -		memcpy(&tmp, bytes + (nbytes & ~3), nbytes & 3);
> -		writesl(master->regs + TX_FIFO, &tmp, 1);
> -	}
> +	i3c_writel_fifo(master->regs + TX_FIFO, bytes, nbytes);
>  }
>
>  static void cdns_i3c_master_rd_from_rx_fifo(struct cdns_i3c_master *master,
>  					    u8 *bytes, int nbytes)
>  {
> -	readsl(master->regs + RX_FIFO, bytes, nbytes / 4);
> -	if (nbytes & 3) {
> -		u32 tmp;
> -
> -		readsl(master->regs + RX_FIFO, &tmp, 1);
> -		memcpy(bytes + (nbytes & ~3), &tmp, nbytes & 3);
> -	}
> +	i3c_readl_fifo(master->regs + RX_FIFO, bytes, nbytes);
>  }
>
>  static bool cdns_i3c_master_supports_ccc_cmd(struct i3c_master_controller *m,
> @@ -1330,12 +1320,7 @@ static void cdns_i3c_master_handle_ibi(struct cdns_i3c_master *master,
>  	buf = slot->data;
>
>  	nbytes = IBIR_XFER_BYTES(ibir);
> -	readsl(master->regs + IBI_DATA_FIFO, buf, nbytes / 4);
> -	if (nbytes % 3) {
> -		u32 tmp = __raw_readl(master->regs + IBI_DATA_FIFO);
> -
> -		memcpy(buf + (nbytes & ~3), &tmp, nbytes & 3);
> -	}
> +	i3c_readl_fifo(master->regs + IBI_DATA_FIFO, buf, nbytes);
>
>  	slot->len = min_t(unsigned int, IBIR_XFER_BYTES(ibir),
>  			  dev->ibi->max_payload_len);
>
> --
> 2.49.0
>
>
Re: [PATCH v2 2/3] i3c: master: cdns: Use i3c_master_writesl() and i3c_master_readsl()
Posted by Jorge Marques 3 months, 2 weeks ago 
On Mon, Jun 23, 2025 at 11:45:19AM -0400, Frank Li wrote:
> On Sun, Jun 22, 2025 at 11:18:59AM +0200, Jorge Marques wrote:
> > Use common inline i3c_master_writesl()/i3c_master_readsl() methods to
> 
> API name changed, you need update it also, include subject.
> 
> Frank
> 
Ack

Regards,
Jorge
> > simplify code since the FIFO of controller is a 32bit width.
> >
> > Signed-off-by: Jorge Marques <jorge.marques@analog.com>
> > ---
> >  drivers/i3c/master/i3c-master-cdns.c | 25 +++++--------------------
> >  1 file changed, 5 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-master-cdns.c
> > index fd3752cea654954ed1e37337754e45fddbbbf68e..321c04d2109ec1951f2b07a9d1b88c6aaf055c95 100644
> > --- a/drivers/i3c/master/i3c-master-cdns.c
> > +++ b/drivers/i3c/master/i3c-master-cdns.c
> > @@ -23,6 +23,8 @@
> >  #include <linux/spinlock.h>
> >  #include <linux/workqueue.h>
> >
> > +#include "../internals.h"
> > +
> >  #define DEV_ID				0x0
> >  #define DEV_ID_I3C_MASTER		0x5034
> >
> > @@ -427,25 +429,13 @@ to_cdns_i3c_master(struct i3c_master_controller *master)
> >  static void cdns_i3c_master_wr_to_tx_fifo(struct cdns_i3c_master *master,
> >  					  const u8 *bytes, int nbytes)
> >  {
> > -	writesl(master->regs + TX_FIFO, bytes, nbytes / 4);
> > -	if (nbytes & 3) {
> > -		u32 tmp = 0;
> > -
> > -		memcpy(&tmp, bytes + (nbytes & ~3), nbytes & 3);
> > -		writesl(master->regs + TX_FIFO, &tmp, 1);
> > -	}
> > +	i3c_writel_fifo(master->regs + TX_FIFO, bytes, nbytes);
> >  }
> >
> >  static void cdns_i3c_master_rd_from_rx_fifo(struct cdns_i3c_master *master,
> >  					    u8 *bytes, int nbytes)
> >  {
> > -	readsl(master->regs + RX_FIFO, bytes, nbytes / 4);
> > -	if (nbytes & 3) {
> > -		u32 tmp;
> > -
> > -		readsl(master->regs + RX_FIFO, &tmp, 1);
> > -		memcpy(bytes + (nbytes & ~3), &tmp, nbytes & 3);
> > -	}
> > +	i3c_readl_fifo(master->regs + RX_FIFO, bytes, nbytes);
> >  }
> >
> >  static bool cdns_i3c_master_supports_ccc_cmd(struct i3c_master_controller *m,
> > @@ -1330,12 +1320,7 @@ static void cdns_i3c_master_handle_ibi(struct cdns_i3c_master *master,
> >  	buf = slot->data;
> >
> >  	nbytes = IBIR_XFER_BYTES(ibir);
> > -	readsl(master->regs + IBI_DATA_FIFO, buf, nbytes / 4);
> > -	if (nbytes % 3) {
> > -		u32 tmp = __raw_readl(master->regs + IBI_DATA_FIFO);
> > -
> > -		memcpy(buf + (nbytes & ~3), &tmp, nbytes & 3);
> > -	}
> > +	i3c_readl_fifo(master->regs + IBI_DATA_FIFO, buf, nbytes);
> >
> >  	slot->len = min_t(unsigned int, IBIR_XFER_BYTES(ibir),
> >  			  dev->ibi->max_payload_len);
> >
> > --
> > 2.49.0
> >
> >

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.