i3c: master: Initialize ret in i3c_i2c_notifier_call()

[PATCH] i3c: master: Initialize ret in i3c_i2c_notifier_call()

Posted by Jorge Marques 3 months, 2 weeks ago

Set ret to -EINVAL if i3c_i2c_notifier_call() receives an invalid
action, resolving uninitialized warning.

Signed-off-by: Jorge Marques <jorge.marques@analog.com>
---
If a invalid action was passed to i3c_i2c_notifier_call(), uninitialized
would be returned. Add a default option in the switch case to set it as
-EINVAL; I didn't set at the variable definition for readability
purpose. The warning was caught by smatch.
---
 drivers/i3c/master.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index fd81871609d95bc082bd401681e7e132ea74f8a7..68b8ea9174b984a6c89b389c4b3a9669239def70 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2467,6 +2467,8 @@ static int i3c_i2c_notifier_call(struct notifier_block *nb, unsigned long action
 	case BUS_NOTIFY_DEL_DEVICE:
 		ret = i3c_master_i2c_detach(adap, client);
 		break;
+	default:
+		ret = -EINVAL;
 	}
 	i3c_bus_maintenance_unlock(&master->bus);
 

---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250622-i3c-master-ret-uninitialized-16265d8a8719

Best regards,
-- 
Jorge Marques <jorge.marques@analog.com>

Re: [PATCH] i3c: master: Initialize ret in i3c_i2c_notifier_call()

Posted by Alexandre Belloni 3 months, 1 week ago

On Sun, 22 Jun 2025 12:11:07 +0200, Jorge Marques wrote:
> Set ret to -EINVAL if i3c_i2c_notifier_call() receives an invalid
> action, resolving uninitialized warning.
> 
> 

Applied, thanks!

[1/1] i3c: master: Initialize ret in i3c_i2c_notifier_call()
      https://git.kernel.org/abelloni/c/290ce8b2d074

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH] i3c: master: Initialize ret in i3c_i2c_notifier_call()

Posted by Frank Li 3 months, 2 weeks ago

On Sun, Jun 22, 2025 at 12:11:07PM +0200, Jorge Marques wrote:
> Set ret to -EINVAL if i3c_i2c_notifier_call() receives an invalid
> action, resolving uninitialized warning.
>
> Signed-off-by: Jorge Marques <jorge.marques@analog.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
> If a invalid action was passed to i3c_i2c_notifier_call(), uninitialized
> would be returned. Add a default option in the switch case to set it as
> -EINVAL; I didn't set at the variable definition for readability
> purpose. The warning was caught by smatch.
> ---
>  drivers/i3c/master.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index fd81871609d95bc082bd401681e7e132ea74f8a7..68b8ea9174b984a6c89b389c4b3a9669239def70 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -2467,6 +2467,8 @@ static int i3c_i2c_notifier_call(struct notifier_block *nb, unsigned long action
>  	case BUS_NOTIFY_DEL_DEVICE:
>  		ret = i3c_master_i2c_detach(adap, client);
>  		break;
> +	default:
> +		ret = -EINVAL;
>  	}
>  	i3c_bus_maintenance_unlock(&master->bus);
>
>
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250622-i3c-master-ret-uninitialized-16265d8a8719
>
> Best regards,
> --
> Jorge Marques <jorge.marques@analog.com>
>
>
>
> --
> linux-i3c mailing list
> linux-i3c@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c