[PATCH v2] staging: media: atomisp: fix coding style in ia_css_output.host.c

LiangCheng Wang posted 1 patch 3 months, 2 weeks ago
There is a newer version of this series
.../atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c   | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
[PATCH v2] staging: media: atomisp: fix coding style in ia_css_output.host.c
Posted by LiangCheng Wang 3 months, 2 weeks ago
Fix two checkpatch.pl ERRORs:
- Use tab instead of space for indentation
- Move trailing statement to next line after if statement

Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
---
This patch fixes coding style violations detected by checkpatch.pl in the atomisp driver under staging.

- Use tabs instead of spaces for indentation
- Move trailing `if` statements to multiline format

This cleanup improves code readability and follows Linux kernel coding standards.
---
Changes in v2:
- Fix patch subject prefix to "staging: media: atomisp:" to comply with media CI style.
- No other functional changes.

Link to v1: https://lore.kernel.org/r/20250621-bar-v1-1-5a3e7004462c@gmail.com
---
 .../atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c   | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
index d09365e0c47104dbffbd455bfd649b9079f88c9c..044c7d3706f486ba7cae5941ac598044c831b6c2 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
@@ -74,7 +74,7 @@ int ia_css_output0_config(struct sh_css_isp_output_isp_config       *to,
 }
 
 int ia_css_output1_config(struct sh_css_isp_output_isp_config       *to,
-		          const struct ia_css_output1_configuration *from,
+			  const struct ia_css_output1_configuration *from,
 			  unsigned int size)
 {
 	return ia_css_output_config(to, (const struct ia_css_output_configuration *)from, size);
@@ -127,7 +127,8 @@ ia_css_output_dump(
     const struct sh_css_isp_output_params *output,
     unsigned int level)
 {
-	if (!output) return;
+	if (!output)
+		return;
 	ia_css_debug_dtrace(level, "Horizontal Output Flip:\n");
 	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
 			    "enable", output->enable_hflip);

---
base-commit: 3f75bfff44be0646580fe4efda45d646f9c1693b
change-id: 20250621-bar-573b8b40fb80

Best regards,
-- 
LiangCheng Wang <zaq14760@gmail.com>
Re: [PATCH v2] staging: media: atomisp: fix coding style in ia_css_output.host.c
Posted by Andy Shevchenko 3 months, 2 weeks ago
On Sat, Jun 21, 2025 at 5:32 PM LiangCheng Wang <zaq14760@gmail.com> wrote:
>
> Fix two checkpatch.pl ERRORs:
> - Use tab instead of space for indentation
> - Move trailing statement to next line after if statement

...

>  int ia_css_output1_config(struct sh_css_isp_output_isp_config       *to,

And what about this big space between 'g' and '*'?

> -                         const struct ia_css_output1_configuration *from,
> +                         const struct ia_css_output1_configuration *from,
>                           unsigned int size)

-- 
With Best Regards,
Andy Shevchenko