[PATCH v5 03/14] sched/deadline: Clear the defer params

Joel Fernandes posted 14 patches 3 months, 2 weeks ago
There is a newer version of this series
[PATCH v5 03/14] sched/deadline: Clear the defer params
Posted by Joel Fernandes 3 months, 2 weeks ago
The defer params were not cleared in __dl_clear_params. Clear them.

Without this is some of my test cases are flaking and the DL timer is
not starting correctly AFAICS.

Fixes: a110a81c52a9 ("sched/deadline: Deferrable dl server")
Reviewed-by: Andrea Righi <arighi@nvidia.com>
Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
---
 kernel/sched/deadline.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index ad45a8fea245..ae15ec6294cf 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -3431,6 +3431,9 @@ static void __dl_clear_params(struct sched_dl_entity *dl_se)
 	dl_se->dl_non_contending	= 0;
 	dl_se->dl_overrun		= 0;
 	dl_se->dl_server		= 0;
+	dl_se->dl_defer			= 0;
+	dl_se->dl_defer_running	= 0;
+	dl_se->dl_defer_armed	= 0;
 
 #ifdef CONFIG_RT_MUTEXES
 	dl_se->pi_se			= dl_se;
-- 
2.43.0
Re: [PATCH v5 03/14] sched/deadline: Clear the defer params
Posted by Tejun Heo 3 months, 2 weeks ago
On Fri, Jun 20, 2025 at 04:32:18PM -0400, Joel Fernandes wrote:
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index ad45a8fea245..ae15ec6294cf 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -3431,6 +3431,9 @@ static void __dl_clear_params(struct sched_dl_entity *dl_se)
>  	dl_se->dl_non_contending	= 0;
>  	dl_se->dl_overrun		= 0;
>  	dl_se->dl_server		= 0;
> +	dl_se->dl_defer			= 0;
> +	dl_se->dl_defer_running	= 0;
> +	dl_se->dl_defer_armed	= 0;

Match indentations?

-- 
tejun
Re: [PATCH v5 03/14] sched/deadline: Clear the defer params
Posted by Joel Fernandes 3 months, 1 week ago
On Mon, Jun 23, 2025 at 10:17:33AM -1000, Tejun Heo wrote:
> On Fri, Jun 20, 2025 at 04:32:18PM -0400, Joel Fernandes wrote:
> > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> > index ad45a8fea245..ae15ec6294cf 100644
> > --- a/kernel/sched/deadline.c
> > +++ b/kernel/sched/deadline.c
> > @@ -3431,6 +3431,9 @@ static void __dl_clear_params(struct sched_dl_entity *dl_se)
> >  	dl_se->dl_non_contending	= 0;
> >  	dl_se->dl_overrun		= 0;
> >  	dl_se->dl_server		= 0;
> > +	dl_se->dl_defer			= 0;
> > +	dl_se->dl_defer_running	= 0;
> > +	dl_se->dl_defer_armed	= 0;
> 
> Match indentations?

Sure, will do. Thanks.

thanks,

 - Joel