MAINTAINERS | 2 + rust/bindings/bindings_helper.h | 1 + rust/helpers/helpers.c | 1 + rust/helpers/of.c | 8 +++ rust/kernel/acpi.rs | 60 +++++++++++++++++++++ rust/kernel/device/property.rs | 7 +++ rust/kernel/driver.rs | 81 +++++++++++++++++++++------- rust/kernel/lib.rs | 1 + rust/kernel/platform.rs | 29 ++++++++-- samples/rust/rust_driver_platform.rs | 80 +++++++++++++++++++++++++-- 10 files changed, 243 insertions(+), 27 deletions(-) create mode 100644 rust/helpers/of.c create mode 100644 rust/kernel/acpi.rs
This patch series introduces support for ACPI match tables in Rust
drivers.
Currently, Rust abstractions support only Open Firmware (OF) device
matching. This series extends the driver model to support ACPI-based
matching, enabling Rust drivers to bind to ACPI-described devices.
Changes include:
- A new `acpi::DeviceId` abstraction for working with
`struct acpi_device_id`.
- Updates to the core `Adapter` trait and `platform::Driver` to support
optional ACPI ID tables.
- A sample implementation in the Rust platform driver, demonstrating
multi-bus matching.
This is especially useful for writing drivers that work across platforms
using both OF and ACPI.
Tested using QEMU with a custom SSDT that creates an ACPI device matching
the sample Rust platform driver.
This series is based on three patches by Danilo Krummrich, which
introduce general improvements to the Rust platform driver. These patches
re included unchanged at the beginning of the series for completeness, as
they are required for the ACPI integration.
Danilo Krummrich (3):
rust: device: implement FwNode::is_of_node()
samples: rust: platform: don't call as_ref() repeatedly
samples: rust: platform: conditionally call Self::properties_parse()
Igor Korotin (6):
rust: acpi: add `acpi::DeviceId` abstraction
rust: driver: Consolidate `Adapter::of_id_info` methods using `#[cfg]`
rust: driver: Add ACPI id table support to Adapter trait
rust: platform: Set `OF_ID_TABLE` default to `None` in `Driver` trait
rust: platform: Add ACPI match table support to `Driver` trait
samples: rust: add ACPI match table example to platform driver
Changelog
---------
v8:
- Rebased on top of the latest state of the `driver-core-next` branch.
- Replaced `FwNode::is_compatible()` API with `FwNode::is_of_node()`
per Danilo's request. This includes initial commit and conditional call
in `samples: rust: platform: conditionally call Self::properties_parse()`
- Link to v7: https://lore.kernel.org/rust-for-linux/20250618100221.3047133-1-igor.korotin.linux@gmail.com/
v7:
- Rebased onto the driver-core-next branch
- Incorporated three of Danilo’s upstream patches as a base
- Switched from `assert!` to `build_assert!` in `acpi::DeviceId::new`
for compile-time checks
- Renamed the sample ACPI HID to `TST0001`
- Moved the ACPI test instructions into the module’s top-level
documentation comment
- Link to v6: https://lore.kernel.org/rust-for-linux/20250613133517.1229722-1-igor.korotin.linux@gmail.com/
v6:
- Moved set `Driver::OF_ID_TABLE` default to `None` to a separate commit
- Removed out of scope change related to cpufreq driver.
- Link to v5: https://lore.kernel.org/rust-for-linux/20250611174034.801460-1-igor.korotin.linux@gmail.com/
v5:
- Got rid of unnecessary consolidation of `Adapter::acpi_id_info` methods.
Instead, firstly made consolidation of `Adapter::of_id_info`, then
`Adapter::acpi_id_info` is added using the same pattern.
- Set `Adapter::OF_ID_TABLE` and `Adapter::ACPI_ID_TABLE` as None by
default.
- Removed `Adapter::OF_ID_TABLE`/`Adapter::ACPI_ID_TABLE` initialization
example due to irrelevance.
- Removed extra `of` dependency and `Adapter::OF_ID_TABLE` initialization
in cpufreq driver.
- Link to v4: https://lore.kernel.org/rust-for-linux/20250610145234.235005-1-igor.korotin.linux@gmail.com/
v4:
- Fixed code example for `trait Adapter` in platform.rs
- Fixed driver implementation example in rust_driver_platform.rs and moved
it to `trait Adapter` in platform.rs per Danilo Krummrich's suggestion.
- Consolidated `Adapter::of_id_info` and `Adapter::acpi_id_info` methods using
`#[cfg]` per Benno Lossin's suggestion.
- Link to v3: https://lore.kernel.org/rust-for-linux/20250606170341.3880941-1-igor.korotin.linux@gmail.com/
v3:
- Removed fwnode type check in `Adapter::id_info` per Greg's and Danilo's
comments
- Removed `is_of_node` rust helper, due to unnecessity.
- Fixed example code in `rust_driver_platform.rs` per Danilo's comment
- Added an instruction of testing ACPI using QEMU with a custom SSDT
- Fixed minor code formatting issues.
- Link to v2: https://lore.kernel.org/rust-for-linux/20250605161956.3658374-1-igor.korotin.linux@gmail.com/
v2:
- Removed misleading comment in `acpi::DeviceID` implementation.
- Removed unnecessary casting in `acpi::DeviceID::new`.
- Moved `pub mod acpi` to correct alphabetical position in `rust/kernel/lib.rs`.
- Link to v1: https://lore.kernel.org/rust-for-linux/20250530123815.1766726-1-igor.korotin.linux@gmail.com/
MAINTAINERS | 2 +
rust/bindings/bindings_helper.h | 1 +
rust/helpers/helpers.c | 1 +
rust/helpers/of.c | 8 +++
rust/kernel/acpi.rs | 60 +++++++++++++++++++++
rust/kernel/device/property.rs | 7 +++
rust/kernel/driver.rs | 81 +++++++++++++++++++++-------
rust/kernel/lib.rs | 1 +
rust/kernel/platform.rs | 29 ++++++++--
samples/rust/rust_driver_platform.rs | 80 +++++++++++++++++++++++++--
10 files changed, 243 insertions(+), 27 deletions(-)
create mode 100644 rust/helpers/of.c
create mode 100644 rust/kernel/acpi.rs
base-commit: b29929b819f35503024c6a7e6ad442f6e36c68a0
--
2.43.0
On Fri, Jun 20, 2025 at 04:09:13PM +0100, Igor Korotin wrote:
> This patch series introduces support for ACPI match tables in Rust
> drivers.
Applied to driver-core-testing, thanks!
Once 0-day testing completed successfully, the patches are merged into
driver-core-next.
> Danilo Krummrich (3):
> rust: device: implement FwNode::is_of_node()
> samples: rust: platform: don't call as_ref() repeatedly
> samples: rust: platform: conditionally call Self::properties_parse()
>
> Igor Korotin (6):
> rust: acpi: add `acpi::DeviceId` abstraction
[ Always inline DeviceId::new() and use &'static CStr; slightly reword
commit message. - Danilo ]
> rust: driver: Consolidate `Adapter::of_id_info` methods using `#[cfg]`
[ Fix clippy warning if #[cfg(not(CONFIG_OF))]; fix checkpatch.pl line
length warnings. - Danilo ]
> rust: driver: Add ACPI id table support to Adapter trait
[ Fix clippy warning if #[cfg(not(CONFIG_OF))]; fix checkpatch.pl line
length warnings. - Danilo ]
> rust: platform: Set `OF_ID_TABLE` default to `None` in `Driver` trait
> rust: platform: Add ACPI match table support to `Driver` trait
[ Use 'LNUXBEEF' as ACPI ID. - Danilo ]
> samples: rust: add ACPI match table example to platform driver
[ Use 'LNUXBEEF' as ACPI ID. - Danilo ]
This patch series introduces basic Rust I2C driver abstractions and optional ACPI match-table support and provides a sample driver demonstrating both OF and ACPI binding Currently Rust I2C abstractions support only Open Firmware OF device matching. This series splits the work into four patches so that the core abstractions and sample driver can land immediately while ACPI integration may be reviewed once the ACPI macros are upstream Changes include - core I2C abstractions `i2c::Device` `i2c::Driver` `i2c::Adapter` built on `struct i2c_client` and `struct i2c_driver` - a standalone Rust sample driver exercising Legacy I2C ID and OF ID matching - optional ACPI ID-table support in the `i2c::Driver` abstraction - ACPI-enabled sample driver showing `kernel::acpi_device_table!` usage This separation lets maintainers review and merge the non-ACPI portions immediately while patches 3 and 4 both depending on the ACPI infrastructure can be queued once the ACPI macros are upstream Patch series: 1 rust: i2c: add basic I2C device and driver abstractions 2 samples: rust: add I2C sample driver (OF only) 3 rust: i2c: support ACPI match-table in driver abstractions Depends-on: 20250620152425.285683-1-igor.korotin.linux@gmail.com 4 samples: rust: show ACPI ID-table in I2C sample driver Depends-on: 20250620152425.285683-1-igor.korotin.linux@gmail.com Igor Korotin (4): rust: i2c: add basic I2C device and driver abstractions samples: rust: add Rust I2C sample driver rust: i2c: ACPI ID-table support for I2C abstractions samples: rust: show ACPI ID-table in I2C sample driver MAINTAINERS | 3 + rust/bindings/bindings_helper.h | 1 + rust/helpers/helpers.c | 1 + rust/helpers/i2c.c | 15 ++ rust/kernel/i2c.rs | 386 ++++++++++++++++++++++++++++++++ rust/kernel/lib.rs | 2 + samples/rust/Kconfig | 11 + samples/rust/Makefile | 1 + samples/rust/rust_driver_i2c.rs | 69 ++++++ 9 files changed, 489 insertions(+) create mode 100644 rust/helpers/i2c.c create mode 100644 rust/kernel/i2c.rs create mode 100644 samples/rust/rust_driver_i2c.rs base-commit: 63dafeb392139b893a73b6331f347613f0929702 -- 2.43.0
On 6/26/25 18:33, Igor Korotin wrote: > This patch series introduces basic Rust I2C driver abstractions > and optional ACPI match-table support and provides a sample driver > demonstrating both OF and ACPI binding > > Currently Rust I2C abstractions support only Open Firmware OF device > matching. This series splits the work into four patches so that the > core abstractions and sample driver can land immediately while ACPI > integration may be reviewed once the ACPI macros are upstream > > Changes include > - core I2C abstractions `i2c::Device` `i2c::Driver` `i2c::Adapter` > built on `struct i2c_client` and `struct i2c_driver` > - a standalone Rust sample driver exercising Legacy I2C ID and OF ID > matching > - optional ACPI ID-table support in the `i2c::Driver` abstraction > - ACPI-enabled sample driver showing `kernel::acpi_device_table!` > usage > > This separation lets maintainers review and merge the non-ACPI portions > immediately while patches 3 and 4 both depending on the ACPI > infrastructure can be queued once the ACPI macros are upstream > > Patch series: > > 1 rust: i2c: add basic I2C device and driver abstractions > 2 samples: rust: add I2C sample driver (OF only) > 3 rust: i2c: support ACPI match-table in driver abstractions > Depends-on: 20250620152425.285683-1-igor.korotin.linux@gmail.com > 4 samples: rust: show ACPI ID-table in I2C sample driver > Depends-on: 20250620152425.285683-1-igor.korotin.linux@gmail.com > > Igor Korotin (4): > rust: i2c: add basic I2C device and driver abstractions > samples: rust: add Rust I2C sample driver > rust: i2c: ACPI ID-table support for I2C abstractions > samples: rust: show ACPI ID-table in I2C sample driver > > MAINTAINERS | 3 + > rust/bindings/bindings_helper.h | 1 + > rust/helpers/helpers.c | 1 + > rust/helpers/i2c.c | 15 ++ > rust/kernel/i2c.rs | 386 ++++++++++++++++++++++++++++++++ > rust/kernel/lib.rs | 2 + > samples/rust/Kconfig | 11 + > samples/rust/Makefile | 1 + > samples/rust/rust_driver_i2c.rs | 69 ++++++ > 9 files changed, 489 insertions(+) > create mode 100644 rust/helpers/i2c.c > create mode 100644 rust/kernel/i2c.rs > create mode 100644 samples/rust/rust_driver_i2c.rs > > > base-commit: 63dafeb392139b893a73b6331f347613f0929702 Please ignore. Was sent by mistake. Thanks Igor
© 2016 - 2025 Red Hat, Inc.