Replace uint8_t with u8 in the ad_sigma_delta driver.
Technically, uint8_t comes from the C standard library, while u8 is a
Linux kernel type. Since we don't use the C standard library in the
kernel, we should use the kernel types instead.
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
drivers/iio/adc/ad_sigma_delta.c | 15 ++++++++-------
include/linux/iio/adc/ad_sigma_delta.h | 10 +++++-----
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
index 6cd3645eaaf38a23d5b6479ac598b6d276cfd81a..1657f64f1c0465b249adcc8a70dda8faf4a90565 100644
--- a/drivers/iio/adc/ad_sigma_delta.c
+++ b/drivers/iio/adc/ad_sigma_delta.c
@@ -14,6 +14,7 @@
#include <linux/module.h>
#include <linux/slab.h>
#include <linux/spi/spi.h>
+#include <linux/types.h>
#include <linux/unaligned.h>
#include <linux/iio/adc/ad_sigma_delta.h>
@@ -38,7 +39,7 @@
* @sigma_delta: The sigma delta device
* @comm: New value for the communications register
*/
-void ad_sd_set_comm(struct ad_sigma_delta *sigma_delta, uint8_t comm)
+void ad_sd_set_comm(struct ad_sigma_delta *sigma_delta, u8 comm)
{
/* Some variants use the lower two bits of the communications register
* to select the channel */
@@ -59,7 +60,7 @@ EXPORT_SYMBOL_NS_GPL(ad_sd_set_comm, "IIO_AD_SIGMA_DELTA");
int ad_sd_write_reg(struct ad_sigma_delta *sigma_delta, unsigned int reg,
unsigned int size, unsigned int val)
{
- uint8_t *data = sigma_delta->tx_buf;
+ u8 *data = sigma_delta->tx_buf;
struct spi_transfer t = {
.tx_buf = data,
.len = size + 1,
@@ -99,9 +100,9 @@ int ad_sd_write_reg(struct ad_sigma_delta *sigma_delta, unsigned int reg,
EXPORT_SYMBOL_NS_GPL(ad_sd_write_reg, "IIO_AD_SIGMA_DELTA");
static int ad_sd_read_reg_raw(struct ad_sigma_delta *sigma_delta,
- unsigned int reg, unsigned int size, uint8_t *val)
+ unsigned int reg, unsigned int size, u8 *val)
{
- uint8_t *data = sigma_delta->tx_buf;
+ u8 *data = sigma_delta->tx_buf;
int ret;
struct spi_transfer t[] = {
{
@@ -185,7 +186,7 @@ EXPORT_SYMBOL_NS_GPL(ad_sd_read_reg, "IIO_AD_SIGMA_DELTA");
int ad_sd_reset(struct ad_sigma_delta *sigma_delta)
{
unsigned int reset_length = sigma_delta->info->num_resetclks;
- uint8_t *buf;
+ u8 *buf;
unsigned int size;
int ret;
@@ -454,7 +455,7 @@ static int ad_sd_buffer_postenable(struct iio_dev *indio_dev)
struct ad_sigma_delta *sigma_delta = iio_device_get_drvdata(indio_dev);
unsigned int i, slot, samples_buf_size;
unsigned int channel;
- uint8_t *samples_buf;
+ u8 *samples_buf;
int ret;
if (sigma_delta->num_slots == 1) {
@@ -543,7 +544,7 @@ static irqreturn_t ad_sd_trigger_handler(int irq, void *p)
struct iio_poll_func *pf = p;
struct iio_dev *indio_dev = pf->indio_dev;
struct ad_sigma_delta *sigma_delta = iio_device_get_drvdata(indio_dev);
- uint8_t *data = sigma_delta->rx_buf;
+ u8 *data = sigma_delta->rx_buf;
unsigned int transfer_size;
unsigned int sample_size;
unsigned int sample_pos;
diff --git a/include/linux/iio/adc/ad_sigma_delta.h b/include/linux/iio/adc/ad_sigma_delta.h
index f242b285081b8d304ca25ae95337425e5842269a..5056677c9941afadc2383febbcafeb02e23a4f44 100644
--- a/include/linux/iio/adc/ad_sigma_delta.h
+++ b/include/linux/iio/adc/ad_sigma_delta.h
@@ -94,7 +94,7 @@ struct ad_sigma_delta {
bool bus_locked;
bool keep_cs_asserted;
- uint8_t comm;
+ u8 comm;
const struct ad_sigma_delta_info *info;
unsigned int active_slots;
@@ -105,7 +105,7 @@ struct ad_sigma_delta {
bool status_appended;
/* map slots to channels in order to know what to expect from devices */
unsigned int *slots;
- uint8_t *samples_buf;
+ u8 *samples_buf;
/*
* DMA (thus cache coherency maintenance) requires the
@@ -114,8 +114,8 @@ struct ad_sigma_delta {
* 'rx_buf' is up to 32 bits per sample + 64 bit timestamp,
* rounded to 16 bytes to take into account padding.
*/
- uint8_t tx_buf[4] __aligned(IIO_DMA_MINALIGN);
- uint8_t rx_buf[16] __aligned(8);
+ u8 tx_buf[4] __aligned(IIO_DMA_MINALIGN);
+ u8 rx_buf[16] __aligned(8);
};
static inline int ad_sigma_delta_set_channel(struct ad_sigma_delta *sd,
@@ -177,7 +177,7 @@ static inline int ad_sigma_delta_postprocess_sample(struct ad_sigma_delta *sd,
return 0;
}
-void ad_sd_set_comm(struct ad_sigma_delta *sigma_delta, uint8_t comm);
+void ad_sd_set_comm(struct ad_sigma_delta *sigma_delta, u8 comm);
int ad_sd_write_reg(struct ad_sigma_delta *sigma_delta, unsigned int reg,
unsigned int size, unsigned int val);
int ad_sd_read_reg(struct ad_sigma_delta *sigma_delta, unsigned int reg,
--
2.43.0On Fri, Jun 20, 2025 at 05:20:08PM -0500, David Lechner wrote: > Replace uint8_t with u8 in the ad_sigma_delta driver. > > Technically, uint8_t comes from the C standard library, while u8 is a > Linux kernel type. Since we don't use the C standard library in the > kernel, we should use the kernel types instead. ... > unsigned int reset_length = sigma_delta->info->num_resetclks; > - uint8_t *buf; > + u8 *buf; > unsigned int size; > int ret; Wondering if in the cases like this we may make it to be reversed xmas tree. unsigned int reset_length = sigma_delta->info->num_resetclks; unsigned int size; u8 *buf; int ret; -- With Best Regards, Andy Shevchenko
On Mon, Jun 23, 2025 at 12:51 AM Andy Shevchenko <andriy.shevchenko@intel.com> wrote: > > On Fri, Jun 20, 2025 at 05:20:08PM -0500, David Lechner wrote: > > Replace uint8_t with u8 in the ad_sigma_delta driver. > > > > Technically, uint8_t comes from the C standard library, while u8 is a > > Linux kernel type. Since we don't use the C standard library in the > > kernel, we should use the kernel types instead. > > ... > > > unsigned int reset_length = sigma_delta->info->num_resetclks; > > - uint8_t *buf; > > + u8 *buf; > > unsigned int size; > > int ret; > > Wondering if in the cases like this we may make it to be reversed xmas tree. Fine with me as long as Jonathan doesn't mind the noise since it looks like I will be doing a v2 anyway. > > unsigned int reset_length = sigma_delta->info->num_resetclks; > unsigned int size; > u8 *buf; > int ret; > > -- > With Best Regards, > Andy Shevchenko > >
On Mon, Jun 23, 2025 at 03:48:30PM -0600, David Lechner wrote: > On Mon, Jun 23, 2025 at 12:51 AM Andy Shevchenko > <andriy.shevchenko@intel.com> wrote: > > On Fri, Jun 20, 2025 at 05:20:08PM -0500, David Lechner wrote: > > > Replace uint8_t with u8 in the ad_sigma_delta driver. ... > > > unsigned int reset_length = sigma_delta->info->num_resetclks; > > > - uint8_t *buf; > > > + u8 *buf; > > > unsigned int size; > > > int ret; > > > > Wondering if in the cases like this we may make it to be reversed xmas tree. > > Fine with me as long as Jonathan doesn't mind the noise since it looks > like I will be doing a v2 anyway. I mean the cases when you touch already the variables and this won't be any *additional* churn to what the change has. > > unsigned int reset_length = sigma_delta->info->num_resetclks; > > unsigned int size; > > u8 *buf; > > int ret; -- With Best Regards, Andy Shevchenko
© 2016 - 2025 Red Hat, Inc.