[PATCH v2 0/3] spi: microchip-core-qspi: Add regular transfers

Conor Dooley posted 3 patches 3 months, 2 weeks ago
drivers/spi/spi-microchip-core-qspi.c | 226 +++++++++++++++++++++++---
1 file changed, 204 insertions(+), 22 deletions(-)
[PATCH v2 0/3] spi: microchip-core-qspi: Add regular transfers
Posted by Conor Dooley 3 months, 2 weeks ago
From: Conor Dooley <conor.dooley@microchip.com>

Hey,

This is a v2 of a patchset I sent about this time last year, adding the
regular transfer_one_message op to the microchip-core-qspi driver. In that
v1 Mark expressed his dislike for that op, so v2 is using
prepare/unprepare/transfer_one instead. The unprepare implementation still
contains the 750 us delay that the driver had back in v1. I've heard a
suggestion internally as to why this is needed, but it was unsubstantiated,
so I still have no justification for it. I held off on sending a v2 because
of a lack of explanation for the delay, but I don't wanna hold off forever
for something I might never understand.

Cheers,
Conor.

v1: https://lore.kernel.org/linux-spi/20240612-brigade-shell-1f626e7e592f@spud/

CC: Conor Dooley <conor.dooley@microchip.com>
CC: Daire McNamara <daire.mcnamara@microchip.com>
CC: Mark Brown <broonie@kernel.org>
CC: linux-spi@vger.kernel.org
CC: linux-kernel@vger.kernel.org

Conor Dooley (2):
  spi: microchip-core-qspi: set min_speed_hz during probe
  spi: microchip-core-qspi: remove unused param from
    mchp_coreqspi_write_op()

Cyril Jean (1):
  spi: microchip-core-qspi: Add regular transfers

 drivers/spi/spi-microchip-core-qspi.c | 226 +++++++++++++++++++++++---
 1 file changed, 204 insertions(+), 22 deletions(-)

-- 
2.45.2
Re: [PATCH v2 0/3] spi: microchip-core-qspi: Add regular transfers
Posted by Mark Brown 3 months, 2 weeks ago
On Fri, 20 Jun 2025 14:28:23 +0100, Conor Dooley wrote:
> Hey,
> 
> This is a v2 of a patchset I sent about this time last year, adding the
> regular transfer_one_message op to the microchip-core-qspi driver. In that
> v1 Mark expressed his dislike for that op, so v2 is using
> prepare/unprepare/transfer_one instead. The unprepare implementation still
> contains the 750 us delay that the driver had back in v1. I've heard a
> suggestion internally as to why this is needed, but it was unsubstantiated,
> so I still have no justification for it. I held off on sending a v2 because
> of a lack of explanation for the delay, but I don't wanna hold off forever
> for something I might never understand.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/3] spi: microchip-core-qspi: set min_speed_hz during probe
      commit: 76f03ce1c6f22805ecf689b1f3ecfb56582eddd5
[2/3] spi: microchip-core-qspi: remove unused param from mchp_coreqspi_write_op()
      commit: 75ca45c472dac206df2ebbc1c0f1f9c3bbdace50
[3/3] spi: microchip-core-qspi: Add regular transfers
      commit: 1256eb42db5d1635f4c6da5b1b58db0b53320883

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark