arch/riscv/include/asm/insn.h | 206 +++++++++++++++++++++++++++++---- arch/riscv/kernel/machine_kexec_file.c | 2 +- arch/riscv/kernel/traps_misaligned.c | 144 +---------------------- arch/riscv/kernel/vector.c | 2 +- arch/riscv/kvm/vcpu_insn.c | 128 +------------------- 5 files changed, 188 insertions(+), 294 deletions(-)
The instructions parsing macros were duplicated and one of them had different
implementations, which is error prone.
So let's consolidate those macros in asm/insn.h.
v1: https://lore.kernel.org/linux-riscv/20250422082545.450453-1-alexghiti@rivosinc.com/
v2: https://lore.kernel.org/linux-riscv/20250508082215.88658-1-alexghiti@rivosinc.com/
v3: https://lore.kernel.org/linux-riscv/20250508125202.108613-1-alexghiti@rivosinc.com/
v4: https://lore.kernel.org/linux-riscv/20250516140805.282770-1-alexghiti@rivosinc.com/
Changes in v5:
- Rebase on top of 6.16-rc1
Changes in v4:
- Rebase on top of for-next (on top of 6.15-rc6)
Changes in v3:
- Fix patch 2 which caused build failures (linux riscv bot), but the
patchset is exactly the same as v2
Changes in v2:
- Rebase on top of 6.15-rc5
- Add RB tags
- Define RV_X() using RV_X_mask() (Clément)
- Remove unused defines (Clément)
- Fix tabulations (Drew)
Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
---
Alexandre Ghiti (3):
riscv: Fix typo EXRACT -> EXTRACT
riscv: Strengthen duplicate and inconsistent definition of RV_X()
riscv: Move all duplicate insn parsing macros into asm/insn.h
arch/riscv/include/asm/insn.h | 206 +++++++++++++++++++++++++++++----
arch/riscv/kernel/machine_kexec_file.c | 2 +-
arch/riscv/kernel/traps_misaligned.c | 144 +----------------------
arch/riscv/kernel/vector.c | 2 +-
arch/riscv/kvm/vcpu_insn.c | 128 +-------------------
5 files changed, 188 insertions(+), 294 deletions(-)
---
base-commit: 731e998c429974cb141a049c1347a9cab444e44c
change-id: 20250620-dev-alex-insn_duplicate_v5_manual-2c23191c30fb
Best regards,
--
Alexandre Ghiti <alexghiti@rivosinc.com>
On 20/06/2025 22:21, Alexandre Ghiti wrote: > The instructions parsing macros were duplicated and one of them had different > implementations, which is error prone. > > So let's consolidate those macros in asm/insn.h. > > v1: https://lore.kernel.org/linux-riscv/20250422082545.450453-1-alexghiti@rivosinc.com/ > v2: https://lore.kernel.org/linux-riscv/20250508082215.88658-1-alexghiti@rivosinc.com/ > v3: https://lore.kernel.org/linux-riscv/20250508125202.108613-1-alexghiti@rivosinc.com/ > v4: https://lore.kernel.org/linux-riscv/20250516140805.282770-1-alexghiti@rivosinc.com/ > > Changes in v5: > - Rebase on top of 6.16-rc1 > > Changes in v4: > - Rebase on top of for-next (on top of 6.15-rc6) > > Changes in v3: > - Fix patch 2 which caused build failures (linux riscv bot), but the > patchset is exactly the same as v2 > > Changes in v2: > - Rebase on top of 6.15-rc5 > - Add RB tags > - Define RV_X() using RV_X_mask() (Clément) > - Remove unused defines (Clément) > - Fix tabulations (Drew) > > Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com> > --- > Alexandre Ghiti (3): > riscv: Fix typo EXRACT -> EXTRACT > riscv: Strengthen duplicate and inconsistent definition of RV_X() > riscv: Move all duplicate insn parsing macros into asm/insn.h > > arch/riscv/include/asm/insn.h | 206 +++++++++++++++++++++++++++++---- > arch/riscv/kernel/machine_kexec_file.c | 2 +- > arch/riscv/kernel/traps_misaligned.c | 144 +---------------------- > arch/riscv/kernel/vector.c | 2 +- > arch/riscv/kvm/vcpu_insn.c | 128 +------------------- > 5 files changed, 188 insertions(+), 294 deletions(-) > --- > base-commit: 731e998c429974cb141a049c1347a9cab444e44c > change-id: 20250620-dev-alex-insn_duplicate_v5_manual-2c23191c30fb > > Best regards, Hi Alex, I already gave my Reviewed-by for the last two commits of this series in V4. Thanks, Clément
On 6/23/25 10:07, Clément Léger wrote: > > On 20/06/2025 22:21, Alexandre Ghiti wrote: >> The instructions parsing macros were duplicated and one of them had different >> implementations, which is error prone. >> >> So let's consolidate those macros in asm/insn.h. >> >> v1: https://lore.kernel.org/linux-riscv/20250422082545.450453-1-alexghiti@rivosinc.com/ >> v2: https://lore.kernel.org/linux-riscv/20250508082215.88658-1-alexghiti@rivosinc.com/ >> v3: https://lore.kernel.org/linux-riscv/20250508125202.108613-1-alexghiti@rivosinc.com/ >> v4: https://lore.kernel.org/linux-riscv/20250516140805.282770-1-alexghiti@rivosinc.com/ >> >> Changes in v5: >> - Rebase on top of 6.16-rc1 >> >> Changes in v4: >> - Rebase on top of for-next (on top of 6.15-rc6) >> >> Changes in v3: >> - Fix patch 2 which caused build failures (linux riscv bot), but the >> patchset is exactly the same as v2 >> >> Changes in v2: >> - Rebase on top of 6.15-rc5 >> - Add RB tags >> - Define RV_X() using RV_X_mask() (Clément) >> - Remove unused defines (Clément) >> - Fix tabulations (Drew) >> >> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com> >> --- >> Alexandre Ghiti (3): >> riscv: Fix typo EXRACT -> EXTRACT >> riscv: Strengthen duplicate and inconsistent definition of RV_X() >> riscv: Move all duplicate insn parsing macros into asm/insn.h >> >> arch/riscv/include/asm/insn.h | 206 +++++++++++++++++++++++++++++---- >> arch/riscv/kernel/machine_kexec_file.c | 2 +- >> arch/riscv/kernel/traps_misaligned.c | 144 +---------------------- >> arch/riscv/kernel/vector.c | 2 +- >> arch/riscv/kvm/vcpu_insn.c | 128 +------------------- >> 5 files changed, 188 insertions(+), 294 deletions(-) >> --- >> base-commit: 731e998c429974cb141a049c1347a9cab444e44c >> change-id: 20250620-dev-alex-insn_duplicate_v5_manual-2c23191c30fb >> >> Best regards, > Hi Alex, > > I already gave my Reviewed-by for the last two commits of this series in V4. Sorry, I'll add them when I merge this patchset. Thanks, Alex > Thanks, > > Clément > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
© 2016 - 2025 Red Hat, Inc.