From: Chen-Yu Tsai <wens@csie.org>
There is a PPU0 reset control bit in the same register as the PPU1
reset control. This missing reset control is for the PCK-600 unit
in the SoC. Manual tests show that the reset control indeed exists,
and if not configured, the system will hang when the PCK-600 registers
are accessed.
Add a reset entry for it at the end of the existing ones.
Fixes: 52dbf84857f0 ("dt-bindings: clk: sunxi-ng: document two Allwinner A523 CCUs")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
include/dt-bindings/reset/sun55i-a523-r-ccu.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/reset/sun55i-a523-r-ccu.h b/include/dt-bindings/reset/sun55i-a523-r-ccu.h
index dd6fbb372e19..eb31ae9958d6 100644
--- a/include/dt-bindings/reset/sun55i-a523-r-ccu.h
+++ b/include/dt-bindings/reset/sun55i-a523-r-ccu.h
@@ -21,5 +21,6 @@
#define RST_BUS_R_IR_RX 12
#define RST_BUS_R_RTC 13
#define RST_BUS_R_CPUCFG 14
+#define RST_BUS_R_PPU0 15
#endif /* _DT_BINDINGS_RST_SUN55I_A523_R_CCU_H_ */
--
2.39.5
On Fri, Jun 20, 2025 at 01:10:24AM +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai <wens@csie.org> > > There is a PPU0 reset control bit in the same register as the PPU1 > reset control. This missing reset control is for the PCK-600 unit > in the SoC. Manual tests show that the reset control indeed exists, > and if not configured, the system will hang when the PCK-600 registers > are accessed. > > Add a reset entry for it at the end of the existing ones. > > Fixes: 52dbf84857f0 ("dt-bindings: clk: sunxi-ng: document two Allwinner A523 CCUs") > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Fri, 20 Jun 2025 01:10:24 +0800 Chen-Yu Tsai <wens@kernel.org> wrote: > From: Chen-Yu Tsai <wens@csie.org> > > There is a PPU0 reset control bit in the same register as the PPU1 > reset control. This missing reset control is for the PCK-600 unit > in the SoC. Manual tests show that the reset control indeed exists, > and if not configured, the system will hang when the PCK-600 registers > are accessed. Confirmed by experiment. > Add a reset entry for it at the end of the existing ones. > > Fixes: 52dbf84857f0 ("dt-bindings: clk: sunxi-ng: document two Allwinner A523 CCUs") > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Cheers, Andre > --- > include/dt-bindings/reset/sun55i-a523-r-ccu.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/dt-bindings/reset/sun55i-a523-r-ccu.h b/include/dt-bindings/reset/sun55i-a523-r-ccu.h > index dd6fbb372e19..eb31ae9958d6 100644 > --- a/include/dt-bindings/reset/sun55i-a523-r-ccu.h > +++ b/include/dt-bindings/reset/sun55i-a523-r-ccu.h > @@ -21,5 +21,6 @@ > #define RST_BUS_R_IR_RX 12 > #define RST_BUS_R_RTC 13 > #define RST_BUS_R_CPUCFG 14 > +#define RST_BUS_R_PPU0 15 > > #endif /* _DT_BINDINGS_RST_SUN55I_A523_R_CCU_H_ */
Quoting Chen-Yu Tsai (2025-06-19 10:10:24) > From: Chen-Yu Tsai <wens@csie.org> > > There is a PPU0 reset control bit in the same register as the PPU1 > reset control. This missing reset control is for the PCK-600 unit > in the SoC. Manual tests show that the reset control indeed exists, > and if not configured, the system will hang when the PCK-600 registers > are accessed. > > Add a reset entry for it at the end of the existing ones. > > Fixes: 52dbf84857f0 ("dt-bindings: clk: sunxi-ng: document two Allwinner A523 CCUs") > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- Acked-by: Stephen Boyd <sboyd@kernel.org>
© 2016 - 2025 Red Hat, Inc.