[PATCH 0/4] firmware: arm_scmi: Add xfer inflight debug and trace

Philip Radford posted 4 patches 3 months, 3 weeks ago
There is a newer version of this series
drivers/firmware/arm_scmi/common.h   |  8 ++++++++
drivers/firmware/arm_scmi/driver.c   | 28 ++++++++++++++++++++++++++--
drivers/firmware/arm_scmi/raw_mode.c |  6 ++++--
include/trace/events/scmi.h          | 24 ++++++++++++++----------
4 files changed, 52 insertions(+), 14 deletions(-)
[PATCH 0/4] firmware: arm_scmi: Add xfer inflight debug and trace
Posted by Philip Radford 3 months, 3 weeks ago
Hi all,

This series adds a new counter to the Arm SCMI firmware driver to track
the number of in-flight message transfers during debug and trace. This
will be useful for examining behaviour under a large load with regards
to concurrent messages being sent and received. As the counter only gives
a live value, printing the value in trace allows logging of the in-flight
xfers.

The series is divided into four small patches:
Patch [1/4]
	- Adds a fuction to decrement debug counters, similar to the existing
	  counter to increment debug counters
Patch [2/4]
	- Adds a new xfers_inflight debug counter to track active transfers
Patch [3/4]
	- Enhances two tracepoints (scmi_xfer_begin and scmi_xfer_end) to
	  include the number of in-flight transfers, setting default values
	  of 0
Patch [4/4]
	- Adds a function (scmi_inflight_count) that retrieves the current
	  in-flight count for use in tracing

Based on v6.16-rc2

Regards,
Phil

Philip Radford (4):
  firmware: arm_scmi: Add debug decrement counter
  firmware: arm_scmi: Add xfer_inflight counter
  include: trace: Add inflight_xfer counter tracepoint
  firmware: arm_scmi: Add new inflight tracing functionality

 drivers/firmware/arm_scmi/common.h   |  8 ++++++++
 drivers/firmware/arm_scmi/driver.c   | 28 ++++++++++++++++++++++++++--
 drivers/firmware/arm_scmi/raw_mode.c |  6 ++++--
 include/trace/events/scmi.h          | 24 ++++++++++++++----------
 4 files changed, 52 insertions(+), 14 deletions(-)

--
2.25.1
Re: [PATCH 0/4] firmware: arm_scmi: Add xfer inflight debug and trace
Posted by Cristian Marussi 3 months, 2 weeks ago
On Thu, Jun 19, 2025 at 12:20:00PM +0000, Philip Radford wrote:
> Hi all,

Hi,

as mentioned offline, please rebase V2 on sudeep/for-next/scmi/updates
and add proper version diffs summary all-over.

Thanks,
Cristian
Re: [PATCH 0/4] firmware: arm_scmi: Add xfer inflight debug and trace
Posted by Peng Fan 3 months, 2 weeks ago
On Thu, Jun 19, 2025 at 12:20:00PM +0000, Philip Radford wrote:
>Hi all,
>
>This series adds a new counter to the Arm SCMI firmware driver to track
>the number of in-flight message transfers during debug and trace. This
>will be useful for examining behaviour under a large load with regards
>to concurrent messages being sent and received. As the counter only gives
>a live value, printing the value in trace allows logging of the in-flight
>xfers.

Just a general question, is this counter count in flight messages
for a scmi instance or it is per transport? I ask because 
one scmi instance could have multiple mailboxes. If counting based
on scmi instance, it may not be that accurate.

Thanks,
Peng

>
>The series is divided into four small patches:
>Patch [1/4]
>	- Adds a fuction to decrement debug counters, similar to the existing
>	  counter to increment debug counters
>Patch [2/4]
>	- Adds a new xfers_inflight debug counter to track active transfers
>Patch [3/4]
>	- Enhances two tracepoints (scmi_xfer_begin and scmi_xfer_end) to
>	  include the number of in-flight transfers, setting default values
>	  of 0
>Patch [4/4]
>	- Adds a function (scmi_inflight_count) that retrieves the current
>	  in-flight count for use in tracing
>
>Based on v6.16-rc2
>
>Regards,
>Phil
>
>Philip Radford (4):
>  firmware: arm_scmi: Add debug decrement counter
>  firmware: arm_scmi: Add xfer_inflight counter
>  include: trace: Add inflight_xfer counter tracepoint
>  firmware: arm_scmi: Add new inflight tracing functionality
>
> drivers/firmware/arm_scmi/common.h   |  8 ++++++++
> drivers/firmware/arm_scmi/driver.c   | 28 ++++++++++++++++++++++++++--
> drivers/firmware/arm_scmi/raw_mode.c |  6 ++++--
> include/trace/events/scmi.h          | 24 ++++++++++++++----------
> 4 files changed, 52 insertions(+), 14 deletions(-)
>
>--
>2.25.1
>