[PATCH][next] wifi: ath11k: Make read-only const array svc_id static const

Colin Ian King posted 1 patch 3 months, 3 weeks ago
drivers/net/wireless/ath/ath11k/htc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH][next] wifi: ath11k: Make read-only const array svc_id static const
Posted by Colin Ian King 3 months, 3 weeks ago
Don't populate the read-only array svc_id on the stack at run time,
instead make it static const.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/net/wireless/ath/ath11k/htc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/htc.c b/drivers/net/wireless/ath/ath11k/htc.c
index 23054ab29a5e..4571d01cc33d 100644
--- a/drivers/net/wireless/ath/ath11k/htc.c
+++ b/drivers/net/wireless/ath/ath11k/htc.c
@@ -497,7 +497,7 @@ static u8 ath11k_htc_get_credit_allocation(struct ath11k_htc *htc,
 static int ath11k_htc_setup_target_buffer_assignments(struct ath11k_htc *htc)
 {
 	struct ath11k_htc_svc_tx_credits *serv_entry;
-	u32 svc_id[] = {
+	static const u32 svc_id[] = {
 		ATH11K_HTC_SVC_ID_WMI_CONTROL,
 		ATH11K_HTC_SVC_ID_WMI_CONTROL_MAC1,
 		ATH11K_HTC_SVC_ID_WMI_CONTROL_MAC2,
-- 
2.49.0
Re: [PATCH][next] wifi: ath11k: Make read-only const array svc_id static const
Posted by Jeff Johnson 3 months, 2 weeks ago
On Thu, 19 Jun 2025 09:20:10 +0100, Colin Ian King wrote:
> Don't populate the read-only array svc_id on the stack at run time,
> instead make it static const.
> 
> 

Applied, thanks!

[1/1] wifi: ath11k: Make read-only const array svc_id static const
      commit: d8f07889e920493845fd628407ff0debbe96fa09

Best regards,
-- 
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Re: [PATCH][next] wifi: ath11k: Make read-only const array svc_id static const
Posted by Vasanthakumar Thiagarajan 3 months, 2 weeks ago

On 6/19/2025 1:50 PM, Colin Ian King wrote:
> Don't populate the read-only array svc_id on the stack at run time,
> instead make it static const.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>