[PATCH v3 0/2] Add driver support for ESWIN eic7700 SoC reset controller

dongxuyang@eswincomputing.com posted 2 patches 3 months, 3 weeks ago
There is a newer version of this series
.../bindings/reset/eswin,eic7700-reset.yaml   |  42 ++
drivers/reset/Kconfig                         |  10 +
drivers/reset/Makefile                        |   1 +
drivers/reset/reset-eic7700.c                 | 243 +++++++++
.../dt-bindings/reset/eswin,eic7700-reset.h   | 460 ++++++++++++++++++
5 files changed, 756 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reset/eswin,eic7700-reset.yaml
create mode 100644 drivers/reset/reset-eic7700.c
create mode 100644 include/dt-bindings/reset/eswin,eic7700-reset.h
[PATCH v3 0/2] Add driver support for ESWIN eic7700 SoC reset controller
Posted by dongxuyang@eswincomputing.com 3 months, 3 weeks ago
From: Xuyang Dong <dongxuyang@eswincomputing.com>

There are some register offsets in reset dt-bindings. It could be used.
Therefore, we want to keep these bindings. I don't known if it meets
the requirements.

PIPE_RST_CTRL, TBU_RST_CTRL and TEST_RST_CTRL are not used in this
driver. Therefore, these are left out.

Updates:

  dt-bindings: reset: eswin: Documentation for eic7700 SoC
  v2 -> v3:
    1. Drop syscon and simple-mfd from yaml and code, because these are
       not necessary.
    2. Update description to introduce reset controller.
    3. Add reset control indices for dt-bindings.
    4. Keep the register offsets in dt-bindings.

  v1 -> v2:
    1. Clear warnings/errors for using "make dt_binding_check".
    2. Update example, change parent node from sys-crg to reset-controller
       for reset yaml.
    3. Drop the child node and add '#reset-cells' to the parent node.
    4. Drop the description, because sys-crg block is changed to reset-
       controller.
    5. Change hex numbers to decimal numbers going from 0, and drop the
       not needed hardware numbers.

  reset: eswin: Add eic7700 reset driver
  v2 -> v3:
    1. Change syscon_node_to_regmap() to MMIO regmap functions, because
       droped syscon.
    2. Add BIT() in function eswin_reset_set() to shift the reset
       control indices.
    3. Remove forced type conversions from function eswin_reset_of_
       xlate_lookup_id().

  v1 -> v2:
    1. Modify the code according to the suggestions.
    2. Use eswin_reset_assert() and eswin_reset_deassert in function
       eswin_reset_reset().
    3. Place RESET_EIC7700 in Kconfig and Makefile in order.
    4. Use dev_err_probe() in probe function.

Xuyang Dong (2):
  dt-bindings: reset: eswin: Documentation for eic7700 SoC
  reset: eswin: Add eic7700 reset driver

 .../bindings/reset/eswin,eic7700-reset.yaml   |  42 ++
 drivers/reset/Kconfig                         |  10 +
 drivers/reset/Makefile                        |   1 +
 drivers/reset/reset-eic7700.c                 | 243 +++++++++
 .../dt-bindings/reset/eswin,eic7700-reset.h   | 460 ++++++++++++++++++
 5 files changed, 756 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/reset/eswin,eic7700-reset.yaml
 create mode 100644 drivers/reset/reset-eic7700.c
 create mode 100644 include/dt-bindings/reset/eswin,eic7700-reset.h

--
2.17.1
Re: [PATCH v3 0/2] Add driver support for ESWIN eic7700 SoC reset controller
Posted by Krzysztof Kozlowski 3 months, 3 weeks ago
On 19/06/2025 09:58, dongxuyang@eswincomputing.com wrote:
> From: Xuyang Dong <dongxuyang@eswincomputing.com>
> 
> There are some register offsets in reset dt-bindings. It could be used.
> Therefore, we want to keep these bindings. I don't known if it meets
> the requirements.
> 
> PIPE_RST_CTRL, TBU_RST_CTRL and TEST_RST_CTRL are not used in this
> driver. Therefore, these are left out.
> 
> Updates:
> 
>   dt-bindings: reset: eswin: Documentation for eic7700 SoC
>   v2 -> v3:
>     1. Drop syscon and simple-mfd from yaml and code, because these are
>        not necessary.
>     2. Update description to introduce reset controller.
>     3. Add reset control indices for dt-bindings.
>     4. Keep the register offsets in dt-bindings.

No, drop. Register offsets are not bindings. That was last comment, so
don't keep them. Remove them.


Best regards,
Krzysztof