drivers/iio/adc/ad7380.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Change the data type of the "adi,gain-milli" property from u32 to u16.
The devicetree binding specifies it as uint16, so we need to read it as
such to avoid an -EOVERFLOW error when parsing the property.
Fixes: c904e6dcf402 ("iio: adc: ad7380: add support for adaq4370-4 and adaq4380-4")
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
drivers/iio/adc/ad7380.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/ad7380.c b/drivers/iio/adc/ad7380.c
index aef85093eb16cbe9cc062f8cb4239e955c8a21b6..fd17e28e279191c2603537a9bddc7eb9976c144c 100644
--- a/drivers/iio/adc/ad7380.c
+++ b/drivers/iio/adc/ad7380.c
@@ -1920,8 +1920,9 @@ static int ad7380_probe(struct spi_device *spi)
if (st->chip_info->has_hardware_gain) {
device_for_each_child_node_scoped(dev, node) {
- unsigned int channel, gain;
+ unsigned int channel;
int gain_idx;
+ u16 gain;
ret = fwnode_property_read_u32(node, "reg", &channel);
if (ret)
@@ -1933,7 +1934,7 @@ static int ad7380_probe(struct spi_device *spi)
"Invalid channel number %i\n",
channel);
- ret = fwnode_property_read_u32(node, "adi,gain-milli",
+ ret = fwnode_property_read_u16(node, "adi,gain-milli",
&gain);
if (ret && ret != -EINVAL)
return dev_err_probe(dev, ret,
---
base-commit: a3245ebdfac846ce0b563a3ed474be2e15381f9f
change-id: 20250619-iio-adc-ad7380-fix-adi-gain-milli-parsing-8df01280f493
Best regards,
--
David Lechner <dlechner@baylibre.com>
On Thu, 19 Jun 2025 10:24:22 -0500 David Lechner <dlechner@baylibre.com> wrote: > Change the data type of the "adi,gain-milli" property from u32 to u16. > The devicetree binding specifies it as uint16, so we need to read it as > such to avoid an -EOVERFLOW error when parsing the property. > > Fixes: c904e6dcf402 ("iio: adc: ad7380: add support for adaq4370-4 and adaq4380-4") > Signed-off-by: David Lechner <dlechner@baylibre.com> Applied to the fixes-togreg branch of iio.git and marked for stable. Thanks, J > --- > drivers/iio/adc/ad7380.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/ad7380.c b/drivers/iio/adc/ad7380.c > index aef85093eb16cbe9cc062f8cb4239e955c8a21b6..fd17e28e279191c2603537a9bddc7eb9976c144c 100644 > --- a/drivers/iio/adc/ad7380.c > +++ b/drivers/iio/adc/ad7380.c > @@ -1920,8 +1920,9 @@ static int ad7380_probe(struct spi_device *spi) > > if (st->chip_info->has_hardware_gain) { > device_for_each_child_node_scoped(dev, node) { > - unsigned int channel, gain; > + unsigned int channel; > int gain_idx; > + u16 gain; > > ret = fwnode_property_read_u32(node, "reg", &channel); > if (ret) > @@ -1933,7 +1934,7 @@ static int ad7380_probe(struct spi_device *spi) > "Invalid channel number %i\n", > channel); > > - ret = fwnode_property_read_u32(node, "adi,gain-milli", > + ret = fwnode_property_read_u16(node, "adi,gain-milli", > &gain); > if (ret && ret != -EINVAL) > return dev_err_probe(dev, ret, > > --- > base-commit: a3245ebdfac846ce0b563a3ed474be2e15381f9f > change-id: 20250619-iio-adc-ad7380-fix-adi-gain-milli-parsing-8df01280f493 > > Best regards,
On Sun, Jun 22, 2025 at 8:25 AM Jonathan Cameron <jic23@kernel.org> wrote: > > On Thu, 19 Jun 2025 10:24:22 -0500 > David Lechner <dlechner@baylibre.com> wrote: > > > Change the data type of the "adi,gain-milli" property from u32 to u16. > > The devicetree binding specifies it as uint16, so we need to read it as > > such to avoid an -EOVERFLOW error when parsing the property. > > > > Fixes: c904e6dcf402 ("iio: adc: ad7380: add support for adaq4370-4 and adaq4380-4") > > Signed-off-by: David Lechner <dlechner@baylibre.com> > Applied to the fixes-togreg branch of iio.git and marked for stable. > Hmm... looks like this branch hasn't been pushed to kernel.org for a while.
© 2016 - 2025 Red Hat, Inc.