[v2] USB: serial: use new GPIO line value setter callbacks

[PATCH v2 0/2] USB: serial: use new GPIO line value setter callbacks

Posted by Bartosz Golaszewski 3 months, 3 weeks ago

Commit 98ce1eb1fd87e ("gpiolib: introduce gpio_chip setters that return
values") added new line setter callbacks to struct gpio_chip. They allow
to indicate failures to callers. We're in the process of converting all
GPIO controllers to using them before removing the old ones. This series
converts all GPIO chips implemented under drivers/usb/serial/.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Changes in v2:
- reduce the number of changes in patch 2/2 by simply changing the
  function prototype and returning a value without reshuffling the
  implementation (Johan)
- Link to v1: https://lore.kernel.org/r/20250610-gpiochip-set-rv-usb-serial-v1-0-a9343ca109e8@linaro.org

---
Bartosz Golaszewski (2):
      USB: serial: ftdi_sio: use new GPIO line value setter callbacks
      USB: serial: cp210x: use new GPIO line value setter callbacks

 drivers/usb/serial/cp210x.c   | 10 ++++++----
 drivers/usb/serial/ftdi_sio.c | 18 ++++++++++++------
 2 files changed, 18 insertions(+), 10 deletions(-)
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250523-gpiochip-set-rv-usb-serial-4f4d4cc2d5ef

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH v2 0/2] USB: serial: use new GPIO line value setter callbacks

Posted by Johan Hovold 3 months, 2 weeks ago

On Thu, Jun 19, 2025 at 11:02:39AM +0200, Bartosz Golaszewski wrote:
> Commit 98ce1eb1fd87e ("gpiolib: introduce gpio_chip setters that return
> values") added new line setter callbacks to struct gpio_chip. They allow
> to indicate failures to callers. We're in the process of converting all
> GPIO controllers to using them before removing the old ones. This series
> converts all GPIO chips implemented under drivers/usb/serial/.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Changes in v2:
> - reduce the number of changes in patch 2/2 by simply changing the
>   function prototype and returning a value without reshuffling the
>   implementation (Johan)
> - Link to v1: https://lore.kernel.org/r/20250610-gpiochip-set-rv-usb-serial-v1-0-a9343ca109e8@linaro.org

Thanks for respinning, now applied.

Johan