[PATCH] scripts/gdb: fix mount flags for lx-symbols

Daniel Gomez posted 1 patch 3 months, 3 weeks ago
scripts/gdb/linux/constants.py.in | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
[PATCH] scripts/gdb: fix mount flags for lx-symbols
Posted by Daniel Gomez 3 months, 3 weeks ago
From: Daniel Gomez <da.gomez@samsung.com>

mount flags have been converted to enum making lx-symbols not able to
find them when debugging. Use the appropriate LX_GDBPARSED macro for the
new enum.

Error:
Reading symbols from vmlinux...
Python Exception <class 'NameError'>: name 'MNT_NOSUID' is not defined

Fixes: 101f2bbab541 ("fs: convert mount flags to enum")

Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
 scripts/gdb/linux/constants.py.in | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
index fd6bd69c5096ac540efb93979d5eb03cb410deb5..d5e3069f42a7c0e07c4a79eeee5ca1842e6ebf86 100644
--- a/scripts/gdb/linux/constants.py.in
+++ b/scripts/gdb/linux/constants.py.in
@@ -73,12 +73,12 @@ if IS_BUILTIN(CONFIG_MODULES):
     LX_GDBPARSED(MOD_RO_AFTER_INIT)
 
 /* linux/mount.h */
-LX_VALUE(MNT_NOSUID)
-LX_VALUE(MNT_NODEV)
-LX_VALUE(MNT_NOEXEC)
-LX_VALUE(MNT_NOATIME)
-LX_VALUE(MNT_NODIRATIME)
-LX_VALUE(MNT_RELATIME)
+LX_GDBPARSED(MNT_NOSUID)
+LX_GDBPARSED(MNT_NODEV)
+LX_GDBPARSED(MNT_NOEXEC)
+LX_GDBPARSED(MNT_NOATIME)
+LX_GDBPARSED(MNT_NODIRATIME)
+LX_GDBPARSED(MNT_RELATIME)
 
 /* linux/threads.h */
 LX_VALUE(NR_CPUS)

---
base-commit: 6e5ab6fee68df8c40b338baeae6e269fa25a7e25
change-id: 20250617-fix-gdb-lx-mnt-d6d5dfe76828

Best regards,
-- 
Daniel Gomez <da.gomez@samsung.com>
Re: [PATCH] scripts/gdb: fix mount flags for lx-symbols
Posted by Brendan Jackman 3 months, 1 week ago
> Fixes: 101f2bbab541 ("fs: convert mount flags to enum")

Thanks for this!

Tested-by: Brendan Jackman <jackmanb@google.com>
Re: [PATCH] scripts/gdb: fix mount flags for lx-symbols
Posted by Daniel Gomez 3 months, 1 week ago

On 27/06/2025 12.17, Brendan Jackman wrote:
>> Fixes: 101f2bbab541 ("fs: convert mount flags to enum")
> 
> Thanks for this!
> 
> Tested-by: Brendan Jackman <jackmanb@google.com>
My patch is a duplicate of this:
https://lore.kernel.org/all/20250618134629.25700-2-johannes@sipsolutions.net/T/#u

Already in linux-next with commit id a333d056e276 ("scripts: gdb: move MNT_*
constants to gdb-parsed").

And here another duplicate:
https://lore.kernel.org/all/20250601055027.3661480-1-tony.ambardar@gmail.com/

Sorry for the confusion and extra noise.