scripts: gdb: move MNT_* constants to gdb-parsed

[PATCH] scripts: gdb: move MNT_* constants to gdb-parsed

Posted by Johannes Berg 7 months, 3 weeks ago

From: Johannes Berg <johannes.berg@intel.com>

Since these are now no longer defines, but in an enum.

Fixes: 101f2bbab541 ("fs: convert mount flags to enum")
Reviewed-by: Benjamin Berg <benjamin.berg@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
 scripts/gdb/linux/constants.py.in | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
index fd6bd69c5096..d5e3069f42a7 100644
--- a/scripts/gdb/linux/constants.py.in
+++ b/scripts/gdb/linux/constants.py.in
@@ -73,12 +73,12 @@ if IS_BUILTIN(CONFIG_MODULES):
     LX_GDBPARSED(MOD_RO_AFTER_INIT)
 
 /* linux/mount.h */
-LX_VALUE(MNT_NOSUID)
-LX_VALUE(MNT_NODEV)
-LX_VALUE(MNT_NOEXEC)
-LX_VALUE(MNT_NOATIME)
-LX_VALUE(MNT_NODIRATIME)
-LX_VALUE(MNT_RELATIME)
+LX_GDBPARSED(MNT_NOSUID)
+LX_GDBPARSED(MNT_NODEV)
+LX_GDBPARSED(MNT_NOEXEC)
+LX_GDBPARSED(MNT_NOATIME)
+LX_GDBPARSED(MNT_NODIRATIME)
+LX_GDBPARSED(MNT_RELATIME)
 
 /* linux/threads.h */
 LX_VALUE(NR_CPUS)
-- 
2.49.0

Re: [PATCH] scripts: gdb: move MNT_* constants to gdb-parsed

Posted by Stephen Brennan 7 months, 3 weeks ago

On 6/18/25 06:46, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> Since these are now no longer defines, but in an enum.
> 
> Fixes: 101f2bbab541 ("fs: convert mount flags to enum")
> Reviewed-by: Benjamin Berg <benjamin.berg@intel.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

The exact same change was already submitted and discussed here:

https://lore.kernel.org/all/20250601055027.3661480-1-tony.ambardar@gmail.com/

I don't know what tree this would go through, so I can't tell whether it
was picked up or not. But I think there's consensus that it's a good
fix, and several folks have written or reviewed the change.

Thanks,
Stephen

> ---
>  scripts/gdb/linux/constants.py.in | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
> index fd6bd69c5096..d5e3069f42a7 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -73,12 +73,12 @@ if IS_BUILTIN(CONFIG_MODULES):
>      LX_GDBPARSED(MOD_RO_AFTER_INIT)
>  
>  /* linux/mount.h */
> -LX_VALUE(MNT_NOSUID)
> -LX_VALUE(MNT_NODEV)
> -LX_VALUE(MNT_NOEXEC)
> -LX_VALUE(MNT_NOATIME)
> -LX_VALUE(MNT_NODIRATIME)
> -LX_VALUE(MNT_RELATIME)
> +LX_GDBPARSED(MNT_NOSUID)
> +LX_GDBPARSED(MNT_NODEV)
> +LX_GDBPARSED(MNT_NOEXEC)
> +LX_GDBPARSED(MNT_NOATIME)
> +LX_GDBPARSED(MNT_NODIRATIME)
> +LX_GDBPARSED(MNT_RELATIME)
>  
>  /* linux/threads.h */
>  LX_VALUE(NR_CPUS)

Re: [PATCH] scripts: gdb: move MNT_* constants to gdb-parsed

Posted by Johannes Berg 7 months, 3 weeks ago

On Wed, 2025-06-18 at 14:06 -0700, Stephen Brennan wrote:
> On 6/18/25 06:46, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> > 
> > Since these are now no longer defines, but in an enum.
> > 
> > Fixes: 101f2bbab541 ("fs: convert mount flags to enum")
> > Reviewed-by: Benjamin Berg <benjamin.berg@intel.com>
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> 
> The exact same change was already submitted and discussed here:
> 
> https://lore.kernel.org/all/20250601055027.3661480-1-tony.ambardar@gmail.com/

Oh, I missed that, sorry.

> I don't know what tree this would go through, so I can't tell whether it
> was picked up or not. But I think there's consensus that it's a good
> fix, and several folks have written or reviewed the change.

It looks like previously Andrew picked up patches to this which is why I
Cc'ed him, but I'm perfectly happy for that other patch (or mine) to
take any path available :)

johannes