rust/kernel/clk.rs | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
Replaces repeated numeric literals in `Hertz` conversions
with named constants.
Signed-off-by: Onur Özkan <work@onurozkan.dev>
---
rust/kernel/clk.rs | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/rust/kernel/clk.rs b/rust/kernel/clk.rs
index 6041c6d07527..b8c5dafdc29c 100644
--- a/rust/kernel/clk.rs
+++ b/rust/kernel/clk.rs
@@ -30,19 +30,23 @@
pub struct Hertz(pub c_ulong);
impl Hertz {
+ const KHZ_TO_HZ: c_ulong = 1_000;
+ const MHZ_TO_HZ: c_ulong = 1_000_000;
+ const GHZ_TO_HZ: c_ulong = 1_000_000_000;
+
/// Create a new instance from kilohertz (kHz)
pub fn from_khz(khz: c_ulong) -> Self {
- Self(khz * 1_000)
+ Self(khz * Self::KHZ_TO_HZ)
}
/// Create a new instance from megahertz (MHz)
pub fn from_mhz(mhz: c_ulong) -> Self {
- Self(mhz * 1_000_000)
+ Self(mhz * Self::MHZ_TO_HZ)
}
/// Create a new instance from gigahertz (GHz)
pub fn from_ghz(ghz: c_ulong) -> Self {
- Self(ghz * 1_000_000_000)
+ Self(ghz * Self::GHZ_TO_HZ)
}
/// Get the frequency in hertz
@@ -52,17 +56,17 @@ pub fn as_hz(&self) -> c_ulong {
/// Get the frequency in kilohertz
pub fn as_khz(&self) -> c_ulong {
- self.0 / 1_000
+ self.0 / Self::KHZ_TO_HZ
}
/// Get the frequency in megahertz
pub fn as_mhz(&self) -> c_ulong {
- self.0 / 1_000_000
+ self.0 / Self::MHZ_TO_HZ
}
/// Get the frequency in gigahertz
pub fn as_ghz(&self) -> c_ulong {
- self.0 / 1_000_000_000
+ self.0 / Self::GHZ_TO_HZ
}
}
2.49.0
Quoting Onur Özkan (2025-06-18 02:28:10) > Replaces repeated numeric literals in `Hertz` conversions > with named constants. > > Signed-off-by: Onur Özkan <work@onurozkan.dev> > --- Applied to clk-next
On Wed Jun 18, 2025 at 6:28 PM JST, Onur Özkan wrote: > Replaces repeated numeric literals in `Hertz` conversions > with named constants. > > Signed-off-by: Onur Özkan <work@onurozkan.dev> FWIW, Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
On Wed, Jun 18, 2025 at 3:07 PM Onur Özkan <work@onurozkan.dev> wrote: > > Replaces repeated numeric literals in `Hertz` conversions > with named constants. > > Signed-off-by: Onur Özkan <work@onurozkan.dev> > --- > rust/kernel/clk.rs | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
© 2016 - 2025 Red Hat, Inc.