gpio: fix NULL-pointer dereferences introduced in GPIO chip setter conversion

[PATCH 0/2] gpio: fix NULL-pointer dereferences introduced in GPIO chip setter conversion

Posted by Bartosz Golaszewski 3 months, 3 weeks ago

I should have paid more attention when doing the GPIO chip setter
conversions that there are instances where the setters are accessed
directly using the function pointers in struct gpio_chip.

This is not optimal and I am making a mental note to track all such
use-cases and use the appropriate wrapper instead. For now: let's just
fix the issue in gpio-mmio and its users as well as one other converted
driver that suffers from it.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Bartosz Golaszewski (2):
      gpio: npcm-sgpio: don't use legacy GPIO chip setters
      gpio: mmio: don't use legacy GPIO chip setters

 drivers/gpio/gpio-74xx-mmio.c  | 2 +-
 drivers/gpio/gpio-en7523.c     | 2 +-
 drivers/gpio/gpio-mmio.c       | 6 +++---
 drivers/gpio/gpio-npcm-sgpio.c | 4 +---
 4 files changed, 6 insertions(+), 8 deletions(-)
---
base-commit: 7b20980ffc11514d8849811857d915001236bcfa
change-id: 20250618-gpio-mmio-fix-setter-ddd4dd7a03eb

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH 0/2] gpio: fix NULL-pointer dereferences introduced in GPIO chip setter conversion

Posted by Bartosz Golaszewski 3 months, 3 weeks ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Wed, 18 Jun 2025 15:02:05 +0200, Bartosz Golaszewski wrote:
> I should have paid more attention when doing the GPIO chip setter
> conversions that there are instances where the setters are accessed
> directly using the function pointers in struct gpio_chip.
> 
> This is not optimal and I am making a mental note to track all such
> use-cases and use the appropriate wrapper instead. For now: let's just
> fix the issue in gpio-mmio and its users as well as one other converted
> driver that suffers from it.
> 
> [...]

Applied, thanks!

[1/2] gpio: npcm-sgpio: don't use legacy GPIO chip setters
      https://git.kernel.org/brgl/linux/c/1fd7d210952938e8ef6d87287e056e25a2fc0547
[2/2] gpio: mmio: don't use legacy GPIO chip setters
      https://git.kernel.org/brgl/linux/c/cbb887a76b788d8e9646fdd785f43745a3a662bb

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>