The MIPI panel definition in the PinePhone Pro DTS includes a
"pinctrl-names" property, which is unused in the absence of pinctrl-0.

Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
index 5a7341fb6bcb0613af6f3ac31d99355a0f890e89..405140700208365c8631de86a2d7b6e577b7aa7f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
@@ -485,7 +485,6 @@ panel@0 {
 		reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>;
 		vcc-supply = <&vcc2v8_lcd>;
 		iovcc-supply = <&vcc1v8_lcd>;
-		pinctrl-names = "default";
 
 		port {
 			mipi_in_panel: endpoint {

-- 
2.49.0

Hi,

On Wed Jun 18, 2025 at 12:32 AM CEST, Olivier Benjamin wrote:
> The MIPI panel definition in the PinePhone Pro DTS includes a
> "pinctrl-names" property, which is unused in the absence of pinctrl-0.
>
> Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> index 5a7341fb6bcb0613af6f3ac31d99355a0f890e89..405140700208365c8631de86a2d7b6e577b7aa7f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> @@ -485,7 +485,6 @@ panel@0 {
>  		reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>;
>  		vcc-supply = <&vcc2v8_lcd>;
>  		iovcc-supply = <&vcc1v8_lcd>;
> -		pinctrl-names = "default";

Why not define a pinctrl for LCD1_RST for GPIO4_D1 and reference that in
pinctrl-0? (See page 11 and 16 of the schematics)

Cheers,
  Diederik
>  
>  		port {
>  			mipi_in_panel: endpoint {

On 6/18/25 14:12, Diederik de Haas wrote:
> Hi,
> 
Hello Diederik,

> On Wed Jun 18, 2025 at 12:32 AM CEST, Olivier Benjamin wrote:
>> The MIPI panel definition in the PinePhone Pro DTS includes a
>> "pinctrl-names" property, which is unused in the absence of pinctrl-0.
>>
>> Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
>> index 5a7341fb6bcb0613af6f3ac31d99355a0f890e89..405140700208365c8631de86a2d7b6e577b7aa7f 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
>> @@ -485,7 +485,6 @@ panel@0 {
>>   		reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>;
>>   		vcc-supply = <&vcc2v8_lcd>;
>>   		iovcc-supply = <&vcc1v8_lcd>;
>> -		pinctrl-names = "default";
> 
> Why not define a pinctrl for LCD1_RST for GPIO4_D1 and reference that in
> pinctrl-0? (See page 11 and 16 of the schematics)
> 
That is a very fair question. I had simply missed that signal.
I'll get right on that, thanks for the suggestion!
> Cheers,
>    Diederik
>>   
>>   		port {
>>   			mipi_in_panel: endpoint {
> 

-- 
Olivier Benjamin, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com