phy: qcom: m31-eusb2: drop registration printk

[PATCH] phy: qcom: m31-eusb2: drop registration printk

Posted by Johan Hovold 3 months, 3 weeks ago

Drivers should generally be quiet on successful probe so drop the
registration printk from the recently added M31 EUSB2 driver.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
index 9f02b8a78f6e..9b987911fcdb 100644
--- a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
@@ -288,8 +288,6 @@ static int m31eusb2_phy_probe(struct platform_device *pdev)
 				     "failed to get repeater\n");
 
 	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
-	if (!IS_ERR(phy_provider))
-		dev_info(dev, "Registered M31 USB phy\n");
 
 	return PTR_ERR_OR_ZERO(phy_provider);
 }
-- 
2.49.0

Re: [PATCH] phy: qcom: m31-eusb2: drop registration printk

Posted by Vinod Koul 3 months, 2 weeks ago

On Tue, 17 Jun 2025 10:04:01 +0200, Johan Hovold wrote:
> Drivers should generally be quiet on successful probe so drop the
> registration printk from the recently added M31 EUSB2 driver.
> 
> 

Applied, thanks!

[1/1] phy: qcom: m31-eusb2: drop registration printk
      commit: 2bff9083c1744dc8751ddc0844a65e3bee89f519

Best regards,
-- 
~Vinod

Re: [PATCH] phy: qcom: m31-eusb2: drop registration printk

Posted by neil.armstrong@linaro.org 3 months, 3 weeks ago

On 17/06/2025 10:04, Johan Hovold wrote:
> Drivers should generally be quiet on successful probe so drop the
> registration printk from the recently added M31 EUSB2 driver.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>   drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> index 9f02b8a78f6e..9b987911fcdb 100644
> --- a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> @@ -288,8 +288,6 @@ static int m31eusb2_phy_probe(struct platform_device *pdev)
>   				     "failed to get repeater\n");
>   
>   	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> -	if (!IS_ERR(phy_provider))
> -		dev_info(dev, "Registered M31 USB phy\n");
>   
>   	return PTR_ERR_OR_ZERO(phy_provider);
>   }

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>