[PATCH] phy: qcom: add linux/bitfield.h header to fix a build error

Randy Dunlap posted 1 patch 3 months, 3 weeks ago
drivers/phy/qualcomm/phy-qcom-m31-eusb2.c |    1 +
1 file changed, 1 insertion(+)
[PATCH] phy: qcom: add linux/bitfield.h header to fix a build error
Posted by Randy Dunlap 3 months, 3 weeks ago
Add the <linux/bitfield.h> header to prevent a build error:

drivers/phy/qualcomm/phy-qcom-m31-eusb2.c: In function 'm31eusb2_phy_init':
drivers/phy/qualcomm/phy-qcom-m31-eusb2.c:210:37: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
  210 |                                     FIELD_PREP(FSEL, data->fsel));

Fixes: 9c8504861cc4 ("phy: qcom: Add M31 based eUSB2 PHY driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Wesley Cheng <quic_wcheng@quicinc.com>
Cc: Melody Olvera <melody.olvera@oss.qualcomm.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@kernel.org>
Cc: linux-phy@lists.infradead.org
Cc: linux-arm-msm@vger.kernel.org
---
 drivers/phy/qualcomm/phy-qcom-m31-eusb2.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20250616.orig/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
+++ linux-next-20250616/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
@@ -3,6 +3,7 @@
  * Copyright (c) 2024-2025 Qualcomm Innovation Center, Inc. All rights reserved.
  */
 
+#include <linux/bitfield.h>
 #include <linux/clk.h>
 #include <linux/delay.h>
 #include <linux/err.h>
Re: [PATCH] phy: qcom: add linux/bitfield.h header to fix a build error
Posted by Vinod Koul 3 months, 3 weeks ago
On Mon, 16 Jun 2025 20:42:49 -0700, Randy Dunlap wrote:
> Add the <linux/bitfield.h> header to prevent a build error:
> 
> drivers/phy/qualcomm/phy-qcom-m31-eusb2.c: In function 'm31eusb2_phy_init':
> drivers/phy/qualcomm/phy-qcom-m31-eusb2.c:210:37: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
>   210 |                                     FIELD_PREP(FSEL, data->fsel));
> 
> 
> [...]

Applied, thanks!

[1/1] phy: qcom: add linux/bitfield.h header to fix a build error
      commit: f0185cd5942569ea9872bf85dce621d0a7fa401e

Best regards,
-- 
~Vinod