NSS clock controller provides the clocks and resets to the
networking blocks such as PPE (Packet Process Engine) and
UNIPHY (PCS) on IPQ5424 devices.
Add the compatible "qcom,ipq5424-nsscc" support based on the
current IPQ9574 NSS clock controller DT binding file.
ICC clocks are always provided by the NSS clock controller
of IPQ9574 and IPQ5424, so add interconnect-cells as required
DT property.
Also add master/slave ids for IPQ5424 networking interfaces,
which is used by nss-ipq5424 driver for providing interconnect
services using icc-clk framework.
Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
---
.../bindings/clock/qcom,ipq9574-nsscc.yaml | 66 +++++++++++++++++++---
include/dt-bindings/clock/qcom,ipq5424-nsscc.h | 65 +++++++++++++++++++++
include/dt-bindings/interconnect/qcom,ipq5424.h | 13 +++++
include/dt-bindings/reset/qcom,ipq5424-nsscc.h | 46 +++++++++++++++
4 files changed, 182 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
index 17252b6ea3be..5bc2fe049b26 100644
--- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
@@ -4,7 +4,7 @@
$id: http://devicetree.org/schemas/clock/qcom,ipq9574-nsscc.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Qualcomm Networking Sub System Clock & Reset Controller on IPQ9574
+title: Qualcomm Networking Sub System Clock & Reset Controller on IPQ9574 and IPQ5424
maintainers:
- Bjorn Andersson <andersson@kernel.org>
@@ -12,21 +12,25 @@ maintainers:
description: |
Qualcomm networking sub system clock control module provides the clocks,
- resets on IPQ9574
+ resets on IPQ9574 and IPQ5424
- See also::
+ See also:
+ include/dt-bindings/clock/qcom,ipq5424-nsscc.h
include/dt-bindings/clock/qcom,ipq9574-nsscc.h
+ include/dt-bindings/reset/qcom,ipq5424-nsscc.h
include/dt-bindings/reset/qcom,ipq9574-nsscc.h
properties:
compatible:
- const: qcom,ipq9574-nsscc
+ enum:
+ - qcom,ipq5424-nsscc
+ - qcom,ipq9574-nsscc
clocks:
items:
- description: Board XO source
- - description: CMN_PLL NSS 1200MHz (Bias PLL cc) clock source
- - description: CMN_PLL PPE 353MHz (Bias PLL ubi nc) clock source
+ - description: CMN_PLL NSS 1200 MHz or 300 MHZ (Bias PLL cc) clock source
+ - description: CMN_PLL PPE 353 MHz or 375 MHZ (Bias PLL ubi nc) clock source
- description: GCC GPLL0 OUT AUX clock source
- description: Uniphy0 NSS Rx clock source
- description: Uniphy0 NSS Tx clock source
@@ -42,8 +46,12 @@ properties:
clock-names:
items:
- const: xo
- - const: nss_1200
- - const: ppe_353
+ - enum:
+ - nss_1200
+ - nss_300
+ - enum:
+ - ppe_353
+ - ppe_375
- const: gpll0_out
- const: uniphy0_rx
- const: uniphy0_tx
@@ -57,9 +65,50 @@ required:
- compatible
- clocks
- clock-names
+ - '#interconnect-cells'
allOf:
- $ref: qcom,gcc.yaml#
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,ipq9574-nsscc
+ then:
+ properties:
+ clock-names:
+ items:
+ - const: xo
+ - const: nss_1200
+ - const: ppe_353
+ - const: gpll0_out
+ - const: uniphy0_rx
+ - const: uniphy0_tx
+ - const: uniphy1_rx
+ - const: uniphy1_tx
+ - const: uniphy2_rx
+ - const: uniphy2_tx
+ - const: bus
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,ipq5424-nsscc
+ then:
+ properties:
+ clock-names:
+ items:
+ - const: xo
+ - const: nss_300
+ - const: ppe_375
+ - const: gpll0_out
+ - const: uniphy0_rx
+ - const: uniphy0_tx
+ - const: uniphy1_rx
+ - const: uniphy1_tx
+ - const: uniphy2_rx
+ - const: uniphy2_tx
+ - const: bus
unevaluatedProperties: false
@@ -94,5 +143,6 @@ examples:
"bus";
#clock-cells = <1>;
#reset-cells = <1>;
+ #interconnect-cells = <1>;
};
...
diff --git a/include/dt-bindings/clock/qcom,ipq5424-nsscc.h b/include/dt-bindings/clock/qcom,ipq5424-nsscc.h
new file mode 100644
index 000000000000..59ce056ead93
--- /dev/null
+++ b/include/dt-bindings/clock/qcom,ipq5424-nsscc.h
@@ -0,0 +1,65 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (c) 2025, Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#ifndef _DT_BINDINGS_CLOCK_QCOM_IPQ5424_NSSCC_H
+#define _DT_BINDINGS_CLOCK_QCOM_IPQ5424_NSSCC_H
+
+/* NSS_CC clocks */
+#define NSS_CC_CE_APB_CLK 0
+#define NSS_CC_CE_AXI_CLK 1
+#define NSS_CC_CE_CLK_SRC 2
+#define NSS_CC_CFG_CLK_SRC 3
+#define NSS_CC_DEBUG_CLK 4
+#define NSS_CC_EIP_BFDCD_CLK_SRC 5
+#define NSS_CC_EIP_CLK 6
+#define NSS_CC_NSS_CSR_CLK 7
+#define NSS_CC_NSSNOC_CE_APB_CLK 8
+#define NSS_CC_NSSNOC_CE_AXI_CLK 9
+#define NSS_CC_NSSNOC_EIP_CLK 10
+#define NSS_CC_NSSNOC_NSS_CSR_CLK 11
+#define NSS_CC_NSSNOC_PPE_CFG_CLK 12
+#define NSS_CC_NSSNOC_PPE_CLK 13
+#define NSS_CC_PORT1_MAC_CLK 14
+#define NSS_CC_PORT1_RX_CLK 15
+#define NSS_CC_PORT1_RX_CLK_SRC 16
+#define NSS_CC_PORT1_RX_DIV_CLK_SRC 17
+#define NSS_CC_PORT1_TX_CLK 18
+#define NSS_CC_PORT1_TX_CLK_SRC 19
+#define NSS_CC_PORT1_TX_DIV_CLK_SRC 20
+#define NSS_CC_PORT2_MAC_CLK 21
+#define NSS_CC_PORT2_RX_CLK 22
+#define NSS_CC_PORT2_RX_CLK_SRC 23
+#define NSS_CC_PORT2_RX_DIV_CLK_SRC 24
+#define NSS_CC_PORT2_TX_CLK 25
+#define NSS_CC_PORT2_TX_CLK_SRC 26
+#define NSS_CC_PORT2_TX_DIV_CLK_SRC 27
+#define NSS_CC_PORT3_MAC_CLK 28
+#define NSS_CC_PORT3_RX_CLK 29
+#define NSS_CC_PORT3_RX_CLK_SRC 30
+#define NSS_CC_PORT3_RX_DIV_CLK_SRC 31
+#define NSS_CC_PORT3_TX_CLK 32
+#define NSS_CC_PORT3_TX_CLK_SRC 33
+#define NSS_CC_PORT3_TX_DIV_CLK_SRC 34
+#define NSS_CC_PPE_CLK_SRC 35
+#define NSS_CC_PPE_EDMA_CFG_CLK 36
+#define NSS_CC_PPE_EDMA_CLK 37
+#define NSS_CC_PPE_SWITCH_BTQ_CLK 38
+#define NSS_CC_PPE_SWITCH_CFG_CLK 39
+#define NSS_CC_PPE_SWITCH_CLK 40
+#define NSS_CC_PPE_SWITCH_IPE_CLK 41
+#define NSS_CC_UNIPHY_PORT1_RX_CLK 42
+#define NSS_CC_UNIPHY_PORT1_TX_CLK 43
+#define NSS_CC_UNIPHY_PORT2_RX_CLK 44
+#define NSS_CC_UNIPHY_PORT2_TX_CLK 45
+#define NSS_CC_UNIPHY_PORT3_RX_CLK 46
+#define NSS_CC_UNIPHY_PORT3_TX_CLK 47
+#define NSS_CC_XGMAC0_PTP_REF_CLK 48
+#define NSS_CC_XGMAC0_PTP_REF_DIV_CLK_SRC 49
+#define NSS_CC_XGMAC1_PTP_REF_CLK 50
+#define NSS_CC_XGMAC1_PTP_REF_DIV_CLK_SRC 51
+#define NSS_CC_XGMAC2_PTP_REF_CLK 52
+#define NSS_CC_XGMAC2_PTP_REF_DIV_CLK_SRC 53
+
+#endif
diff --git a/include/dt-bindings/interconnect/qcom,ipq5424.h b/include/dt-bindings/interconnect/qcom,ipq5424.h
index 66cd9a9ece03..a78604beff99 100644
--- a/include/dt-bindings/interconnect/qcom,ipq5424.h
+++ b/include/dt-bindings/interconnect/qcom,ipq5424.h
@@ -27,4 +27,17 @@
#define MASTER_NSSNOC_SNOC_1 22
#define SLAVE_NSSNOC_SNOC_1 23
+#define MASTER_NSSNOC_PPE 0
+#define SLAVE_NSSNOC_PPE 1
+#define MASTER_NSSNOC_PPE_CFG 2
+#define SLAVE_NSSNOC_PPE_CFG 3
+#define MASTER_NSSNOC_NSS_CSR 4
+#define SLAVE_NSSNOC_NSS_CSR 5
+#define MASTER_NSSNOC_CE_AXI 6
+#define SLAVE_NSSNOC_CE_AXI 7
+#define MASTER_NSSNOC_CE_APB 8
+#define SLAVE_NSSNOC_CE_APB 9
+#define MASTER_NSSNOC_EIP 10
+#define SLAVE_NSSNOC_EIP 11
+
#endif /* INTERCONNECT_QCOM_IPQ5424_H */
diff --git a/include/dt-bindings/reset/qcom,ipq5424-nsscc.h b/include/dt-bindings/reset/qcom,ipq5424-nsscc.h
new file mode 100644
index 000000000000..f2f7eaa28b21
--- /dev/null
+++ b/include/dt-bindings/reset/qcom,ipq5424-nsscc.h
@@ -0,0 +1,46 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (c) 2025, Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#ifndef _DT_BINDINGS_RESET_QCOM_IPQ5424_NSSCC_H
+#define _DT_BINDINGS_RESET_QCOM_IPQ5424_NSSCC_H
+
+#define NSS_CC_CE_APB_CLK_ARES 0
+#define NSS_CC_CE_AXI_CLK_ARES 1
+#define NSS_CC_DEBUG_CLK_ARES 2
+#define NSS_CC_EIP_CLK_ARES 3
+#define NSS_CC_NSS_CSR_CLK_ARES 4
+#define NSS_CC_NSSNOC_CE_APB_CLK_ARES 5
+#define NSS_CC_NSSNOC_CE_AXI_CLK_ARES 6
+#define NSS_CC_NSSNOC_EIP_CLK_ARES 7
+#define NSS_CC_NSSNOC_NSS_CSR_CLK_ARES 8
+#define NSS_CC_NSSNOC_PPE_CLK_ARES 9
+#define NSS_CC_NSSNOC_PPE_CFG_CLK_ARES 10
+#define NSS_CC_PORT1_MAC_CLK_ARES 11
+#define NSS_CC_PORT1_RX_CLK_ARES 12
+#define NSS_CC_PORT1_TX_CLK_ARES 13
+#define NSS_CC_PORT2_MAC_CLK_ARES 14
+#define NSS_CC_PORT2_RX_CLK_ARES 15
+#define NSS_CC_PORT2_TX_CLK_ARES 16
+#define NSS_CC_PORT3_MAC_CLK_ARES 17
+#define NSS_CC_PORT3_RX_CLK_ARES 18
+#define NSS_CC_PORT3_TX_CLK_ARES 19
+#define NSS_CC_PPE_BCR 20
+#define NSS_CC_PPE_EDMA_CLK_ARES 21
+#define NSS_CC_PPE_EDMA_CFG_CLK_ARES 22
+#define NSS_CC_PPE_SWITCH_BTQ_CLK_ARES 23
+#define NSS_CC_PPE_SWITCH_CLK_ARES 24
+#define NSS_CC_PPE_SWITCH_CFG_CLK_ARES 25
+#define NSS_CC_PPE_SWITCH_IPE_CLK_ARES 26
+#define NSS_CC_UNIPHY_PORT1_RX_CLK_ARES 27
+#define NSS_CC_UNIPHY_PORT1_TX_CLK_ARES 28
+#define NSS_CC_UNIPHY_PORT2_RX_CLK_ARES 29
+#define NSS_CC_UNIPHY_PORT2_TX_CLK_ARES 30
+#define NSS_CC_UNIPHY_PORT3_RX_CLK_ARES 31
+#define NSS_CC_UNIPHY_PORT3_TX_CLK_ARES 32
+#define NSS_CC_XGMAC0_PTP_REF_CLK_ARES 33
+#define NSS_CC_XGMAC1_PTP_REF_CLK_ARES 34
+#define NSS_CC_XGMAC2_PTP_REF_CLK_ARES 35
+
+#endif
--
2.34.1On 17/06/2025 14:06, Luo Jie wrote: > NSS clock controller provides the clocks and resets to the > networking blocks such as PPE (Packet Process Engine) and > UNIPHY (PCS) on IPQ5424 devices. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Add the compatible "qcom,ipq5424-nsscc" support based on the > current IPQ9574 NSS clock controller DT binding file. > ICC clocks are always provided by the NSS clock controller > of IPQ9574 and IPQ5424, so add interconnect-cells as required > DT property. > > Also add master/slave ids for IPQ5424 networking interfaces, > which is used by nss-ipq5424 driver for providing interconnect > services using icc-clk framework. > > Signed-off-by: Luo Jie <quic_luoj@quicinc.com> > --- > .../bindings/clock/qcom,ipq9574-nsscc.yaml | 66 +++++++++++++++++++--- > include/dt-bindings/clock/qcom,ipq5424-nsscc.h | 65 +++++++++++++++++++++ > include/dt-bindings/interconnect/qcom,ipq5424.h | 13 +++++ > include/dt-bindings/reset/qcom,ipq5424-nsscc.h | 46 +++++++++++++++ > 4 files changed, 182 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml > index 17252b6ea3be..5bc2fe049b26 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/clock/qcom,ipq9574-nsscc.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Qualcomm Networking Sub System Clock & Reset Controller on IPQ9574 > +title: Qualcomm Networking Sub System Clock & Reset Controller on IPQ9574 and IPQ5424 > > maintainers: > - Bjorn Andersson <andersson@kernel.org> > @@ -12,21 +12,25 @@ maintainers: > > description: | > Qualcomm networking sub system clock control module provides the clocks, > - resets on IPQ9574 > + resets on IPQ9574 and IPQ5424 > > - See also:: > + See also: > + include/dt-bindings/clock/qcom,ipq5424-nsscc.h > include/dt-bindings/clock/qcom,ipq9574-nsscc.h > + include/dt-bindings/reset/qcom,ipq5424-nsscc.h > include/dt-bindings/reset/qcom,ipq9574-nsscc.h > > properties: > compatible: > - const: qcom,ipq9574-nsscc > + enum: > + - qcom,ipq5424-nsscc > + - qcom,ipq9574-nsscc > > clocks: > items: > - description: Board XO source > - - description: CMN_PLL NSS 1200MHz (Bias PLL cc) clock source > - - description: CMN_PLL PPE 353MHz (Bias PLL ubi nc) clock source > + - description: CMN_PLL NSS 1200 MHz or 300 MHZ (Bias PLL cc) clock source > + - description: CMN_PLL PPE 353 MHz or 375 MHZ (Bias PLL ubi nc) clock source This change means devices are different. Just ocme with your own schema. Best regards, Krzysztof
On 6/17/2025 10:49 PM, Krzysztof Kozlowski wrote: > On 17/06/2025 14:06, Luo Jie wrote: >> NSS clock controller provides the clocks and resets to the >> networking blocks such as PPE (Packet Process Engine) and >> UNIPHY (PCS) on IPQ5424 devices. > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > OK. >> >> Add the compatible "qcom,ipq5424-nsscc" support based on the >> current IPQ9574 NSS clock controller DT binding file. >> ICC clocks are always provided by the NSS clock controller >> of IPQ9574 and IPQ5424, so add interconnect-cells as required >> DT property. >> >> Also add master/slave ids for IPQ5424 networking interfaces, >> which is used by nss-ipq5424 driver for providing interconnect >> services using icc-clk framework. >> >> Signed-off-by: Luo Jie <quic_luoj@quicinc.com> >> --- >> .../bindings/clock/qcom,ipq9574-nsscc.yaml | 66 +++++++++++++++++++--- >> include/dt-bindings/clock/qcom,ipq5424-nsscc.h | 65 +++++++++++++++++++++ >> include/dt-bindings/interconnect/qcom,ipq5424.h | 13 +++++ >> include/dt-bindings/reset/qcom,ipq5424-nsscc.h | 46 +++++++++++++++ >> 4 files changed, 182 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >> index 17252b6ea3be..5bc2fe049b26 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >> @@ -4,7 +4,7 @@ >> $id: http://devicetree.org/schemas/clock/qcom,ipq9574-nsscc.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> -title: Qualcomm Networking Sub System Clock & Reset Controller on IPQ9574 >> +title: Qualcomm Networking Sub System Clock & Reset Controller on IPQ9574 and IPQ5424 >> >> maintainers: >> - Bjorn Andersson <andersson@kernel.org> >> @@ -12,21 +12,25 @@ maintainers: >> >> description: | >> Qualcomm networking sub system clock control module provides the clocks, >> - resets on IPQ9574 >> + resets on IPQ9574 and IPQ5424 >> >> - See also:: >> + See also: >> + include/dt-bindings/clock/qcom,ipq5424-nsscc.h >> include/dt-bindings/clock/qcom,ipq9574-nsscc.h >> + include/dt-bindings/reset/qcom,ipq5424-nsscc.h >> include/dt-bindings/reset/qcom,ipq9574-nsscc.h >> >> properties: >> compatible: >> - const: qcom,ipq9574-nsscc >> + enum: >> + - qcom,ipq5424-nsscc >> + - qcom,ipq9574-nsscc >> >> clocks: >> items: >> - description: Board XO source >> - - description: CMN_PLL NSS 1200MHz (Bias PLL cc) clock source >> - - description: CMN_PLL PPE 353MHz (Bias PLL ubi nc) clock source >> + - description: CMN_PLL NSS 1200 MHz or 300 MHZ (Bias PLL cc) clock source >> + - description: CMN_PLL PPE 353 MHz or 375 MHZ (Bias PLL ubi nc) clock source > > This change means devices are different. Just ocme with your own schema. The NSS clock controller hardware block on the IPQ5424 SoC is identical in design to that of the IPQ9574 SoC. The main difference is in the clock rates for its two parent clocks sourced from the CMN PLL block. Given this, would it be acceptable to update the clock name and its description to use a more generic clock name, such as "nss" and "ppe" instead of the current "nss_1200" and "ppe_353"? > > Best regards, > Krzysztof
On 6/18/25 5:58 PM, Luo Jie wrote: > > > On 6/17/2025 10:49 PM, Krzysztof Kozlowski wrote: >> On 17/06/2025 14:06, Luo Jie wrote: >>> NSS clock controller provides the clocks and resets to the >>> networking blocks such as PPE (Packet Process Engine) and >>> UNIPHY (PCS) on IPQ5424 devices. >> >> Please wrap commit message according to Linux coding style / submission >> process (neither too early nor over the limit): >> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 >> > > OK. > >>> >>> Add the compatible "qcom,ipq5424-nsscc" support based on the >>> current IPQ9574 NSS clock controller DT binding file. >>> ICC clocks are always provided by the NSS clock controller >>> of IPQ9574 and IPQ5424, so add interconnect-cells as required >>> DT property. >>> >>> Also add master/slave ids for IPQ5424 networking interfaces, >>> which is used by nss-ipq5424 driver for providing interconnect >>> services using icc-clk framework. >>> >>> Signed-off-by: Luo Jie <quic_luoj@quicinc.com> >>> --- >>> .../bindings/clock/qcom,ipq9574-nsscc.yaml | 66 +++++++++++++++++++--- >>> include/dt-bindings/clock/qcom,ipq5424-nsscc.h | 65 +++++++++++++++++++++ >>> include/dt-bindings/interconnect/qcom,ipq5424.h | 13 +++++ >>> include/dt-bindings/reset/qcom,ipq5424-nsscc.h | 46 +++++++++++++++ >>> 4 files changed, 182 insertions(+), 8 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >>> index 17252b6ea3be..5bc2fe049b26 100644 >>> --- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >>> +++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml >>> @@ -4,7 +4,7 @@ >>> $id: http://devicetree.org/schemas/clock/qcom,ipq9574-nsscc.yaml# >>> $schema: http://devicetree.org/meta-schemas/core.yaml# >>> -title: Qualcomm Networking Sub System Clock & Reset Controller on IPQ9574 >>> +title: Qualcomm Networking Sub System Clock & Reset Controller on IPQ9574 and IPQ5424 >>> maintainers: >>> - Bjorn Andersson <andersson@kernel.org> >>> @@ -12,21 +12,25 @@ maintainers: >>> description: | >>> Qualcomm networking sub system clock control module provides the clocks, >>> - resets on IPQ9574 >>> + resets on IPQ9574 and IPQ5424 >>> - See also:: >>> + See also: >>> + include/dt-bindings/clock/qcom,ipq5424-nsscc.h >>> include/dt-bindings/clock/qcom,ipq9574-nsscc.h >>> + include/dt-bindings/reset/qcom,ipq5424-nsscc.h >>> include/dt-bindings/reset/qcom,ipq9574-nsscc.h >>> properties: >>> compatible: >>> - const: qcom,ipq9574-nsscc >>> + enum: >>> + - qcom,ipq5424-nsscc >>> + - qcom,ipq9574-nsscc >>> clocks: >>> items: >>> - description: Board XO source >>> - - description: CMN_PLL NSS 1200MHz (Bias PLL cc) clock source >>> - - description: CMN_PLL PPE 353MHz (Bias PLL ubi nc) clock source >>> + - description: CMN_PLL NSS 1200 MHz or 300 MHZ (Bias PLL cc) clock source >>> + - description: CMN_PLL PPE 353 MHz or 375 MHZ (Bias PLL ubi nc) clock source >> >> This change means devices are different. Just ocme with your own schema. > > The NSS clock controller hardware block on the IPQ5424 SoC is identical > in design to that of the IPQ9574 SoC. The main difference is in the > clock rates for its two parent clocks sourced from the CMN PLL block. > > Given this, would it be acceptable to update the clock name and its > description to use a more generic clock name, such as "nss" and "ppe" > instead of the current "nss_1200" and "ppe_353"? Because you used those clock_names in the existing ipq9574, you can't change them now. You could introduce a separate set of clock_names for the new ipq5424 though, but I think it could be useful to drop the rate suffix for new additions Konrad
On 6/21/2025 6:09 PM, Konrad Dybcio wrote: >>>> compatible: >>>> - const: qcom,ipq9574-nsscc >>>> + enum: >>>> + - qcom,ipq5424-nsscc >>>> + - qcom,ipq9574-nsscc >>>> clocks: >>>> items: >>>> - description: Board XO source >>>> - - description: CMN_PLL NSS 1200MHz (Bias PLL cc) clock source >>>> - - description: CMN_PLL PPE 353MHz (Bias PLL ubi nc) clock source >>>> + - description: CMN_PLL NSS 1200 MHz or 300 MHZ (Bias PLL cc) clock source >>>> + - description: CMN_PLL PPE 353 MHz or 375 MHZ (Bias PLL ubi nc) clock source >>> This change means devices are different. Just ocme with your own schema. >> The NSS clock controller hardware block on the IPQ5424 SoC is identical >> in design to that of the IPQ9574 SoC. The main difference is in the >> clock rates for its two parent clocks sourced from the CMN PLL block. >> >> Given this, would it be acceptable to update the clock name and its >> description to use a more generic clock name, such as "nss" and "ppe" >> instead of the current "nss_1200" and "ppe_353"? > Because you used those clock_names in the existing ipq9574, you can't > change them now. You could introduce a separate set of clock_names > for the new ipq5424 though, but I think it could be useful to drop the > rate suffix for new additions > > Konrad OK, Understand, I will add the new separate clock names "nss" and "ppe" for supporting IPQ5424 SoC and further SoCs with similar design. Thanks for confirmation.
© 2016 - 2025 Red Hat, Inc.