[PATCH v2 0/2] Fix tuning on eUSB2 repeater

Luca Weiss posted 2 patches 3 months, 3 weeks ago
.../bindings/phy/qcom,snps-eusb2-repeater.yaml     |  3 -
drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c     | 83 ++++++++--------------
2 files changed, 30 insertions(+), 56 deletions(-)
[PATCH v2 0/2] Fix tuning on eUSB2 repeater
Posted by Luca Weiss 3 months, 3 weeks ago
Update the dt-bindings to remove the 'default' tuning values, since they
depend on the PMIC and are not guaranteed to be the same.

And add a fix into the driver to not zero-out all tuning registers if
they are not specified in the "init sequence", since zero is not the
reset value for most parameter and will lead to very unexpected tuning.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v2:
- Fix wrong parameter used for refactored init tables
- Also drop "enum eusb2_reg_layout" completely since it's not used for
  anything now
- Use unsigned int instead of u8 in struct eusb2_repeater_init_tbl_reg
- Pick up tags
- Link to v1: https://lore.kernel.org/r/20250616-eusb2-repeater-tuning-v1-0-9457ff0fbf75@fairphone.com

---
Luca Weiss (2):
      dt-bindings: phy: qcom,snps-eusb2-repeater: Remove default tuning values
      phy: qualcomm: phy-qcom-eusb2-repeater: Don't zero-out registers

 .../bindings/phy/qcom,snps-eusb2-repeater.yaml     |  3 -
 drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c     | 83 ++++++++--------------
 2 files changed, 30 insertions(+), 56 deletions(-)
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250616-eusb2-repeater-tuning-f56331c6b1fa

Best regards,
-- 
Luca Weiss <luca.weiss@fairphone.com>
Re: (subset) [PATCH v2 0/2] Fix tuning on eUSB2 repeater
Posted by Vinod Koul 3 months, 2 weeks ago
On Tue, 17 Jun 2025 10:26:34 +0200, Luca Weiss wrote:
> Update the dt-bindings to remove the 'default' tuning values, since they
> depend on the PMIC and are not guaranteed to be the same.
> 
> And add a fix into the driver to not zero-out all tuning registers if
> they are not specified in the "init sequence", since zero is not the
> reset value for most parameter and will lead to very unexpected tuning.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: phy: qcom,snps-eusb2-repeater: Remove default tuning values
      commit: db9f3e3ff9347a233a17eadefae9c1b29ec8f3ed

Best regards,
-- 
~Vinod