From: Frank Wunderlich <frank-w@public-files.de>
Update binding for mt7988 which has 3 gmac and 2 reg items.
With RSS-IRQs the interrupt max-items is now 6. Add interrupt-names
to make them accessible by name.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v4:
- increase max interrupts to 8 because of RSS/LRO interrupts
- dropped Robs RB due to this change
- allow interrupt names
- add interrupt-names without reserved IRQs on mt7988
this requires mtk driver patch:
https://patchwork.kernel.org/project/netdevbpf/patch/20250616080738.117993-2-linux@fw-web.de/
v2:
- change reg to list of items
---
.../devicetree/bindings/net/mediatek,net.yaml | 28 ++++++++++++++++---
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
index 9e02fd80af83..f8025f73b1cb 100644
--- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
+++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
@@ -28,7 +28,10 @@ properties:
- ralink,rt5350-eth
reg:
- maxItems: 1
+ items:
+ - description: Register for accessing the MACs.
+ - description: SoC internal SRAM used for DMA operations.
+ minItems: 1
clocks:
minItems: 2
@@ -40,7 +43,11 @@ properties:
interrupts:
minItems: 1
- maxItems: 4
+ maxItems: 6
+
+ interrupt-names:
+ minItems: 1
+ maxItems: 6
power-domains:
maxItems: 1
@@ -348,7 +355,17 @@ allOf:
then:
properties:
interrupts:
- minItems: 4
+ minItems: 2
+
+ interrupt-names:
+ minItems: 2
+ items:
+ - const: tx
+ - const: rx
+ - const: rx-ring0
+ - const: rx-ring1
+ - const: rx-ring2
+ - const: rx-ring3
clocks:
minItems: 24
@@ -381,8 +398,11 @@ allOf:
- const: xgp2
- const: xgp3
+ reg:
+ minItems: 2
+
patternProperties:
- "^mac@[0-1]$":
+ "^mac@[0-2]$":
type: object
unevaluatedProperties: false
allOf:
--
2.43.0On Mon, 16 Jun 2025 11:58:11 +0200, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Update binding for mt7988 which has 3 gmac and 2 reg items. > > With RSS-IRQs the interrupt max-items is now 6. Add interrupt-names > to make them accessible by name. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > v4: > - increase max interrupts to 8 because of RSS/LRO interrupts > - dropped Robs RB due to this change > - allow interrupt names > - add interrupt-names without reserved IRQs on mt7988 > this requires mtk driver patch: > https://patchwork.kernel.org/project/netdevbpf/patch/20250616080738.117993-2-linux@fw-web.de/ > > v2: > - change reg to list of items > --- > .../devicetree/bindings/net/mediatek,net.yaml | 28 ++++++++++++++++--- > 1 file changed, 24 insertions(+), 4 deletions(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Am 18. Juni 2025 19:38:07 MESZ schrieb "Rob Herring (Arm)" <robh@kernel.org>: > >On Mon, 16 Jun 2025 11:58:11 +0200, Frank Wunderlich wrote: >> From: Frank Wunderlich <frank-w@public-files.de> >> >> Update binding for mt7988 which has 3 gmac and 2 reg items. >> >> With RSS-IRQs the interrupt max-items is now 6. Add interrupt-names >> to make them accessible by name. >> >> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> >> --- >> v4: >> - increase max interrupts to 8 because of RSS/LRO interrupts >> - dropped Robs RB due to this change >> - allow interrupt names >> - add interrupt-names without reserved IRQs on mt7988 >> this requires mtk driver patch: >> https://patchwork.kernel.org/project/netdevbpf/patch/20250616080738.117993-2-linux@fw-web.de/ >> >> v2: >> - change reg to list of items >> --- >> .../devicetree/bindings/net/mediatek,net.yaml | 28 ++++++++++++++++--- >> 1 file changed, 24 insertions(+), 4 deletions(-) >> > >Reviewed-by: Rob Herring (Arm) <robh@kernel.org> Thank you rob. Have you seen my reponse to coverletter? Got info from mtk that reserved irqs are not unusable (only currently unused) and imho they should be upstreamed too but without a special meaning. What do you think? I would increase the interupts count to 8 and name the reserved irqs fe0..fe3. can i keep your RB or should i drop it again? regards Frank
On Mon, Jun 16, 2025 at 11:58:11AM +0200, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Update binding for mt7988 which has 3 gmac and 2 reg items. > > With RSS-IRQs the interrupt max-items is now 6. Add interrupt-names > to make them accessible by name. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > v4: > - increase max interrupts to 8 because of RSS/LRO interrupts But the schema says 6? > - dropped Robs RB due to this change > - allow interrupt names > - add interrupt-names without reserved IRQs on mt7988 > this requires mtk driver patch: > https://patchwork.kernel.org/project/netdevbpf/patch/20250616080738.117993-2-linux@fw-web.de/ > > v2: > - change reg to list of items > --- > .../devicetree/bindings/net/mediatek,net.yaml | 28 ++++++++++++++++--- > 1 file changed, 24 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml > index 9e02fd80af83..f8025f73b1cb 100644 > --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml > +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml > @@ -28,7 +28,10 @@ properties: > - ralink,rt5350-eth > > reg: > - maxItems: 1 > + items: > + - description: Register for accessing the MACs. > + - description: SoC internal SRAM used for DMA operations. > + minItems: 1 > > clocks: > minItems: 2 > @@ -40,7 +43,11 @@ properties: > > interrupts: > minItems: 1 > - maxItems: 4 > + maxItems: 6 > + > + interrupt-names: > + minItems: 1 > + maxItems: 6 > > power-domains: > maxItems: 1 > @@ -348,7 +355,17 @@ allOf: > then: > properties: > interrupts: > - minItems: 4 > + minItems: 2 > + > + interrupt-names: > + minItems: 2 > + items: > + - const: tx > + - const: rx > + - const: rx-ring0 > + - const: rx-ring1 > + - const: rx-ring2 > + - const: rx-ring3 > > clocks: > minItems: 24 > @@ -381,8 +398,11 @@ allOf: > - const: xgp2 > - const: xgp3 > > + reg: > + minItems: 2 > + > patternProperties: > - "^mac@[0-1]$": > + "^mac@[0-2]$": > type: object > unevaluatedProperties: false > allOf: > -- > 2.43.0 >
Am 17. Juni 2025 17:13:54 MESZ schrieb Rob Herring <robh@kernel.org>: >On Mon, Jun 16, 2025 at 11:58:11AM +0200, Frank Wunderlich wrote: >> From: Frank Wunderlich <frank-w@public-files.de> >> >> Update binding for mt7988 which has 3 gmac and 2 reg items. >> >> With RSS-IRQs the interrupt max-items is now 6. Add interrupt-names >> to make them accessible by name. >> >> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> >> --- >> v4: >> - increase max interrupts to 8 because of RSS/LRO interrupts > >But the schema says 6? Yes it was an error in changelog,see mail i sent later to you and ML. 8 was previously because original version had 2 reserved irqs around rx+tx i dropped later by using irq-names. See my patch introducing irq-names in mtk eth driver: <https://patchwork.kernel.org/project/linux-mediatek/patch/20250616080738.117993-2-linux@fw-web.de/> Original (downstream/sdk) was (but index-based): rsv rx tx rsv/misc rx-ring0 ... rx-ring3 So total 8 and i don't wanted to add 2 reserved irq to dts forever so i decided moving to irq-names now. >> - dropped Robs RB due to this change >> - allow interrupt names >> - add interrupt-names without reserved IRQs on mt7988 >> this requires mtk driver patch: >> https://patchwork.kernel.org/project/netdevbpf/patch/20250616080738.117993-2-linux@fw-web.de/ >> >> v2: >> - change reg to list of items >> --- >> .../devicetree/bindings/net/mediatek,net.yaml | 28 ++++++++++++++++--- >> 1 file changed, 24 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml >> index 9e02fd80af83..f8025f73b1cb 100644 >> --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml >> +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml >> @@ -28,7 +28,10 @@ properties: >> - ralink,rt5350-eth >> >> reg: >> - maxItems: 1 >> + items: >> + - description: Register for accessing the MACs. >> + - description: SoC internal SRAM used for DMA operations. >> + minItems: 1 >> >> clocks: >> minItems: 2 >> @@ -40,7 +43,11 @@ properties: >> >> interrupts: >> minItems: 1 >> - maxItems: 4 >> + maxItems: 6 >> + >> + interrupt-names: >> + minItems: 1 >> + maxItems: 6 >> >> power-domains: >> maxItems: 1 >> @@ -348,7 +355,17 @@ allOf: >> then: >> properties: >> interrupts: >> - minItems: 4 >> + minItems: 2 >> + >> + interrupt-names: >> + minItems: 2 >> + items: >> + - const: tx >> + - const: rx >> + - const: rx-ring0 >> + - const: rx-ring1 >> + - const: rx-ring2 >> + - const: rx-ring3 >> >> clocks: >> minItems: 24 >> @@ -381,8 +398,11 @@ allOf: >> - const: xgp2 >> - const: xgp3 >> >> + reg: >> + minItems: 2 >> + >> patternProperties: >> - "^mac@[0-1]$": >> + "^mac@[0-2]$": >> type: object >> unevaluatedProperties: false >> allOf: >> -- >> 2.43.0 >> regards Frank
Hi Rob, Krzysztof and Lorenzo, I got message from your mailserver, that my patch-mails are detected as Spam and blocked (to other address than i used - seems like forwarding from kernel.org to gmail.com). I want to make sure, you get it... I see it in dt-bindings patchwork, so replacing the content with a link. https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250616095828.160900-2-linux@fw-web.de/ only kept angelo, me and ML in this response to not spam people too much. regards Frank
© 2016 - 2025 Red Hat, Inc.