[PATCH v4 00/13] further mt7988 devicetree work

Frank Wunderlich posted 13 patches 3 months, 3 weeks ago
There is a newer version of this series
.../bindings/interconnect/mediatek,cci.yaml   |  11 +-
.../bindings/net/dsa/mediatek,mt7530.yaml     |  24 +-
.../devicetree/bindings/net/mediatek,net.yaml |  28 +-
.../mediatek/mt7988a-bananapi-bpi-r4-2g5.dts  |  11 +
.../dts/mediatek/mt7988a-bananapi-bpi-r4.dts  |  19 ++
.../dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi | 198 ++++++-----
arch/arm64/boot/dts/mediatek/mt7988a.dtsi     | 307 +++++++++++++++++-
7 files changed, 498 insertions(+), 100 deletions(-)
[PATCH v4 00/13] further mt7988 devicetree work
Posted by Frank Wunderlich 3 months, 3 weeks ago
From: Frank Wunderlich <frank-w@public-files.de>

This series continues mt7988 devicetree work

- Extend cpu frequency scaling with CCI
- GPIO leds
- Basic network-support (ethernet controller + builtin switch + SFP Cages)

depencies (i hope this list is complete and latest patches/series linked):

support interrupt-names because reserved IRQs are now dropped, so index based access is now wrong
https://patchwork.kernel.org/project/netdevbpf/patch/20250616080738.117993-2-linux@fw-web.de/

for SFP-Function (macs currently disabled):

PCS clearance which is a 1.5 year discussion currently ongoing

e.g. something like this (one of):
* https://patchwork.kernel.org/project/netdevbpf/patch/20250610233134.3588011-4-sean.anderson@linux.dev/ (v6)
* https://patchwork.kernel.org/project/netdevbpf/patch/20250511201250.3789083-4-ansuelsmth@gmail.com/ (v4)
* https://patchwork.kernel.org/project/netdevbpf/patch/ba4e359584a6b3bc4b3470822c42186d5b0856f9.1721910728.git.daniel@makrotopia.org/

full usxgmii driver:
https://patchwork.kernel.org/project/netdevbpf/patch/07845ec900ba41ff992875dce12c622277592c32.1702352117.git.daniel@makrotopia.org/

first PCS-discussion is here:
https://patchwork.kernel.org/project/netdevbpf/patch/8aa905080bdb6760875d62cb3b2b41258837f80e.1702352117.git.daniel@makrotopia.org/

and then dts nodes for sgmiisys+usxgmii+2g5 firmware

when above depencies are solved the mac1/2 can be enabled and 2.5G phy/SFP slots will work.

changes:
v4:
  net-binding:
    - allow interrupt names and increase max interrupts to 6 because of RSS/LRO interrupts
      (dropped Robs RB due to this change)

  dts-patches:
  - add interrupts for RSS/LRO and interrupt-names for ethernet node
  - eth-reg and clock whitespace-fix
  - comment for fixed-link on gmac0
  - drop phy-mode properties as suggested by andrew
  - drop phy-connection-type on 2g5 board
  - reorder some properties
  - update 2g5 phy node
    - unit-name dec instead of hex to match reg property
    - move compatible before reg
    - drop phy-mode

v3:
  - dropped patches already applied (SPI+thermal)
  - added soc specific cci compatible (new binding patch + changed dts)
  - enable 2g5 phy because driver is now merged
  - add patch for cleaning up unnecessary pins
  - add patch for gpio-leds
  - add patch for adding ethernet aliases

v2:
  - change reg to list of items in eth binding
  - changed mt7530 binding:
    - unevaluatedProperties=false
    - mediatek,pio subproperty
    - from patternProperty to property
  - board specific properties like led function and labels moved to bpi-r4 dtsi


Frank Wunderlich (13):
  dt-bindings: net: mediatek,net: update for mt7988
  dt-bindings: net: dsa: mediatek,mt7530: add dsa-port definition for
    mt7988
  dt-bindings: net: dsa: mediatek,mt7530: add internal mdio bus
  dt-bindings: interconnect: add mt7988-cci compatible
  arm64: dts: mediatek: mt7988: add cci node
  arm64: dts: mediatek: mt7988: add basic ethernet-nodes
  arm64: dts: mediatek: mt7988: add switch node
  arm64: dts: mediatek: mt7988a-bpi-r4: add proc-supply for cci
  arm64: dts: mediatek: mt7988a-bpi-r4: drop unused pins
  arm64: dts: mediatek: mt7988a-bpi-r4: add gpio leds
  arm64: dts: mediatek: mt7988a-bpi-r4: add aliases for ethernet
  arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmac
  arm64: dts: mediatek: mt7988a-bpi-r4: configure switch phys and leds

 .../bindings/interconnect/mediatek,cci.yaml   |  11 +-
 .../bindings/net/dsa/mediatek,mt7530.yaml     |  24 +-
 .../devicetree/bindings/net/mediatek,net.yaml |  28 +-
 .../mediatek/mt7988a-bananapi-bpi-r4-2g5.dts  |  11 +
 .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts  |  19 ++
 .../dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi | 198 ++++++-----
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi     | 307 +++++++++++++++++-
 7 files changed, 498 insertions(+), 100 deletions(-)

-- 
2.43.0
Re: [PATCH v4 00/13] further mt7988 devicetree work
Posted by AngeloGioacchino Del Regno 3 months, 3 weeks ago
Il 16/06/25 11:58, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
> 

I think that this series is ready to be applied; however, I need someone to take
the bindings before I can apply the devicetree part to the MediaTek trees.

Cheers,
Angelo


> This series continues mt7988 devicetree work
> 
> - Extend cpu frequency scaling with CCI
> - GPIO leds
> - Basic network-support (ethernet controller + builtin switch + SFP Cages)
> 
> depencies (i hope this list is complete and latest patches/series linked):
> 
> support interrupt-names because reserved IRQs are now dropped, so index based access is now wrong
> https://patchwork.kernel.org/project/netdevbpf/patch/20250616080738.117993-2-linux@fw-web.de/
> 
> for SFP-Function (macs currently disabled):
> 
> PCS clearance which is a 1.5 year discussion currently ongoing
> 
> e.g. something like this (one of):
> * https://patchwork.kernel.org/project/netdevbpf/patch/20250610233134.3588011-4-sean.anderson@linux.dev/ (v6)
> * https://patchwork.kernel.org/project/netdevbpf/patch/20250511201250.3789083-4-ansuelsmth@gmail.com/ (v4)
> * https://patchwork.kernel.org/project/netdevbpf/patch/ba4e359584a6b3bc4b3470822c42186d5b0856f9.1721910728.git.daniel@makrotopia.org/
> 
> full usxgmii driver:
> https://patchwork.kernel.org/project/netdevbpf/patch/07845ec900ba41ff992875dce12c622277592c32.1702352117.git.daniel@makrotopia.org/
> 
> first PCS-discussion is here:
> https://patchwork.kernel.org/project/netdevbpf/patch/8aa905080bdb6760875d62cb3b2b41258837f80e.1702352117.git.daniel@makrotopia.org/
> 
> and then dts nodes for sgmiisys+usxgmii+2g5 firmware
> 
> when above depencies are solved the mac1/2 can be enabled and 2.5G phy/SFP slots will work.
> 
> changes:
> v4:
>    net-binding:
>      - allow interrupt names and increase max interrupts to 6 because of RSS/LRO interrupts
>        (dropped Robs RB due to this change)
> 
>    dts-patches:
>    - add interrupts for RSS/LRO and interrupt-names for ethernet node
>    - eth-reg and clock whitespace-fix
>    - comment for fixed-link on gmac0
>    - drop phy-mode properties as suggested by andrew
>    - drop phy-connection-type on 2g5 board
>    - reorder some properties
>    - update 2g5 phy node
>      - unit-name dec instead of hex to match reg property
>      - move compatible before reg
>      - drop phy-mode
> 
> v3:
>    - dropped patches already applied (SPI+thermal)
>    - added soc specific cci compatible (new binding patch + changed dts)
>    - enable 2g5 phy because driver is now merged
>    - add patch for cleaning up unnecessary pins
>    - add patch for gpio-leds
>    - add patch for adding ethernet aliases
> 
> v2:
>    - change reg to list of items in eth binding
>    - changed mt7530 binding:
>      - unevaluatedProperties=false
>      - mediatek,pio subproperty
>      - from patternProperty to property
>    - board specific properties like led function and labels moved to bpi-r4 dtsi
> 
> 
> Frank Wunderlich (13):
>    dt-bindings: net: mediatek,net: update for mt7988
>    dt-bindings: net: dsa: mediatek,mt7530: add dsa-port definition for
>      mt7988
>    dt-bindings: net: dsa: mediatek,mt7530: add internal mdio bus
>    dt-bindings: interconnect: add mt7988-cci compatible
>    arm64: dts: mediatek: mt7988: add cci node
>    arm64: dts: mediatek: mt7988: add basic ethernet-nodes
>    arm64: dts: mediatek: mt7988: add switch node
>    arm64: dts: mediatek: mt7988a-bpi-r4: add proc-supply for cci
>    arm64: dts: mediatek: mt7988a-bpi-r4: drop unused pins
>    arm64: dts: mediatek: mt7988a-bpi-r4: add gpio leds
>    arm64: dts: mediatek: mt7988a-bpi-r4: add aliases for ethernet
>    arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmac
>    arm64: dts: mediatek: mt7988a-bpi-r4: configure switch phys and leds
> 
>   .../bindings/interconnect/mediatek,cci.yaml   |  11 +-
>   .../bindings/net/dsa/mediatek,mt7530.yaml     |  24 +-
>   .../devicetree/bindings/net/mediatek,net.yaml |  28 +-
>   .../mediatek/mt7988a-bananapi-bpi-r4-2g5.dts  |  11 +
>   .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts  |  19 ++
>   .../dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi | 198 ++++++-----
>   arch/arm64/boot/dts/mediatek/mt7988a.dtsi     | 307 +++++++++++++++++-
>   7 files changed, 498 insertions(+), 100 deletions(-)
>
Re: [PATCH v4 00/13] further mt7988 devicetree work
Posted by Frank Wunderlich 3 months, 3 weeks ago
Am 19. Juni 2025 07:57:09 MESZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>:
>Il 16/06/25 11:58, Frank Wunderlich ha scritto:
>> From: Frank Wunderlich <frank-w@public-files.de>
>> 
>
>I think that this series is ready to be applied; however, I need someone to take
>the bindings before I can apply the devicetree part to the MediaTek trees.

Please wait a bit for the eth part...seems like reserved irqs are not unusable as i thought...i think we should upstream them too and maybe with different names...as they are not fixed to function in hardware.

>Cheers,
>Angelo
>
>
>> This series continues mt7988 devicetree work
>> 
>> - Extend cpu frequency scaling with CCI
>> - GPIO leds
>> - Basic network-support (ethernet controller + builtin switch + SFP Cages)
>> 
>> depencies (i hope this list is complete and latest patches/series linked):
>> 
>> support interrupt-names because reserved IRQs are now dropped, so index based access is now wrong
>> https://patchwork.kernel.org/project/netdevbpf/patch/20250616080738.117993-2-linux@fw-web.de/
>> 
>> for SFP-Function (macs currently disabled):
>> 
>> PCS clearance which is a 1.5 year discussion currently ongoing
>> 
>> e.g. something like this (one of):
>> * https://patchwork.kernel.org/project/netdevbpf/patch/20250610233134.3588011-4-sean.anderson@linux.dev/ (v6)
>> * https://patchwork.kernel.org/project/netdevbpf/patch/20250511201250.3789083-4-ansuelsmth@gmail.com/ (v4)
>> * https://patchwork.kernel.org/project/netdevbpf/patch/ba4e359584a6b3bc4b3470822c42186d5b0856f9.1721910728.git.daniel@makrotopia.org/
>> 
>> full usxgmii driver:
>> https://patchwork.kernel.org/project/netdevbpf/patch/07845ec900ba41ff992875dce12c622277592c32.1702352117.git.daniel@makrotopia.org/
>> 
>> first PCS-discussion is here:
>> https://patchwork.kernel.org/project/netdevbpf/patch/8aa905080bdb6760875d62cb3b2b41258837f80e.1702352117.git.daniel@makrotopia.org/
>> 
>> and then dts nodes for sgmiisys+usxgmii+2g5 firmware
>> 
>> when above depencies are solved the mac1/2 can be enabled and 2.5G phy/SFP slots will work.
>> 
>> changes:
>> v4:
>>    net-binding:
>>      - allow interrupt names and increase max interrupts to 6 because of RSS/LRO interrupts
>>        (dropped Robs RB due to this change)
>> 
>>    dts-patches:
>>    - add interrupts for RSS/LRO and interrupt-names for ethernet node
>>    - eth-reg and clock whitespace-fix
>>    - comment for fixed-link on gmac0
>>    - drop phy-mode properties as suggested by andrew
>>    - drop phy-connection-type on 2g5 board
>>    - reorder some properties
>>    - update 2g5 phy node
>>      - unit-name dec instead of hex to match reg property
>>      - move compatible before reg
>>      - drop phy-mode
>> 
>> v3:
>>    - dropped patches already applied (SPI+thermal)
>>    - added soc specific cci compatible (new binding patch + changed dts)
>>    - enable 2g5 phy because driver is now merged
>>    - add patch for cleaning up unnecessary pins
>>    - add patch for gpio-leds
>>    - add patch for adding ethernet aliases
>> 
>> v2:
>>    - change reg to list of items in eth binding
>>    - changed mt7530 binding:
>>      - unevaluatedProperties=false
>>      - mediatek,pio subproperty
>>      - from patternProperty to property
>>    - board specific properties like led function and labels moved to bpi-r4 dtsi
>> 
>> 
>> Frank Wunderlich (13):
>>    dt-bindings: net: mediatek,net: update for mt7988
>>    dt-bindings: net: dsa: mediatek,mt7530: add dsa-port definition for
>>      mt7988
>>    dt-bindings: net: dsa: mediatek,mt7530: add internal mdio bus
>>    dt-bindings: interconnect: add mt7988-cci compatible
>>    arm64: dts: mediatek: mt7988: add cci node
>>    arm64: dts: mediatek: mt7988: add basic ethernet-nodes
>>    arm64: dts: mediatek: mt7988: add switch node
>>    arm64: dts: mediatek: mt7988a-bpi-r4: add proc-supply for cci
>>    arm64: dts: mediatek: mt7988a-bpi-r4: drop unused pins
>>    arm64: dts: mediatek: mt7988a-bpi-r4: add gpio leds
>>    arm64: dts: mediatek: mt7988a-bpi-r4: add aliases for ethernet
>>    arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmac
>>    arm64: dts: mediatek: mt7988a-bpi-r4: configure switch phys and leds
>> 
>>   .../bindings/interconnect/mediatek,cci.yaml   |  11 +-
>>   .../bindings/net/dsa/mediatek,mt7530.yaml     |  24 +-
>>   .../devicetree/bindings/net/mediatek,net.yaml |  28 +-
>>   .../mediatek/mt7988a-bananapi-bpi-r4-2g5.dts  |  11 +
>>   .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts  |  19 ++
>>   .../dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi | 198 ++++++-----
>>   arch/arm64/boot/dts/mediatek/mt7988a.dtsi     | 307 +++++++++++++++++-
>>   7 files changed, 498 insertions(+), 100 deletions(-)
>> 
>
>


regards Frank