[PATCH 1/2] LoongArch: KVM: INTC: Remove local variable device1

Bibo Mao posted 2 patches 7 months, 4 weeks ago
There is a newer version of this series
[PATCH 1/2] LoongArch: KVM: INTC: Remove local variable device1
Posted by Bibo Mao 7 months, 4 weeks ago
Local variable device1 can be replaced with existing variable device,
it makes code concise.

Signed-off-by: Bibo Mao <maobibo@loongson.cn>
---
 arch/loongarch/kvm/intc/eiointc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/loongarch/kvm/intc/eiointc.c b/arch/loongarch/kvm/intc/eiointc.c
index f39929d7bf8a..d9c4fe93405d 100644
--- a/arch/loongarch/kvm/intc/eiointc.c
+++ b/arch/loongarch/kvm/intc/eiointc.c
@@ -956,7 +956,7 @@ static int kvm_eiointc_create(struct kvm_device *dev, u32 type)
 {
 	int ret;
 	struct loongarch_eiointc *s;
-	struct kvm_io_device *device, *device1;
+	struct kvm_io_device *device;
 	struct kvm *kvm = dev->kvm;
 
 	/* eiointc has been created */
@@ -984,10 +984,10 @@ static int kvm_eiointc_create(struct kvm_device *dev, u32 type)
 		return ret;
 	}
 
-	device1 = &s->device_vext;
-	kvm_iodevice_init(device1, &kvm_eiointc_virt_ops);
+	device = &s->device_vext;
+	kvm_iodevice_init(device, &kvm_eiointc_virt_ops);
 	ret = kvm_io_bus_register_dev(kvm, KVM_IOCSR_BUS,
-			EIOINTC_VIRT_BASE, EIOINTC_VIRT_SIZE, device1);
+			EIOINTC_VIRT_BASE, EIOINTC_VIRT_SIZE, device);
 	if (ret < 0) {
 		kvm_io_bus_unregister_dev(kvm, KVM_IOCSR_BUS, &s->device);
 		kfree(s);
-- 
2.39.3
Re: [PATCH 1/2] LoongArch: KVM: INTC: Remove local variable device1
Posted by Huacai Chen 6 months, 4 weeks ago
Applied, thanks.


Huacai

On Mon, Jun 16, 2025 at 3:35 PM Bibo Mao <maobibo@loongson.cn> wrote:
>
> Local variable device1 can be replaced with existing variable device,
> it makes code concise.
>
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
>  arch/loongarch/kvm/intc/eiointc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/loongarch/kvm/intc/eiointc.c b/arch/loongarch/kvm/intc/eiointc.c
> index f39929d7bf8a..d9c4fe93405d 100644
> --- a/arch/loongarch/kvm/intc/eiointc.c
> +++ b/arch/loongarch/kvm/intc/eiointc.c
> @@ -956,7 +956,7 @@ static int kvm_eiointc_create(struct kvm_device *dev, u32 type)
>  {
>         int ret;
>         struct loongarch_eiointc *s;
> -       struct kvm_io_device *device, *device1;
> +       struct kvm_io_device *device;
>         struct kvm *kvm = dev->kvm;
>
>         /* eiointc has been created */
> @@ -984,10 +984,10 @@ static int kvm_eiointc_create(struct kvm_device *dev, u32 type)
>                 return ret;
>         }
>
> -       device1 = &s->device_vext;
> -       kvm_iodevice_init(device1, &kvm_eiointc_virt_ops);
> +       device = &s->device_vext;
> +       kvm_iodevice_init(device, &kvm_eiointc_virt_ops);
>         ret = kvm_io_bus_register_dev(kvm, KVM_IOCSR_BUS,
> -                       EIOINTC_VIRT_BASE, EIOINTC_VIRT_SIZE, device1);
> +                       EIOINTC_VIRT_BASE, EIOINTC_VIRT_SIZE, device);
>         if (ret < 0) {
>                 kvm_io_bus_unregister_dev(kvm, KVM_IOCSR_BUS, &s->device);
>                 kfree(s);
> --
> 2.39.3
>