[v1] net/mlx4_en: Remove the redundant NULL check for the 'my_ets' object

[PATCH net-next] net/mlx4_en: Remove the redundant NULL check for the 'my_ets' object

Posted by Ваторопин Андрей 3 months, 3 weeks ago

From: Andrey Vatoropin <a.vatoropin@crpt.ru>

Static analysis shows that pointer "my_ets" cannot be NULL because it 
points to the object "struct ieee_ets".

Remove the extra NULL check. It is meaningless and harms the readability
of the code.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Andrey Vatoropin <a.vatoropin@crpt.ru>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
---
Resend for net-next. Link to initial thread:
https://lore.kernel.org/netdev/20250401061439.9978-1-a.vatoropin@crpt.ru/
 drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c b/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
index 752a72499b4f..be80da03a594 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
@@ -290,9 +290,6 @@ static int mlx4_en_dcbnl_ieee_getets(struct net_device *dev,
 	struct mlx4_en_priv *priv = netdev_priv(dev);
 	struct ieee_ets *my_ets = &priv->ets;
 
-	if (!my_ets)
-		return -EINVAL;
-
 	ets->ets_cap = IEEE_8021QAZ_MAX_TCS;
 	ets->cbs = my_ets->cbs;
 	memcpy(ets->tc_tx_bw, my_ets->tc_tx_bw, sizeof(ets->tc_tx_bw));
-- 
2.43.0

Re: [PATCH net-next] net/mlx4_en: Remove the redundant NULL check for the 'my_ets' object

Posted by Jacob Keller 3 months, 3 weeks ago


On 6/15/2025 9:50 PM, Ваторопин Андрей wrote:
> From: Andrey Vatoropin <a.vatoropin@crpt.ru>
> 
> Static analysis shows that pointer "my_ets" cannot be NULL because it 
> points to the object "struct ieee_ets".
> 
> Remove the extra NULL check. It is meaningless and harms the readability
> of the code.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Andrey Vatoropin <a.vatoropin@crpt.ru>
> Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
> ---
> Resend for net-next. Link to initial thread:
> https://lore.kernel.org/netdev/20250401061439.9978-1-a.vatoropin@crpt.ru/
>  drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c b/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
> index 752a72499b4f..be80da03a594 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
> @@ -290,9 +290,6 @@ static int mlx4_en_dcbnl_ieee_getets(struct net_device *dev,
>  	struct mlx4_en_priv *priv = netdev_priv(dev);
>  	struct ieee_ets *my_ets = &priv->ets;
>  
> -	if (!my_ets)
> -		return -EINVAL;
> -
>  	ets->ets_cap = IEEE_8021QAZ_MAX_TCS;
>  	ets->cbs = my_ets->cbs;
>  	memcpy(ets->tc_tx_bw, my_ets->tc_tx_bw, sizeof(ets->tc_tx_bw));

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>