i2c: scx200_acb: add depends on HAS_IOPORT

[PATCH] i2c: scx200_acb: add depends on HAS_IOPORT

Posted by Randy Dunlap 7 months, 3 weeks ago

The scx200_acb driver uses inb()/outb() without depending on HAS_IOPORT,
which leads to build errors since kernel v6.13-rc1:
commit 6f043e757445 ("asm-generic/io.h: Remove I/O port accessors
for HAS_IOPORT=n")

Add the HAS_IOPORT dependency to prevent the build errors.

(Found in ARCH=um allmodconfig builds)

drivers/i2c/busses/scx200_acb.c: In function ‘scx200_acb_reset’:
include/asm-generic/io.h:596:15: error: call to ‘_outb’ declared with attribute error: outb() requires CONFIG_HAS_IOPORT

drivers/i2c/busses/scx200_acb.c:224:26: note: in expansion of macro ‘inb’
include/asm-generic/io.h:542:14: error: call to ‘_inb’ declared with attribute error: inb()) requires CONFIG_HAS_IOPORT
  224 |                 status = inb(ACBST);

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Arnd Bergmann <arnd@kernel.org>
Cc: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Jim Cromie <jim.cromie@gmail.com>
Cc: Andi Shyti <andi.shyti@kernel.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org
---
 drivers/i2c/busses/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-616-rc1.orig/drivers/i2c/busses/Kconfig
+++ lnx-616-rc1/drivers/i2c/busses/Kconfig
@@ -1530,7 +1530,7 @@ config I2C_XGENE_SLIMPRO
 
 config SCx200_ACB
 	tristate "Geode ACCESS.bus support"
-	depends on X86_32 && PCI
+	depends on X86_32 && PCI && HAS_IOPORT
 	help
 	  Enable the use of the ACCESS.bus controllers on the Geode SCx200 and
 	  SC1100 processors and the CS5535 and CS5536 Geode companion devices.
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 # v6.16-rc1

Re: [PATCH] i2c: scx200_acb: add depends on HAS_IOPORT

Posted by Wolfram Sang 7 months, 2 weeks ago

On Sun, Jun 15, 2025 at 11:36:58AM -0700, Randy Dunlap wrote:
> The scx200_acb driver uses inb()/outb() without depending on HAS_IOPORT,
> which leads to build errors since kernel v6.13-rc1:
> commit 6f043e757445 ("asm-generic/io.h: Remove I/O port accessors
> for HAS_IOPORT=n")
> 
> Add the HAS_IOPORT dependency to prevent the build errors.
> 
> (Found in ARCH=um allmodconfig builds)
> 
> drivers/i2c/busses/scx200_acb.c: In function ‘scx200_acb_reset’:
> include/asm-generic/io.h:596:15: error: call to ‘_outb’ declared with attribute error: outb() requires CONFIG_HAS_IOPORT
> 
> drivers/i2c/busses/scx200_acb.c:224:26: note: in expansion of macro ‘inb’
> include/asm-generic/io.h:542:14: error: call to ‘_inb’ declared with attribute error: inb()) requires CONFIG_HAS_IOPORT
>   224 |                 status = inb(ACBST);
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Arnd Bergmann <arnd@kernel.org>
> Cc: Niklas Schnelle <schnelle@linux.ibm.com>
> Cc: Jim Cromie <jim.cromie@gmail.com>
> Cc: Andi Shyti <andi.shyti@kernel.org>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: linux-i2c@vger.kernel.org

Applied to for-current, thanks!

Re: [PATCH] i2c: scx200_acb: add depends on HAS_IOPORT

Posted by Wolfram Sang 7 months, 2 weeks ago

On Fri, Jun 27, 2025 at 12:18:33PM +0200, Wolfram Sang wrote:
> On Sun, Jun 15, 2025 at 11:36:58AM -0700, Randy Dunlap wrote:
> > The scx200_acb driver uses inb()/outb() without depending on HAS_IOPORT,
> > which leads to build errors since kernel v6.13-rc1:
> > commit 6f043e757445 ("asm-generic/io.h: Remove I/O port accessors
> > for HAS_IOPORT=n")
> > 
> > Add the HAS_IOPORT dependency to prevent the build errors.
> > 
> > (Found in ARCH=um allmodconfig builds)
> > 
> > drivers/i2c/busses/scx200_acb.c: In function ‘scx200_acb_reset’:
> > include/asm-generic/io.h:596:15: error: call to ‘_outb’ declared with attribute error: outb() requires CONFIG_HAS_IOPORT
> > 
> > drivers/i2c/busses/scx200_acb.c:224:26: note: in expansion of macro ‘inb’
> > include/asm-generic/io.h:542:14: error: call to ‘_inb’ declared with attribute error: inb()) requires CONFIG_HAS_IOPORT
> >   224 |                 status = inb(ACBST);
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Arnd Bergmann <arnd@kernel.org>
> > Cc: Niklas Schnelle <schnelle@linux.ibm.com>
> > Cc: Jim Cromie <jim.cromie@gmail.com>
> > Cc: Andi Shyti <andi.shyti@kernel.org>
> > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Cc: linux-i2c@vger.kernel.org
> 
> Applied to for-current, thanks!

Ah, sorry, I already applied an earlier patch...