[v2] perf: Remove libcrypto dependency

[PATCH v2 0/4] perf: Remove libcrypto dependency

Eric Biggers posted 4 patches 3 months, 3 weeks ago

Diff against v1 v3
Download series mbox

There is a newer version of this series

tools/build/Makefile.feature            |  2 -
tools/build/feature/Makefile            |  4 -
tools/build/feature/test-all.c          |  5 --
tools/build/feature/test-libcrypto.c    | 25 -------
tools/perf/Documentation/perf-check.txt |  1 -
tools/perf/Makefile.config              | 17 +----
tools/perf/Makefile.perf                |  3 -
tools/perf/builtin-check.c              |  1 -
tools/perf/tests/make                   |  4 +-
tools/perf/tests/util.c                 | 45 +++++++++++-
tools/perf/util/Build                   |  1 +
tools/perf/util/genelf.c                | 85 +---------------------
tools/perf/util/sha1.c                  | 97 +++++++++++++++++++++++++
tools/perf/util/sha1.h                  |  6 ++
14 files changed, 156 insertions(+), 140 deletions(-)
delete mode 100644 tools/build/feature/test-libcrypto.c
create mode 100644 tools/perf/util/sha1.c
create mode 100644 tools/perf/util/sha1.h

Expand all Fold all

[PATCH v2 0/4] perf: Remove libcrypto dependency

Posted by Eric Biggers 3 months, 3 weeks ago

This is a reworked version of
https://lore.kernel.org/all/20250521225307.743726-1-yuzhuo@google.com/.
I've changed it to add a new minimal SHA-1 implementation, instead of
trying to pull in the kernel's SHA-1 implementation which is not really
designed to be extracted into userspace programs.  I also added a test.

Eric Biggers (2):
  perf build: enable -fno-strict-aliasing
  perf util: add a basic SHA-1 implementation

Yuzhuo Jing (2):
  perf genelf: Remove libcrypto dependency and use built-in sha1()
  tools: Remove libcrypto dependency

 tools/build/Makefile.feature            |  2 -
 tools/build/feature/Makefile            |  4 -
 tools/build/feature/test-all.c          |  5 --
 tools/build/feature/test-libcrypto.c    | 25 -------
 tools/perf/Documentation/perf-check.txt |  1 -
 tools/perf/Makefile.config              | 17 +----
 tools/perf/Makefile.perf                |  3 -
 tools/perf/builtin-check.c              |  1 -
 tools/perf/tests/make                   |  4 +-
 tools/perf/tests/util.c                 | 45 +++++++++++-
 tools/perf/util/Build                   |  1 +
 tools/perf/util/genelf.c                | 85 +---------------------
 tools/perf/util/sha1.c                  | 97 +++++++++++++++++++++++++
 tools/perf/util/sha1.h                  |  6 ++
 14 files changed, 156 insertions(+), 140 deletions(-)
 delete mode 100644 tools/build/feature/test-libcrypto.c
 create mode 100644 tools/perf/util/sha1.c
 create mode 100644 tools/perf/util/sha1.h


base-commit: 18531f4d1c8c47c4796289dbbc1ab657ffa063d2
-- 
2.49.0

Re: [PATCH v2 0/4] perf: Remove libcrypto dependency

Posted by Namhyung Kim 3 months, 2 weeks ago

Hello,

On Fri, Jun 13, 2025 at 09:41:29PM -0700, Eric Biggers wrote:
> This is a reworked version of
> https://lore.kernel.org/all/20250521225307.743726-1-yuzhuo@google.com/.
> I've changed it to add a new minimal SHA-1 implementation, instead of
> trying to pull in the kernel's SHA-1 implementation which is not really
> designed to be extracted into userspace programs.  I also added a test.
> 
> Eric Biggers (2):
>   perf build: enable -fno-strict-aliasing
>   perf util: add a basic SHA-1 implementation
> 
> Yuzhuo Jing (2):
>   perf genelf: Remove libcrypto dependency and use built-in sha1()
>   tools: Remove libcrypto dependency

Thanks for working on this.  But can you please rebase it on to the
latest perf-tools-next tree/branch?  It doesn't apply cleanly.

Thanks,
Namhyung

> 
>  tools/build/Makefile.feature            |  2 -
>  tools/build/feature/Makefile            |  4 -
>  tools/build/feature/test-all.c          |  5 --
>  tools/build/feature/test-libcrypto.c    | 25 -------
>  tools/perf/Documentation/perf-check.txt |  1 -
>  tools/perf/Makefile.config              | 17 +----
>  tools/perf/Makefile.perf                |  3 -
>  tools/perf/builtin-check.c              |  1 -
>  tools/perf/tests/make                   |  4 +-
>  tools/perf/tests/util.c                 | 45 +++++++++++-
>  tools/perf/util/Build                   |  1 +
>  tools/perf/util/genelf.c                | 85 +---------------------
>  tools/perf/util/sha1.c                  | 97 +++++++++++++++++++++++++
>  tools/perf/util/sha1.h                  |  6 ++
>  14 files changed, 156 insertions(+), 140 deletions(-)
>  delete mode 100644 tools/build/feature/test-libcrypto.c
>  create mode 100644 tools/perf/util/sha1.c
>  create mode 100644 tools/perf/util/sha1.h
> 
> 
> base-commit: 18531f4d1c8c47c4796289dbbc1ab657ffa063d2
> -- 
> 2.49.0
>

Re: [PATCH v2 0/4] perf: Remove libcrypto dependency

Posted by Eric Biggers 3 months, 2 weeks ago

On Tue, Jun 24, 2025 at 11:03:00AM -0700, Namhyung Kim wrote:
> Hello,
> 
> On Fri, Jun 13, 2025 at 09:41:29PM -0700, Eric Biggers wrote:
> > This is a reworked version of
> > https://lore.kernel.org/all/20250521225307.743726-1-yuzhuo@google.com/.
> > I've changed it to add a new minimal SHA-1 implementation, instead of
> > trying to pull in the kernel's SHA-1 implementation which is not really
> > designed to be extracted into userspace programs.  I also added a test.
> > 
> > Eric Biggers (2):
> >   perf build: enable -fno-strict-aliasing
> >   perf util: add a basic SHA-1 implementation
> > 
> > Yuzhuo Jing (2):
> >   perf genelf: Remove libcrypto dependency and use built-in sha1()
> >   tools: Remove libcrypto dependency
> 
> Thanks for working on this.  But can you please rebase it on to the
> latest perf-tools-next tree/branch?  It doesn't apply cleanly.
> 
> Thanks,
> Namhyung
> 

Done: https://lore.kernel.org/all/20250625202311.23244-1-ebiggers@kernel.org/

- Eric