[PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available

David Thompson posted 1 patch 3 months, 4 weeks ago
There is a newer version of this series
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
[PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available
Posted by David Thompson 3 months, 4 weeks ago
The message "Error getting PHY irq. Use polling instead"
is emitted when the mlxbf_gige driver is loaded by the
kernel before the associated gpio-mlxbf driver, and thus
the call to get the PHY IRQ fails since it is not yet
available. The driver probe() must return -EPROBE_DEFER
if acpi_dev_gpio_irq_get_by() returns the same.

Signed-off-by: David Thompson <davthompson@nvidia.com>
Reviewed-by: Asmaa Mnebhi <asmaa@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
index fb2e5b844c15..d76d7a945899 100644
--- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
+++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
@@ -447,8 +447,10 @@ static int mlxbf_gige_probe(struct platform_device *pdev)
 	priv->llu_plu_irq = platform_get_irq(pdev, MLXBF_GIGE_LLU_PLU_INTR_IDX);
 
 	phy_irq = acpi_dev_gpio_irq_get_by(ACPI_COMPANION(&pdev->dev), "phy", 0);
-	if (phy_irq < 0) {
-		dev_err(&pdev->dev, "Error getting PHY irq. Use polling instead");
+	if (phy_irq == -EPROBE_DEFER) {
+		err = -EPROBE_DEFER;
+		goto out;
+	} else if (phy_irq < 0) {
 		phy_irq = PHY_POLL;
 	}
 
-- 
2.43.2
Re: [PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available
Posted by Simon Horman 3 months, 3 weeks ago
On Fri, Jun 13, 2025 at 06:51:29PM +0000, David Thompson wrote:
> The message "Error getting PHY irq. Use polling instead"
> is emitted when the mlxbf_gige driver is loaded by the
> kernel before the associated gpio-mlxbf driver, and thus
> the call to get the PHY IRQ fails since it is not yet
> available. The driver probe() must return -EPROBE_DEFER
> if acpi_dev_gpio_irq_get_by() returns the same.
> 
> Signed-off-by: David Thompson <davthompson@nvidia.com>
> Reviewed-by: Asmaa Mnebhi <asmaa@nvidia.com>

Thanks David,

I as a bug fix this needs a Fixes tag, which you can add
by simply replying to this email.

Else we can treat it as an enhancement for net-next.