crypto/Makefile | 2 -- crypto/crc32.c | 65 +++++---------------------------------------- crypto/crc32c.c | 66 ++++------------------------------------------ crypto/testmgr.c | 2 ++ fs/btrfs/disk-io.c | 8 ++---- 5 files changed, 15 insertions(+), 128 deletions(-)
This series simplifies how the CRC32 library functions are exposed through the crypto_shash API. We'll now have just one shash algorithm each for "crc32" and "crc32c", and their driver names will just always be "crc32-lib" and "crc32c-lib" respectively. This seems to be all that's actually needed. As mentioned in patch 2, this does change the content of /sys/fs/btrfs/$uuid/checksum again, but that should be fine. This is based on v6.16-rc1, and I'm planning to take these patches through the crc-next tree. These supersede https://lore.kernel.org/r/20250601224441.778374-2-ebiggers@kernel.org/ and https://lore.kernel.org/r/20250601224441.778374-3-ebiggers@kernel.org/, and they fix the warning in the full crypto self-tests reported at https://lore.kernel.org/r/aExLZaoBCg55rZWJ@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com/ Eric Biggers (2): btrfs: stop parsing crc32c driver name crypto/crc32[c]: register only "-lib" drivers crypto/Makefile | 2 -- crypto/crc32.c | 65 +++++---------------------------------------- crypto/crc32c.c | 66 ++++------------------------------------------ crypto/testmgr.c | 2 ++ fs/btrfs/disk-io.c | 8 ++---- 5 files changed, 15 insertions(+), 128 deletions(-) base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 -- 2.49.0
On Fri, Jun 13, 2025 at 11:37:51AM -0700, Eric Biggers wrote: > This series simplifies how the CRC32 library functions are exposed > through the crypto_shash API. We'll now have just one shash algorithm > each for "crc32" and "crc32c", and their driver names will just always > be "crc32-lib" and "crc32c-lib" respectively. This seems to be all > that's actually needed. > > As mentioned in patch 2, this does change the content of > /sys/fs/btrfs/$uuid/checksum again, but that should be fine. Yes, this is fine, I don't think any ABI applies here and the implementation was only informative. > This is based on v6.16-rc1, and I'm planning to take these patches > through the crc-next tree. These supersede > https://lore.kernel.org/r/20250601224441.778374-2-ebiggers@kernel.org/ > and > https://lore.kernel.org/r/20250601224441.778374-3-ebiggers@kernel.org/, > and they fix the warning in the full crypto self-tests reported at > https://lore.kernel.org/r/aExLZaoBCg55rZWJ@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com/ > > Eric Biggers (2): > btrfs: stop parsing crc32c driver name > crypto/crc32[c]: register only "-lib" drivers Acked-by: David Sterba <dsterba@suse.com> Thanks.
On Fri, Jun 13, 2025 at 11:37:51AM -0700, Eric Biggers wrote: > This series simplifies how the CRC32 library functions are exposed > through the crypto_shash API. We'll now have just one shash algorithm > each for "crc32" and "crc32c", and their driver names will just always > be "crc32-lib" and "crc32c-lib" respectively. This seems to be all > that's actually needed. > > As mentioned in patch 2, this does change the content of > /sys/fs/btrfs/$uuid/checksum again, but that should be fine. > > This is based on v6.16-rc1, and I'm planning to take these patches > through the crc-next tree. These supersede > https://lore.kernel.org/r/20250601224441.778374-2-ebiggers@kernel.org/ > and > https://lore.kernel.org/r/20250601224441.778374-3-ebiggers@kernel.org/, > and they fix the warning in the full crypto self-tests reported at > https://lore.kernel.org/r/aExLZaoBCg55rZWJ@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com/ > > Eric Biggers (2): > btrfs: stop parsing crc32c driver name > crypto/crc32[c]: register only "-lib" drivers FYI, applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next as per the plan above. An ack from the btrfs folks on both patches would be appreciated, though. - Eric
© 2016 - 2025 Red Hat, Inc.